Page MenuHomePhabricator

[minor] Special:ClaimMentee - improvements for handling invalid input
Open, Needs TriagePublic

Description

(0) Submit button is always active

  1. Go to Special:ClaimMentee page - the 'Submit' button is displayed as active.
  2. Without entering anything in the fields, click on the 'Submit' button - two messages appear: "There are problems with some of your input." and "This value is required."

What should happen instead:

  • if there is no valid input (or no input) 'Submit' button should be inactive For example, Preferences-Notifications Mute users features doesn't display Submit button as active when no usernames or invalid user names are entered.

(1) A temp user name is recognized as a user name.
The drop down list of suggestions is displayed and a temp user name can be selected.

Screen Shot 2023-08-25 at 9.56.49 PM.png (2,204×756 px, 140 KB)
Screen Shot 2023-08-25 at 9.56.49 PM.png (2,204×756 px, 140 KB)
Screen Shot 2023-08-25 at 9.57.01 PM.png (1,690×760 px, 81 KB)

Only upon clicking 'Submit' button, the warning message appears: "Provided mentee's username is invalid' which might be confusing:

  • A temp user name is not invalid per se, it's Mentorship restriction on claiming temp users as a mentee. The warning message could be more specific.
  • The warning message comes only after clicking on 'Submit' button - users may benefit from being informed earlier that they cannot perform such an action.

(2) Fully typed temp user names will display different warning messages upon clicking

  • a mentor types a temp user name
  • it will be displayed in red (the correct behavior)
  • a mentor might click on the 'Submit' button.

The displayed warning messages are generic: "There are problems with some of your input." and "This value is required." and the "Mentee's username" field is cleared.

The messages might not be sufficient in explaining why valid user names (from the point of view of a mentor) were not accepted:

Screen Shot 2023-08-25 at 6.06.01 PM.png (2,196×746 px, 92 KB)
Screen Shot 2023-08-25 at 6.06.13 PM.png (2,142×924 px, 121 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh subscribed.

(1) A temp user name is recognized as a user name.

This will be actionable after T332030: Update user name widgets config to accept or deny temporary user names is done.

(1) A temp user name is recognized as a user name.

This will be actionable after T332030: Update user name widgets config to accept or deny temporary user names is done.

Thx, @kostajh for the update! Probably it's still worth to keep this task to review the cases after T332030 is done. I re-checked the issues in the task (just in case) - they are still valid (I removed from the task description the Console error - the error is not present anymore).

I think the case (1) Submit button is always active - is as per design.