Page MenuHomePhabricator

Update Tunnels Type schema VARBINARY value
Closed, InvalidPublic1 Estimated Story Points

Description

In the previous ticket, getTunnels() validated 2 values: "VPN" and "PROXY".
Then "UNKNOWN" was introduced as a valid ENUM in Tunnels Type array. The Schema needs to be updated as the original error reappears: "Data too long for column 'type' at row 1".

Request
Update Schema.sql to let Tunnels Type value accept up to 7 characters in order to let "UNKNOWN" be saved into the database

Expect behavior:
No "Data too long for column 'type' at row 1"" when importing files.

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Update Tunnels Type varbinary value to include 'UNKNOWN' as valid entryrepos/mediawiki/services/ipoid!53agueyteupdateSchemaTunnelsTypemain
Customize query in GitLab

Event Timeline

AGueyte set the point value for this task to 1.Aug 28 2023, 6:50 PM

tsepothoabala merged https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/53

Update Tunnels Type varbinary value to include 'UNKNOWN' as valid entry

@AGueyte When getting the reproduction data from https://phabricator.wikimedia.org/T339324. I am not getting the error of Data too long but now code: 'ER_TRUNCATED_WRONG_VALUE_FOR_FIELD'

2023-08-29_11-07-59.png (1×1 px, 506 KB)

@AGueyte No longer getting ER Data too long but getting once mentioned above. I created https://phabricator.wikimedia.org/T345201 and will close this task as we talked about. Thanks again for your work!

Removing inactive task assignee (please do so as part of offboarding steps).

Tunnels are now a bitmask.