Currently(wmf.24) the text in Praise-worthy mentees dialogs is displayed as rather tight.
Compare with the design:
| Etonkovidova | |
| Aug 31 2023, 12:05 AM |
| F37934730: Screen Shot 2023-10-03 at 2.43.57 PM.png | |
| Oct 3 2023, 9:46 PM |
| F37934727: Screen Shot 2023-10-03 at 2.41.08 PM.png | |
| Oct 3 2023, 9:46 PM |
| F37643621: Screen Shot 2023-08-30 at 4.51.03 PM.png | |
| Aug 31 2023, 12:05 AM |
| F37643619: Screen Shot 2023-08-30 at 4.55.57 PM.png | |
| Aug 31 2023, 12:05 AM |
| F37643617: Screen Shot 2023-08-30 at 4.59.16 PM.png | |
| Aug 31 2023, 12:05 AM |
Currently(wmf.24) the text in Praise-worthy mentees dialogs is displayed as rather tight.
Compare with the design:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | BUG REPORT | egardner | T343476 Ensure that Codex Dialogs are compatible with Vector | ||
| Resolved | BUG REPORT | Etonkovidova | T341944 Mentor dashboard Personalized praise settings view - overlapping and misbehavior of the drop-down | ||
| Resolved | Sgs | T345308 [minor] Praise-worthy mentees dialogs line height/spacing adjustments |
I think this is caused by the display bug I described in T341944#9129037. Marking as a subtask.
Ideally the fix should be applied in Vector (and also separately in Minerva and any other skins you need to support) – the styles should be added to skinStyles/mediawiki.page.ready.less as skinStyle overrides.
See https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/952950 for an example of how to do this. I just don't know the full set of body styles that are expected. I'd recommend coordinating with Web to ensure that the correct body text styles from the skins can be inherited in this new location.
Filed T347199. One minor issue to workaround is the default body padding in Codex's dialog will probably create an undesired extra vertical gutter above headings inside the dialog body. It would be nice to be able to configure the dialog body gutter somehow. Ideas welcome.
Change 961750 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] Personalized praise: avoid extra top gutter in settings form
Change 961750 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Personalized praise: avoid extra top gutter in settings form