Page MenuHomePhabricator

[minor] Praise-worthy mentees dialogs line height/spacing adjustments
Closed, ResolvedPublic

Description

Currently(wmf.24) the text in Praise-worthy mentees dialogs is displayed as rather tight.

Screen Shot 2023-08-30 at 4.59.16 PM.png (1×2 px, 466 KB)
Screen Shot 2023-08-30 at 4.55.57 PM.png (774×1 px, 152 KB)

Compare with the design:

Screen Shot 2023-08-30 at 4.51.03 PM.png (1×1 px, 303 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Ideally the fix should be applied in Vector (and also separately in Minerva and any other skins you need to support) – the styles should be added to skinStyles/mediawiki.page.ready.less as skinStyle overrides.

See https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/952950 for an example of how to do this. I just don't know the full set of body styles that are expected. I'd recommend coordinating with Web to ensure that the correct body text styles from the skins can be inherited in this new location.

Ideally the fix should be applied in Vector (and also separately in Minerva and any other skins you need to support) – the styles should be added to skinStyles/mediawiki.page.ready.less as skinStyle overrides.

See https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/952950 for an example of how to do this. I just don't know the full set of body styles that are expected. I'd recommend coordinating with Web to ensure that the correct body text styles from the skins can be inherited in this new location.

Filed T347199. One minor issue to workaround is the default body padding in Codex's dialog will probably create an undesired extra vertical gutter above headings inside the dialog body. It would be nice to be able to configure the dialog body gutter somehow. Ideas welcome.

Change 961750 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Personalized praise: avoid extra top gutter in settings form

https://gerrit.wikimedia.org/r/961750

Sgs moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.
Sgs edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

The underlying problem has been fixed upstream for all skins (T347199). Once 961750 is reviewed and merged this should be solved.

Sgs changed the task status from Open to In Progress.Sep 28 2023, 10:53 AM
Sgs moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 961750 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Personalized praise: avoid extra top gutter in settings form

https://gerrit.wikimedia.org/r/961750

Urbanecm_WMF changed the task status from In Progress to Open.Oct 2 2023, 9:02 AM
Urbanecm_WMF triaged this task as Low priority.
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

Checked in testwiki wmf.29 - the fix is in place:

Screen Shot 2023-10-03 at 2.41.08 PM.png (1×1 px, 250 KB)
Screen Shot 2023-10-03 at 2.43.57 PM.png (894×1 px, 143 KB)