Page MenuHomePhabricator

Improvements for "has email" column in EventDetails
Closed, ResolvedPublic

Description

Background: We will be changing how we display information on participant email addresses, so that it is both more clear and only displayed to people (in this case, organizers) who need to see the information. The text will be changed to more directly and clearly state that we are indicating who can receive an email from the organizer because they have an email address associated with their account and there is no preference that blocks them receiving emails from the organizer.

Acceptance criteria

  • On Special:EventDetails, the "has email" column should be shown to organizers only
  • The label of the column should be changed from "Has email" to "Can receive email"
  • The "List the participants of an event" endpoint should be updated so that the "user_is_valid_recipient" property is only included if the request was made by an organizer

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptAug 31 2023, 1:11 AM

@ifried @gonyeahialam I wanted to hear your opinion on this. We can talk about this next week, but I'd appreciate some preliminary thoughts. In Special:EventDetails, "Participants" tab, the "Has email" column is currently shown to all users. However, only organizers can send emails to participants, so I'm wondering if it would make sense to only show the column to organizers.

Secondarily, what the values in the column represent is not whether the participant has an email address on their account, but rather whether they can receive emails from the user who's reading the table (having set an email address is necessary, but not sufficient; other things like the mutelist and user blocks are taken into account). I am therefore wondering if the label should be made more explicit in this regard. Maybe it could say something like "Can receive email"?

Thanks for bringing this up, @Daimona! Here are my responses, and I'm curious to hear what @gonyeahialam thinks:

  • I think we should remove the "has email" column for participants. The information is unnecessary and confusing, since participants do not have the ability to email the full participant list (just individual participants via their user pages).
  • I agree that "Has email" is not clear, and we can change it to "Can receive email." While "Has email" was meant to demonstrate the the user has an email address associated with their account, it is a bit conceptually abstract and we should provide a more direct explanation to organizers.

Thanks for bringing this up, @Daimona! Here are my responses, and I'm curious to hear what @gonyeahialam thinks:

  • I think we should remove the "has email" column for participants. The information is unnecessary and confusing, since participants do not have the ability to email the full participant list (just individual participants via their user pages).
  • I agree that "Has email" is not clear, and we can change it to "Can receive email." While "Has email" was meant to demonstrate the the user has an email address associated with their account, it is a bit conceptually abstract and we should provide a more direct explanation to organizers.

I agree.

ifried renamed this task from (placeholder) Improvements for "has email" column in EventDetails to Improvements for "has email" column in EventDetails.Tue, Sep 5, 3:09 PM
ifried updated the task description. (Show Details)
Daimona updated the task description. (Show Details)

Change 954992 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Re-label "has email" and show it conditionally in EventDetails

https://gerrit.wikimedia.org/r/954992

Change 954992 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Re-label "has email" and show it conditionally in EventDetails

https://gerrit.wikimedia.org/r/954992

vaughnwalters added a subscriber: vaughnwalters.

โœ… On Special:EventDetails, the "has email" column should be shown to organizers only

Organizer Non organizer
Screenshot 2023-09-19 at 1.20.18 AM.png (718ร—1 px, 104 KB)
Screenshot 2023-09-19 at 1.26.22 AM.png (820ร—1 px, 115 KB)

โœ… The label of the column should be changed from "Has email" to "Can receive email"

Screenshot 2023-09-19 at 1.20.52 AM.png (198ร—1 px, 32 KB)

โœ… The "List the participants of an event" endpoint should be updated so that the "user_is_valid_recipient" property is only included if the request was made by an organizer

Organizer Non organizer
Screenshot 2023-09-19 at 2.45.35 AM.png (1ร—2 px, 457 KB)
Screenshot 2023-09-19 at 1.34.38 AM.png (1ร—2 px, 422 KB)

AC met, sending to design sign off