Page MenuHomePhabricator
Create Task
Maniphest T345373

TypeError: Argument 1 passed to MediaWiki\User\UserFactory::newFromName() must be of the type string, null given, called in /srv/mediawiki/php-1.41.0-wmf.24/extensions/LoginNotify/includes/Hooks.php on line 42
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   TypeError: Argument 1 passed to MediaWiki\User\UserFactory::newFromName() must be of the type string, null given, called in /srv/mediawiki/php-1.41.0-wmf.24/extensions/LoginNotify/includes/Hooks.php on line 42
error.stack_trace
from /srv/mediawiki/php-1.41.0-wmf.24/includes/user/UserFactory.php(105)
#0 /srv/mediawiki/php-1.41.0-wmf.24/extensions/LoginNotify/includes/Hooks.php(42): MediaWiki\User\UserFactory->newFromName(NULL, string)
#1 /srv/mediawiki/php-1.41.0-wmf.24/includes/HookContainer/HookContainer.php(161): LoginNotify\Hooks->onAuthManagerLoginAuthenticateAudit(MediaWiki\Auth\AuthenticationResponse, NULL, NULL, array)
#2 /srv/mediawiki/php-1.41.0-wmf.24/includes/HookContainer/HookRunner.php(890): MediaWiki\HookContainer\HookContainer->run(string, array)
#3 /srv/mediawiki/php-1.41.0-wmf.24/includes/auth/AuthManager.php(581): MediaWiki\HookContainer\HookRunner->onAuthManagerLoginAuthenticateAudit(MediaWiki\Auth\AuthenticationResponse, NULL, NULL, array)
#4 /srv/mediawiki/php-1.41.0-wmf.24/includes/auth/AuthManager.php(487): MediaWiki\Auth\AuthManager->continueAuthentication(array)
#5 /srv/mediawiki/php-1.41.0-wmf.24/includes/specialpage/AuthManagerSpecialPage.php(375): MediaWiki\Auth\AuthManager->beginAuthentication(array, string)
#6 /srv/mediawiki/php-1.41.0-wmf.24/includes/specialpage/AuthManagerSpecialPage.php(507): AuthManagerSpecialPage->performAuthenticationStep(string, array)
#7 /srv/mediawiki/php-1.41.0-wmf.24/includes/htmlform/HTMLForm.php(749): AuthManagerSpecialPage->handleFormSubmit(array, CodexHTMLForm)
#8 /srv/mediawiki/php-1.41.0-wmf.24/includes/specialpage/AuthManagerSpecialPage.php(438): HTMLForm->trySubmit()
#9 /srv/mediawiki/php-1.41.0-wmf.24/includes/specialpage/LoginSignupSpecialPage.php(318): AuthManagerSpecialPage->trySubmit()
#10 /srv/mediawiki/php-1.41.0-wmf.24/includes/specialpage/SpecialPage.php(701): LoginSignupSpecialPage->execute(NULL)
#11 /srv/mediawiki/php-1.41.0-wmf.24/includes/specialpage/SpecialPageFactory.php(1566): SpecialPage->run(NULL)
#12 /srv/mediawiki/php-1.41.0-wmf.24/includes/MediaWiki.php(344): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#13 /srv/mediawiki/php-1.41.0-wmf.24/includes/MediaWiki.php(942): MediaWiki->performRequest()
#14 /srv/mediawiki/php-1.41.0-wmf.24/includes/MediaWiki.php(591): MediaWiki->main()
#15 /srv/mediawiki/php-1.41.0-wmf.24/index.php(50): MediaWiki->run()
#16 /srv/mediawiki/php-1.41.0-wmf.24/index.php(46): wfIndexMain()
#17 /srv/mediawiki/w/index.php(3): require(string)
#18 {main}
Notes
  • Seeing a little less than one an hour for these across multiple wikis
  • Superficially similar to the CheckUser error from T310747

Details

Request URL
https://it.wikipedia.org/wiki/Speciale:Entra
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix type of $username in AuthManagerLoginAuthenticateAuditHookmediawiki/extensions/CheckUsermaster+1 -1
Hooks: Do not attempt user creation when there's no usernamemediawiki/extensions/LoginNotifywmf/1.41.0-wmf.24+7 -8
Hooks: Do not attempt user creation when there's no usernamemediawiki/extensions/LoginNotifymaster+7 -8
Customize query in gerrit

Related Objects

Event Timeline

thcipriani created this task.Aug 31 2023, 3:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2023, 3:42 PM
thcipriani moved this task from Untriaged to Aug 2023 on the Wikimedia-production-error board.Aug 31 2023, 3:43 PM
gerritbot added a comment.Aug 31 2023, 6:00 PM

Change 954116 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/extensions/LoginNotify@master] Hooks: Do not attempt user creation when there's no username

https://gerrit.wikimedia.org/r/954116

gerritbot added a project: Patch-For-Review.Aug 31 2023, 6:00 PM
tstarling subscribed.Sep 1 2023, 12:13 AM

User::newFromName() casts the name to a string. I changed it to use UserFactory in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/LoginNotify/+/952114 but UserFactory::newFromName() throws an exception instead of casting.

gerritbot added a comment.Sep 1 2023, 12:13 AM

Change 953662 had a related patch set uploaded (by Tim Starling; author: Ammarpad):

[mediawiki/extensions/LoginNotify@wmf/1.41.0-wmf.24] Hooks: Do not attempt user creation when there's no username

https://gerrit.wikimedia.org/r/953662

gerritbot added a comment.Sep 1 2023, 12:18 AM

Change 954116 merged by jenkins-bot:

[mediawiki/extensions/LoginNotify@master] Hooks: Do not attempt user creation when there's no username

https://gerrit.wikimedia.org/r/954116

Ammarpad mentioned this in rELGN3cd669d148e9: Hooks: Do not attempt user creation when there's no username.Sep 1 2023, 12:19 AM
tstarling added a comment.Sep 1 2023, 12:19 AM

The core documentation issue was fixed in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/954121 . The incorrect doc comment also exists in CheckUser so I will fix it there too.

gerritbot added a comment.Sep 1 2023, 12:21 AM

Change 954145 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/CheckUser@master] Fix type of $username in AuthManagerLoginAuthenticateAuditHook

https://gerrit.wikimedia.org/r/954145

gerritbot added a comment.Sep 1 2023, 12:27 AM

Change 953662 merged by jenkins-bot:

[mediawiki/extensions/LoginNotify@wmf/1.41.0-wmf.24] Hooks: Do not attempt user creation when there's no username

https://gerrit.wikimedia.org/r/953662

tstarling mentioned this in rELGN77928540498f: Hooks: Do not attempt user creation when there's no username.Sep 1 2023, 12:28 AM
Stashbot added a comment.Sep 1 2023, 12:43 AM

Mentioned in SAL (#wikimedia-operations) [2023-09-01T00:43:29Z] <tstarling@deploy1002> Synchronized php-1.41.0-wmf.24/extensions/LoginNotify/includes/Hooks.php: fix production error T345373 (duration: 06m 13s)

tstarling closed this task as Resolved.Sep 1 2023, 12:53 AM
tstarling claimed this task.

Logstash only shows 5 errors in the past 24 hours, so I am assuming that it is fixed rather than confirming.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.24; 2023-08-29).Sep 1 2023, 1:00 AM
gerritbot added a comment.Sep 1 2023, 5:05 AM

Change 954145 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Fix type of $username in AuthManagerLoginAuthenticateAuditHook

https://gerrit.wikimedia.org/r/954145

Maintenance_bot removed a project: Patch-For-Review.Sep 1 2023, 5:10 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.25; 2023-09-05); removed MW-1.41-notes (1.41.0-wmf.24; 2023-08-29).Sep 1 2023, 6:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits