Page MenuHomePhabricator

Mobile notifications are nearly invisible
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

See Original enwiki Teahouse discussion. (permalink)

Steps to replicate the issue (include links if applicable):

  1. In a new private window (or otherwise with an empty cache), go to https://en.m.wikipedia.org and log in to some account.
  2. From another account, leave a message on the talk page of the first account
  3. With the first account, navigate to some page other than your user talk page.

What happens?:

The "1" (or other number) near the upper right corner has no red circle behind it. It's just nearly invisible white-on-light-grey text.

What should have happened instead?:

The "1" (or other number) should have a red circle behind it, or otherwise use some background that makes it visible.

Other information (browser name/version, screenshots, etc.):

Tested with Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/115.0, in standard and "advanced" mode.

See also screenshot provided by @QuickQuokka

QA Results - Prod

ACStatusDetails
1T345483#9170911

Event Timeline

suffusion_of_yellow renamed this task from Mobile notifications are nearly nearly invisible to Mobile notifications are nearly invisible.Sep 1 2023, 11:31 PM

@Jdlrobson: Could this have something to do with the Codex switchover?

Appears to be related to 7a7e8e94b. At least, when I manually remove the !important, I get a large red square background, which is an improvement over no background at all.

lettherebedarklight triaged this task as Unbreak Now! priority.Sep 2 2023, 2:56 AM
Zabe lowered the priority of this task from Unbreak Now! to Needs Triage.Sep 2 2023, 10:38 AM

Yeh this looks bad and we should look into a fix.

Please note: setting priority on a ticket takes it out of web team's prioritization workflow so can actually slow down getting a fix out. Thanks Zabe for resetting it.

ovasileva set the point value for this task to 2.Sep 5 2023, 5:14 PM

Change 954976 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Fix unseen notifications icon

https://gerrit.wikimedia.org/r/954976

Change 954942 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@wmf/1.41.0-wmf.24] Fix unseen notifications icon

https://gerrit.wikimedia.org/r/954942

Change 954942 merged by Clare Ming:

[mediawiki/skins/MinervaNeue@wmf/1.41.0-wmf.24] Fix unseen notifications icon

https://gerrit.wikimedia.org/r/954942

Mentioned in SAL (#wikimedia-operations) [2023-09-05T20:33:02Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:954942|Fix unseen notifications icon (T345483)]]

Mentioned in SAL (#wikimedia-operations) [2023-09-05T20:34:38Z] <cjming@deploy1002> cjming and jdlrobson: Backport for [[gerrit:954942|Fix unseen notifications icon (T345483)]] synced to the testservers mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Change 954945 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@wmf/1.41.0-wmf.25] Fix unseen notifications icon

https://gerrit.wikimedia.org/r/954945

Mentioned in SAL (#wikimedia-operations) [2023-09-05T20:49:47Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:954942|Fix unseen notifications icon (T345483)]] (duration: 16m 45s)

Change 954976 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix unseen notifications icon

https://gerrit.wikimedia.org/r/954976

Change 954945 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.41.0-wmf.25] Fix unseen notifications icon

https://gerrit.wikimedia.org/r/954945

Mentioned in SAL (#wikimedia-operations) [2023-09-05T21:07:56Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:954945|Fix unseen notifications icon (T345483)]]

Mentioned in SAL (#wikimedia-operations) [2023-09-05T21:09:32Z] <cjming@deploy1002> jdlrobson and cjming: Backport for [[gerrit:954945|Fix unseen notifications icon (T345483)]] synced to the testservers mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Mentioned in SAL (#wikimedia-operations) [2023-09-05T21:21:43Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:954945|Fix unseen notifications icon (T345483)]] (duration: 13m 46s)

Edtadros added a subscriber: Edtadros.

@Jdlrobson please verify my testing since this wasn't tested in beta.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

In a new private window (or otherwise with an empty cache), go to https://en.m.wikipedia.org and log in to some account.
From another account, leave a message on the talk page of the first account
With the first account, navigate to some page other than your user talk page.
✅ AC1: The "1" (or other number) should have a red circle behind it, or otherwise use some background that makes it visible.

screenshot.png (907×962 px, 323 KB)