Page MenuHomePhabricator

Tagging a redirect for RFD deletion writes the RFD log entry incorrectly
Open, In Progress, Needs TriagePublicBUG REPORT

Description

Reported by Fork99 at https://en.wikipedia.org/wiki/Wikipedia_talk:New_pages_patrol/Reviewers#Possible_bug_in_the_curation_tool_when_you_RfD_a_redirect

Steps to replicate the issue (include links if applicable):

What happens?:

  • Log page has [[:{{{target}}}]] written to it

What should have happened instead?:

  • Log page should have the redirect target written to it. This target probably needs to be discovered with an API query, the result of which much be awaited before proceeding to write the log entry.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • High priority bug. RFD is broken. No one is going to want to use this workflow if they have to go edit every one of their RFDs in order to replace [[:{{{target}}}]] with the proper wikilink.

image.png (304×1 px, 42 KB)

Event Timeline

Change 954352 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] Add the redirect target to the template call while logging an RfD

https://gerrit.wikimedia.org/r/954352

Change 954352 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] Add the redirect target to the template call while logging an RfD

https://gerrit.wikimedia.org/r/954352

This patch is the best i could do under the circumstances. If someone wants to continue tweaking it they are welcome. I can't test on patchdemo since the "Wikipedia" namespace isn't enabled there.

Thanks for the quick turnaround! Does it just need some localhost testing?

Change 954352 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] Add the redirect target to the template call while logging an RfD

https://gerrit.wikimedia.org/r/954352

This patch is the best i could do under the circumstances. If someone wants to continue tweaking it they are welcome. I can't test on patchdemo since the "Wikipedia" namespace isn't enabled there.

I messed around with it a bit and made some changes :)

Test wiki created on Patch demo by Sohom Datta using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/d89cabad8a/w

Change 954393 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Add the redirect target to the template call while logging an RfD

https://gerrit.wikimedia.org/r/954393

Change 954352 abandoned by Novem Linguae:

[mediawiki/extensions/PageTriage@master] Add the redirect target to the template call while logging an RfD

Reason:

Using https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/954393 instead

https://gerrit.wikimedia.org/r/954352

MPGuy2824 changed the task status from Open to In Progress.Fri, Sep 22, 9:41 AM
MPGuy2824 assigned this task to Soda.
MPGuy2824 moved this task from Priority bugs to Code Review on the PageTriage board.