Page MenuHomePhabricator
Create Task
Maniphest T345496

If a user tries to place two of the same tag, should show a warning or silently delete one tag
Closed, ResolvedPublicBUG REPORT
Actions

Description

Reported by @Wbm1058 at https://en.wikipedia.org/w/index.php?title=Wikipedia:Page_Curation/Suggested_improvements&diff=prev&oldid=1173447601

Steps to replicate the issue (include links if applicable):

  • Visit a mainspace article
  • Be a patroller
  • In Page Curation toolbar, open maintenance tag menu
  • tick a tag in the "All" menu
  • tick the same tag in a submenu

What happens?:

  • writes two tags

What should have happened instead?:

  • should only write one tag
  • or should warn the user and prevent submission. not sure which yet. up to whoever writes the patch. the former would probably be easier to code

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Make sure different key values are handled while submittingmediawiki/extensions/PageTriagewmf/1.41.0-wmf.27+11 -2
Make sure different key values are handled while submittingmediawiki/extensions/PageTriagemaster+11 -2
Fix tag de-duplication and synchronization functionalitymediawiki/extensions/PageTriagemaster+12 -5
Customize query in gerrit

Related Objects

Event Timeline

Novem_Linguae created this task.Sep 2 2023, 4:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2023, 4:05 PM
Soda added a subscriber: Soda.Sep 3 2023, 7:52 PM

This might be a side effect of the fix at T332105 since there appears to be code that tries to resolve duplicates :(

gerritbot added a comment.Sep 3 2023, 7:54 PM

Change 954400 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Fix tag de-duplication and synchronization functionality

https://gerrit.wikimedia.org/r/954400

gerritbot added a project: Patch-For-Review.Sep 3 2023, 7:54 PM
gerritbot added a comment.Sep 14 2023, 9:40 AM

Change 954400 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Fix tag de-duplication and synchronization functionality

https://gerrit.wikimedia.org/r/954400

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.27; 2023-09-19).Sep 14 2023, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 14 2023, 10:10 AM
MPGuy2824 added a subscriber: MPGuy2824.Sep 22 2023, 3:32 AM

Issue still exists: https://en.wikipedia.org/w/index.php?title=Meru_District%2C_Kenya&diff=1176501761&oldid=1176501736

MPGuy2824 moved this task from Backlog to Priority bugs on the PageTriage board.Sep 22 2023, 3:33 AM
Soda added a comment.Sep 22 2023, 7:27 AM

This works fine locally, I wonder if there is some stuff that might be specific to enwiki that might be tripping this up :(

Also, @MPGuy2824 can you let me know if the 'All tags' column works fine on en-wiki (More footnotes is from the 'common' column AFAIR) ?

gerritbot added a comment.Sep 22 2023, 9:01 AM

Change 959963 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Make sure different key values are handled while submitting

https://gerrit.wikimedia.org/r/959963

gerritbot added a project: Patch-For-Review.Sep 22 2023, 9:01 AM
MPGuy2824 added a comment.Sep 22 2023, 9:07 AM
In T345496#9189955, @Soda wrote:

Also, @MPGuy2824 can you let me know if the 'All tags' column works fine on en-wiki (More footnotes is from the 'common' column AFAIR) ?

I had added the "no footnotes" tag from the "All tags" section. The other (duplicate) tag was selected automatically.

gerritbot added a comment.Sep 22 2023, 9:08 AM

Change 959986 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@wmf/1.41.0-wmf.27] Make sure different key values are handled while submitting

https://gerrit.wikimedia.org/r/959986

PatchDemoBot added a comment.Sep 22 2023, 9:15 AM

Test wiki created on Patch demo by MPGuy2824 using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/63f1607241/w

Soda added a comment.Sep 22 2023, 9:16 AM
In T345496#9190259, @MPGuy2824 wrote:
In T345496#9189955, @Soda wrote:

Also, @MPGuy2824 can you let me know if the 'All tags' column works fine on en-wiki (More footnotes is from the 'common' column AFAIR) ?

I had added the "no footnotes" tag from the "All tags" section. The other (duplicate) tag was selected automatically.

Yeah, I just tested this, looks like my fix had the unintentional effect of always adding duplicates :( (I had assumed that the deduplication code in T345496#9138850 was robust enough, turns out it had a edge case that it was not checking for)

MPGuy2824 changed the task status from Open to In Progress.Sep 22 2023, 9:43 AM
MPGuy2824 assigned this task to Soda.
MPGuy2824 triaged this task as Unbreak Now! priority.
MPGuy2824 moved this task from Priority bugs to Code Review on the PageTriage board.
gerritbot added a comment.Sep 22 2023, 9:17 PM

Change 959963 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Make sure different key values are handled while submitting

https://gerrit.wikimedia.org/r/959963

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.28; 2023-09-26); removed MW-1.41-notes (1.41.0-wmf.27; 2023-09-19).Sep 22 2023, 10:00 PM
MPGuy2824 moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.Sep 23 2023, 6:11 AM
Soda added a comment.Sep 23 2023, 12:13 PM

I've scheduled this to deploy on Monday 9:00-10:00 CEST which appears to be the first deploy window available

gerritbot added a comment.Sep 25 2023, 7:15 AM

Change 959986 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@wmf/1.41.0-wmf.27] Make sure different key values are handled while submitting

https://gerrit.wikimedia.org/r/959986

Stashbot added a comment.Sep 25 2023, 7:16 AM

Mentioned in SAL (#wikimedia-operations) [2023-09-25T07:16:30Z] <taavi@deploy2002> Started scap: Backport for [[gerrit:959986|Make sure different key values are handled while submitting (T345496)]]

Stashbot added a comment.Sep 25 2023, 7:29 AM

Mentioned in SAL (#wikimedia-operations) [2023-09-25T07:29:25Z] <taavi@deploy2002> taavi and soda: Backport for [[gerrit:959986|Make sure different key values are handled while submitting (T345496)]] synced to the testservers mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Maintenance_bot removed a project: Patch-For-Review.Sep 25 2023, 7:31 AM
Stashbot added a comment.Sep 25 2023, 7:47 AM

Mentioned in SAL (#wikimedia-operations) [2023-09-25T07:47:26Z] <taavi@deploy2002> Finished scap: Backport for [[gerrit:959986|Make sure different key values are handled while submitting (T345496)]] (duration: 30m 55s)

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.27; 2023-09-19); removed MW-1.41-notes (1.41.0-wmf.28; 2023-09-26).Sep 25 2023, 8:00 AM
Soda added a comment.Sep 25 2023, 1:09 PM

This issue should be fixed as of today morning (8:00 UTC) :) Thanks to @MPGuy2824 for helping test the fix for the bug :)

Soda closed this task as Resolved.Sep 25 2023, 1:09 PM
PatchDemoBot added a comment.Sep 29 2023, 10:23 AM

Test wiki on Patch demo by MPGuy2824 using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/63f1607241/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL