Page MenuHomePhabricator
Create Task
Maniphest T345725

[SW] [T-REF] [TECH] Chore: update tainted reference dependecies
Open, Needs TriagePublic
Actions

Description

Tainted Reference is in need for an overhaul of dependencies including upgrading node to v16 (used in CI).

  • some dependencies have already been upgraded here as part of resolving UBN T345660
  • Storybook has been dropped for the time being as too many peer dependencies have been breaking CI. Make sure to resolve those as well
  • you can use fresh-node to run npm ci to make sure it would pass for CI
  • we should add a section in the Tainted Reference README for updating dependencies, similarly to Query Build and Mismatch Finder.
  • in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/955306/ we had to install some additional dependencies for eslint plugins to make the new version of "eslint-config-wikimedia" work. It should be investigated if the rules that need them are actually needed here or if they can be deactivated and the dependencies dropped.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Drop Storybook from tainted referencesmediawiki/extensions/WikibaseREL1_40+112 -24 K
Fix tainted references dependency conflictsmediawiki/extensions/WikibaseREL1_40+5 K -5 K
Reenable tainted ref installation and testsmediawiki/extensions/Wikibasemaster+3 -3
Fix tainted references dependency conflictsmediawiki/extensions/Wikibasemaster+5 K -5 K
Drop Storybook from tainted referencesmediawiki/extensions/Wikibasemaster+112 -24 K
Customize query in gerrit

Related Objects

Event Timeline

• noarave created this task.Sep 6 2023, 11:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 6 2023, 11:39 AM
• noarave updated the task description. (Show Details)Sep 6 2023, 11:41 AM
gerritbot added a comment.Sep 6 2023, 11:41 AM

Change 955306 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] Fix tainted references dependency conflicts

https://gerrit.wikimedia.org/r/955306

• noarave added a project: [Archived]Wikidata Dev Team.Sep 6 2023, 11:41 AM
gerritbot added a project: Patch-For-Review.Sep 6 2023, 11:41 AM

Change 955314 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] Reenable tainted ref installation and tests

https://gerrit.wikimedia.org/r/955314

gerritbot added a comment.Sep 6 2023, 11:45 AM

Change 955302 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] Drop Storybook from tainted references

https://gerrit.wikimedia.org/r/955302

Maintenance_bot added a project: Wikidata.Sep 6 2023, 11:45 AM
gerritbot added a comment.Sep 6 2023, 12:08 PM

Change 955302 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Drop Storybook from tainted references

https://gerrit.wikimedia.org/r/955302

Michael updated the task description. (Show Details)Sep 6 2023, 12:19 PM
gerritbot added a comment.Sep 6 2023, 12:31 PM

Change 955306 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fix tainted references dependency conflicts

https://gerrit.wikimedia.org/r/955306

gerritbot added a comment.Sep 6 2023, 4:34 PM

Change 955314 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Reenable tainted ref installation and tests

https://gerrit.wikimedia.org/r/955314

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 6 2023, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 6 2023, 5:10 PM
ItamarWMDE moved this task from Incoming to [DOT] Tech Backlog on the [Archived]Wikidata Dev Team board.Sep 12 2023, 1:53 PM
• noarave added a subscriber: ItamarWMDE.Sep 19 2023, 9:11 AM

Storybook has been dropped for the time being as too many peer dependencies have been breaking CI. Make sure to resolve those as well

The quality tools team made a decision to disable non-essential dev tools for tainted references to reduce complexity of dependencies. Storybook should therefore not be enabled as long as no active development is taking place on the feature (decision record).

@ItamarWMDE Do we also want to remove the relevant part of the tainted-references README as part of this task?

Restricted Application added a project: User-ItamarWMDE. · View Herald TranscriptSep 19 2023, 9:11 AM
ItamarWMDE added a comment.Sep 20 2023, 6:50 AM

@noarave I would actually think that instead of removing all evidence of the current development workflows, we should at least document a process to bring them back if need be. What do you think?

• noarave added a comment.Sep 20 2023, 7:08 AM

@ItamarWMDE you're right, it was already updated by Michael when Storybook was disabled. we can maybe style that paragraph a bit more but other than that it should probably stay as it is.

ItamarWMDE renamed this task from [QT] Chore: update tainted reference dependecies to [T-REF] [TECH] Chore: update tainted reference dependecies.Sep 28 2023, 11:58 AM
ItamarWMDE moved this task from [DOT] Tech Backlog to [QT] Tech Backlog on the [Archived]Wikidata Dev Team board.
ItamarWMDE added a project: wmde-wikidata-tech.
ItamarWMDE moved this task from Incoming to [QT] By Project on the wmde-wikidata-tech board.Sep 28 2023, 12:00 PM
ItamarWMDE added a comment.EditedOct 10 2023, 1:28 PM

Task Review Notes:

  • This is a result of an incident that occured due to outdated dev dependencies, which made us realize that "Tainted References" was not being routinely updated.

Prio Notes:

  • Does not affect end users / production
  • Does not affect monitoring
  • Does affect development efforts
  • Does not affect onboarding
  • Does affect additional stakeholders (Other LOD teams, outdated dependencies may block Wikibase CI)
ItamarWMDE renamed this task from [T-REF] [TECH] Chore: update tainted reference dependecies to [SW] [T-REF] [TECH] Chore: update tainted reference dependecies.Oct 10 2023, 1:30 PM
ItamarWMDE moved this task from [QT] By Project to [QT] Prioritized on the wmde-wikidata-tech board.
gerritbot added a comment.Jan 9 2024, 3:31 PM

Change 989153 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Michael Große):

[mediawiki/extensions/Wikibase@REL1_40] Drop Storybook from tainted references

https://gerrit.wikimedia.org/r/989153

gerritbot added a project: Patch-For-Review.Jan 9 2024, 3:31 PM
gerritbot added a comment.Jan 9 2024, 3:56 PM

Change 989203 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Michael Große):

[mediawiki/extensions/Wikibase@REL1_40] Fix tainted references dependency conflicts

https://gerrit.wikimedia.org/r/989203

gerritbot added a comment.Jan 10 2024, 11:30 AM

Change 989203 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@REL1_40] Fix tainted references dependency conflicts

Reason:

squashed into I34baed7374

https://gerrit.wikimedia.org/r/989203

gerritbot added a comment.Jan 10 2024, 11:30 AM

Change 989153 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@REL1_40] Drop Storybook from tainted references

Reason:

squashed into I34baed7374

https://gerrit.wikimedia.org/r/989153

Maintenance_bot removed a project: Patch-For-Review.Jan 10 2024, 11:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits