Page MenuHomePhabricator

MobileDiff style error when diff engine is php
Closed, ResolvedPublicBUG REPORT


Steps to replicate the issue (include links if applicable):

  • Set up a MediaWiki instance with Minerva installed and wikidiff2 not installed. (This sets the diff engine to php.)
  • Compare changes using Special:MobileDiff.

What happens?:

The 2-column view breaks. Each column takes up 100% of screen width.

What should have happened instead?:

Each column should take up 50% of screen width, just as Special:Diff.

Software version (skip for WMF-hosted wikis like Wikipedia):

  • MediaWiki: 1.40.0
  • MobileFrontend: 2.4.1 (883f351)
  • Minerva: – (c79e708)
  • Diff engine: php

Other information (browser name/version, screenshots, etc.):

Weekly23w36a-MobileStyleDisaster_new.png (2×1 px, 242 KB)

The styles that cause this issue were added in T171726, which fixes table overflow issues when diff engine is wikidiff2. However, they accidentally affect the layout when the diff engine is php.

Event Timeline

Jdlrobson claimed this task.
Jdlrobson subscribed.

The Special:MobileDiff was removed in T358293. Please create a new ticket if you see a similar problem with the desktop diff page.