I'm quite sure that's https://we.phorge.it/source/phorge/browse/master/src/applications/metamta/engine/PhabricatorMailEmailEngine.php$246 (upstream code) if someone wants to cook up a merge request in Wikimedia Gitlab against phabricator/phabricator

My account in WM GitLab is suddenly blocked for some reason, although it has existed there for a while. In any case it looks like we're using the same code than upstream in that file. Where is PlatformSymbols::getPlatformServerName() configured for Maniphest? I can only find PlatformSymbols.php for Arcanist. Isn't that something that can be configured in the Phabricator's Config UI?

epicpupper opened https://gitlab.wikimedia.org/repos/phabricator/arcanist/-/merge_requests/1

Define Phabricator as platform server name instead of Phorge

In T345758#9169340, @Aklapper wrote:

In T345758#9147321, @MarcoAurelio wrote:

I can only find PlatformSymbols.php for Arcanist.

Ah, that's the way better place to patch, thanks! So amerge request in Wikimedia Gitlab should go against phabricator/arcanist instead

Thanks, although It's not clear to me why patching Arcanist would fix this, given that it is just a command line tool to interact with Phab...

@valerio.bozzolan Could you please advice? Do we need for fix this in other parts of the code as well?

I've +1 the merge request, thanks (I have not any privilege to "Accept" or anything)

In T345758#9174505, @MarcoAurelio wrote:

It's not clear to me why patching Arcanist would fix this, given that it is just a command line tool to interact with Phab...

Thanks for the question. Phab/Phorge do not require any other external dependency but Arcanist that provides fundamental classes like PhutilURI or PhutilCowsay in use by Phab/Phorge.

Thanks to some heavy work from Evan and also thanks to the Phorge community indeed, now the brand was centralized to a single place. In Phorge, that place is the static function call PlatformSymbols::getPlatformServerName(), provided by Arcanist and read also by Phorge.

So, Wikimedia Phab just needs to update their Arcanist to reflect their changes in their Phorge.

The role of Arcanist as a Phab/Phorge dipendency can be clarified looking at the installation instructions:

https://we.phorge.it/book/phorge/article/installation_guide/

On a side note, I'm sorry "we" (Phorge) had to change the default name, but Phabricator is a trademark and we didn't want to be bad people to the glorious Evan Priestley.

On another side note, there would also be a question of whether "we" (Wikimedia) are allowed to do so many forks (Phorks?) and still call it Phabricator.

I mean, Evan would probably say "yeah folks whatever" but I don't think anyone in Wikimedia has asked Evan such thing formally to Evan Priestley. Perhaps the legal team might be interested in writing such kind email.

Just to add more useful context:

https://we.phorge.it/source/arcanist/browse/master/src/platform/PlatformSymbols.php

brennen merged https://gitlab.wikimedia.org/repos/phabricator/arcanist/-/merge_requests/1

Define Phabricator as platform server name instead of Phorge

brennen merged https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/20

Phabricator release 2023-10-03