Page MenuHomePhabricator
Create Task
Maniphest T345793

Broken protect history link causing database errors for PostgreSQL backend
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • protect any page
  • visit Special:Log/protect or Special:RecentChanges
  • click a "hist" link of a protect log

What happens?:

A database error is reported:

Error 22008: ERROR: date/time field value out of range: "20230906122205"
LINE 1: ...r)) WHERE rev_page = 3495 AND (rev_timestamp >= '202309061...
^
HINT: Perhaps you need a different "datestyle" setting.

Function: IndexPager::buildQueryInfo (history page unfiltered)
Query: SELECT rev_id,rev_page,rev_timestamp,rev_minor_edit,rev_deleted,rev_len,rev_parent_id,rev_sha1,comment_rev_comment.comment_text AS "rev_comment_text",comment_rev_comment.comment_data AS "rev_comment_data",comment_rev_comment.comment_id AS "rev_comment_cid",actor_rev_user.actor_user AS "rev_user",actor_rev_user.actor_name AS "rev_user_text",rev_actor,user_name,(SELECT array_to_string(array_agg(ctd_name),',') FROM "change_tag" JOIN "change_tag_def" ON ((ct_tag_id=ctd_id)) WHERE ct_rev_id=rev_id ) AS "ts_tags" FROM "revision" JOIN "revision_comment_temp" "temp_rev_comment" ON ((temp_rev_comment.revcomment_rev = rev_id)) JOIN "comment" "comment_rev_comment" ON ((comment_rev_comment.comment_id = temp_rev_comment.revcomment_comment_id)) JOIN "actor" "actor_rev_user" ON ((actor_rev_user.actor_id = rev_actor)) LEFT JOIN "user" ON ((actor_rev_user.actor_user != 0) AND (user_id = actor_rev_user.actor_user)) WHERE rev_page = 3495 AND (rev_timestamp >= '20230906122205') ORDER BY rev_timestamp,rev_id LIMIT 1

Backtrace:

from /usr/share/webapps/mediawiki/includes/libs/rdbms/database/Database.php(1524)
#0 /usr/share/webapps/mediawiki/includes/libs/rdbms/database/Database.php(1508): Wikimedia\Rdbms\Database->getQueryException()
#1 /usr/share/webapps/mediawiki/includes/libs/rdbms/database/Database.php(1482): Wikimedia\Rdbms\Database->getQueryExceptionAndLog()
#2 /usr/share/webapps/mediawiki/includes/libs/rdbms/database/Database.php(855): Wikimedia\Rdbms\Database->reportQueryError()
#3 /usr/share/webapps/mediawiki/includes/libs/rdbms/database/Database.php(1629): Wikimedia\Rdbms\Database->query()
#4 /usr/share/webapps/mediawiki/includes/libs/rdbms/database/DBConnRef.php(119): Wikimedia\Rdbms\Database->select()
#5 /usr/share/webapps/mediawiki/includes/libs/rdbms/database/DBConnRef.php(344): Wikimedia\Rdbms\DBConnRef->__call()
#6 /usr/share/webapps/mediawiki/includes/pager/IndexPager.php(461): Wikimedia\Rdbms\DBConnRef->select()
#7 /usr/share/webapps/mediawiki/includes/pager/IndexPager.php(278): IndexPager->reallyDoQuery()
#8 /usr/share/webapps/mediawiki/includes/pager/IndexPager.php(737): IndexPager->doQuery()
#9 /usr/share/webapps/mediawiki/includes/actions/pagers/HistoryPager.php(630): IndexPager->getNumRows()
#10 /usr/share/webapps/mediawiki/includes/pager/ReverseChronologicalPager.php(168): HistoryPager->isNavigationBarShown()
#11 /usr/share/webapps/mediawiki/includes/actions/HistoryAction.php(321): ReverseChronologicalPager->getNavigationBar()
#12 /usr/share/webapps/mediawiki/includes/actions/FormlessAction.php(48): HistoryAction->onView()
#13 /usr/share/webapps/mediawiki/includes/MediaWiki.php(556): FormlessAction->show()
#14 /usr/share/webapps/mediawiki/includes/MediaWiki.php(333): MediaWiki->performAction()
#15 /usr/share/webapps/mediawiki/includes/MediaWiki.php(923): MediaWiki->performRequest()
#16 /usr/share/webapps/mediawiki/includes/MediaWiki.php(576): MediaWiki->main()
#17 /usr/share/webapps/mediawiki/index.php(50): MediaWiki->run()
#18 /usr/share/webapps/mediawiki/index.php(46): wfIndexMain()
#19 {main}

What should have happened instead?:

Software version (skip for WMF-hosted wikis like Wikipedia):
See https://wiki.archlinuxcn.org/wiki/Special:Version
Other information (browser name/version, screenshots, etc.):

In T352359, @tstarling wrote:

Note that a conventional 14-char timestamp is not a valid PG timestamp, so any client that constructs its own offset parameter, following normal MediaWiki conventions, will cause an exception in the server.
The simplest way to fix this would be to convert all the TIMESTAMPTZ fields to CHAR or VARCHAR for consistency with MySQL.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
pagers: Make history pager work with Postgresmediawiki/coremaster+22 -1
pagers: Make history pager work with Postgresmediawiki/coreREL1_45+22 -1
pagers: Make history pager work with Postgresmediawiki/coreREL1_44+22 -1
pagers: Make history pager work with Postgresmediawiki/coreREL1_43+22 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

lilydjwg created this task.Sep 7 2023, 4:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2023, 4:39 AM
lilydjwg updated the task description. (Show Details)Sep 7 2023, 4:40 AM
Dringsim updated the task description. (Show Details)Sep 7 2023, 4:43 AM
Aklapper added a project: MediaWiki-libs-Rdbms.Sep 7 2023, 11:25 AM
Ammarpad claimed this task.Sep 11 2023, 6:42 AM
Ammarpad subscribed.

Hope to find a reviewer for this.

Ammarpad mentioned this in T352359: PostgreSQL timestamp comparison throws exception with user input.Nov 30 2023, 9:06 AM
Ammarpad merged a task: T352359: PostgreSQL timestamp comparison throws exception with user input.
Ammarpad added subscribers: tstarling, Ladsgroup.
Ammarpad updated the task description. (Show Details)Nov 30 2023, 9:08 AM
Ladsgroup added a comment.Nov 30 2023, 12:05 PM

@Ammarpad Add me as reviewer, I'll take care of it.

Ammarpad added a comment.Dec 1 2023, 7:35 AM
In T345793#9370793, @Ladsgroup wrote:

@Ammarpad Add me as reviewer, I'll take care of it.

OK, thanks. Will do that

Krinkle moved this task from Untriaged to Rdbms: Non-MySQL support on the MediaWiki-libs-Rdbms board.Mar 26 2024, 7:28 PM
gerritbot added a comment.Nov 2 2025, 8:59 PM

Change #1200672 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] pagers: Make history pager work with Postgres

https://gerrit.wikimedia.org/r/1200672

gerritbot added a project: Patch-For-Review.Nov 2 2025, 8:59 PM
gerritbot added a comment.Nov 5 2025, 12:37 PM

Change #1200672 merged by jenkins-bot:

[mediawiki/core@master] pagers: Make history pager work with Postgres

https://gerrit.wikimedia.org/r/1200672

Ammarpad closed this task as Resolved.Nov 5 2025, 12:49 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.2; 2025-11-12).Nov 5 2025, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 5 2025, 1:31 PM
gerritbot added a comment.Nov 5 2025, 1:41 PM

Change #1202129 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@REL1_45] pagers: Make history pager work with Postgres

https://gerrit.wikimedia.org/r/1202129

gerritbot added a project: Patch-For-Review.Nov 5 2025, 1:41 PM

Change #1202130 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@REL1_44] pagers: Make history pager work with Postgres

https://gerrit.wikimedia.org/r/1202130

gerritbot added a comment.Nov 5 2025, 1:43 PM

Change #1202132 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@REL1_43] pagers: Make history pager work with Postgres

https://gerrit.wikimedia.org/r/1202132

gerritbot added a comment.Nov 5 2025, 2:12 PM

Change #1202132 abandoned by Ammarpad:

[mediawiki/core@REL1_43] pagers: Make history pager work with Postgres

Reason:

IndexPager::getOffset exists only in >= 1.45

https://gerrit.wikimedia.org/r/1202132

gerritbot added a comment.Nov 5 2025, 2:12 PM

Change #1202130 abandoned by Ammarpad:

[mediawiki/core@REL1_44] pagers: Make history pager work with Postgres

Reason:

IndexPager::getOffset exists only in >= 1.45

https://gerrit.wikimedia.org/r/1202130

gerritbot added a comment.Nov 5 2025, 2:32 PM

Change #1202129 merged by jenkins-bot:

[mediawiki/core@REL1_45] pagers: Make history pager work with Postgres

https://gerrit.wikimedia.org/r/1202129

ReleaseTaggerBot added a project: MW-1.45-notes.Nov 5 2025, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 5 2025, 3:31 PM
Aklapper added a comment.Nov 11 2025, 3:02 PM

This change created a regression in T409831 which currently blocks the deployment train.

Nardog subscribed.Nov 12 2025, 1:11 AM
Aklapper reopened this task as Open.EditedNov 12 2025, 10:39 AM

Reverted https://gerrit.wikimedia.org/r/q/aaf418b3c8ac1990308cd149b8f6485740c496f6 via https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1204258 in the wmf.2 branch only by Ladsgroup, thus resolving T409831, reopening T345793, and marking T345793 as a wmf.3 blocker.

The proposed followup patch to https://gerrit.wikimedia.org/r/q/aaf418b3c8ac1990308cd149b8f6485740c496f6 is https://gerrit.wikimedia.org/r/c/1203855

Aklapper added a parent task: T408273: 1.46.0-wmf.3 deployment blockers.Nov 12 2025, 10:39 AM
Aklapper mentioned this in T409831: Previous link in page history is broken.
A_smart_kitten added a project: MW-1.45-release.Nov 12 2025, 11:01 AM
A_smart_kitten subscribed.
Novem_Linguae subscribed.Nov 12 2025, 2:39 PM
A_smart_kitten added a comment.Nov 16 2025, 4:36 PM

https://gerrit.wikimedia.org/r/c/1203855 has been merged (which I assume should hopefully remove the train-blocker for -wmf.3). To confirm, should that patch be backported to REL1_45?

ABreault-WMF subscribed.Nov 18 2025, 5:26 PM
In T345793#11377298, @A_smart_kitten wrote:

https://gerrit.wikimedia.org/r/c/1203855 has been merged (which I assume should hopefully remove the train-blocker for -wmf.3). To confirm, should that patch be backported to REL1_45?

Done in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1206918

A_smart_kitten closed this task as Resolved.Nov 18 2025, 6:20 PM
A_smart_kitten added a subscriber: Atieno.

Brilliant, thanks @Atieno & @ABreault-WMF :)
I believe that's now everything that's left to do on this ticket; so boldly re-resolving.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits