Error
- service.version: 1.41.0-wmf.25
- trace.id: 97aa67c7-817c-4fa9-bda2-8924bf59d87f
- Find trace.id in Logstash
[{reqId}] {exception_url} TypeError: Argument 1 passed to RevisionReviewForm::setTag() must be of the type int, null given, called in /srv/mediawiki/php-1.41.0-wmf.25/extensions/FlaggedRevs/frontend/specialpages/actions/RevisionReview.php on line 287
from /srv/mediawiki/php-1.41.0-wmf.25/extensions/FlaggedRevs/business/RevisionReviewForm.php(152) #0 /srv/mediawiki/php-1.41.0-wmf.25/extensions/FlaggedRevs/frontend/specialpages/actions/RevisionReview.php(287): RevisionReviewForm->setTag(NULL) #1 /srv/mediawiki/php-1.41.0-wmf.25/extensions/FlaggedRevs/rest/ReviewHandler.php(25): RevisionReview::doReview(array) #2 /srv/mediawiki/php-1.41.0-wmf.25/includes/Rest/SimpleHandler.php(38): MediaWiki\Extension\FlaggedRevs\Rest\ReviewHandler->run(string) #3 /srv/mediawiki/php-1.41.0-wmf.25/includes/Rest/Router.php(517): MediaWiki\Rest\SimpleHandler->execute() #4 /srv/mediawiki/php-1.41.0-wmf.25/includes/Rest/Router.php(422): MediaWiki\Rest\Router->executeHandler(MediaWiki\Extension\FlaggedRevs\Rest\ReviewHandler) #5 /srv/mediawiki/php-1.41.0-wmf.25/includes/Rest/EntryPoint.php(195): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals) #6 /srv/mediawiki/php-1.41.0-wmf.25/includes/Rest/EntryPoint.php(135): MediaWiki\Rest\EntryPoint->execute() #7 /srv/mediawiki/php-1.41.0-wmf.25/rest.php(31): MediaWiki\Rest\EntryPoint::main() #8 /srv/mediawiki/w/rest.php(3): require(string) #9 {main}
Impact
FlaggedRevs is probably broken as a result, I rolled back 1.41.0-wmf.25 from group 2 wikis.
Notes
Several occurences happened immediately after promoting all wikis to 1.41.0-wmf.25