Page MenuHomePhabricator
Create Task
Maniphest T345873

AbuseFilter selenium tests on REL1_39 are broken
Closed, ResolvedPublic
Actions

Description

When attempting to approve a cherry-picked commit to REL1_39 on CheckUser, the AbuseFilter selenium tests fail with:

17:58:12 node: ../src/coroutine.cc:134: void* find_thread_id_key(void*): Assertion `thread_id_key != 0x7777' failed.
17:58:12 Aborted

Example of this at https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php74-selenium-docker/8709/console.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Drop storybook code for REL1_40, broken and never publishedJforrestermediawiki/extensions/MobileFrontendREL1_40+26 -15 K
selenium: Delete all testsJforrestermediawiki/extensions/MobileFrontendREL1_40+3 -0
tests: Drop all Selenium testing from REL1_39Jforrestermediawiki/skins/MinervaNeueREL1_39+11 -39 K
Disable failing "data is retained if saving fails" selenium testDreamy Jazzmediawiki/extensions/AbuseFilterREL1_39+1 -1
selenium: Refactor WebdriverIO tests from sync to async modeJforrestermediawiki/extensions/AbuseFilterREL1_39+2 K -1 K
selenium: Delete all testsJforrestermediawiki/extensions/MobileFrontendREL1_39+2 -3 K
selenium: Refactor WebdriverIO tests from sync to async modeJforrestermediawiki/extensions/CiteREL1_39+3 K -3 K
Customize query in gerrit

Related Objects

Event Timeline

Dreamy_Jazz created this task.Sep 7 2023, 5:05 PM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptSep 7 2023, 5:05 PM
Dreamy_Jazz added a project: MW-1.39-release.Sep 7 2023, 5:05 PM
Dreamy_Jazz added a comment.Sep 7 2023, 5:08 PM

Related is T344865. Not sure this is directly a duplicate though.

Jdforrester-WMF subscribed.Sep 7 2023, 5:08 PM

Yeah, you'll need to back-port all the sync->async patches to REL1_39, or disable them.

Dreamy_Jazz mentioned this in T344865: CI for MobileFrontend broken on REL1_39/REL1_40.Sep 7 2023, 5:08 PM
Dreamy_Jazz added a project: Browser-Tests.Sep 7 2023, 5:11 PM
Dreamy_Jazz moved this task from Blocker to Not a blocker on the MW-1.39-release board.
gerritbot added a comment.Sep 7 2023, 5:13 PM

Change 955790 had a related patch set uploaded (by Jforrester; author: Pwangai):

[mediawiki/extensions/AbuseFilter@REL1_39] selenium: Refactor WebdriverIO tests from sync to async mode

https://gerrit.wikimedia.org/r/955790

gerritbot added a project: Patch-For-Review.Sep 7 2023, 5:13 PM
gerritbot added a comment.Sep 7 2023, 5:25 PM

Change 955817 had a related patch set uploaded (by Jforrester; author: Pwangai):

[mediawiki/extensions/Cite@REL1_39] selenium: Refactor WebdriverIO tests from sync to async mode

https://gerrit.wikimedia.org/r/955817

gerritbot added a comment.Sep 7 2023, 5:34 PM

Change 952002 had a related patch set uploaded (by Jforrester; author: Zfilipin):

[mediawiki/extensions/MobileFrontend@REL1_39] selenium: Delete all tests

https://gerrit.wikimedia.org/r/952002

gerritbot added a comment.Sep 7 2023, 5:50 PM

Change 955822 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/skins/MinervaNeue@REL1_39] tests: Drop all Selenium testing from REL1_39

https://gerrit.wikimedia.org/r/955822

gerritbot added a comment.Sep 7 2023, 6:16 PM

Change 955817 merged by jenkins-bot:

[mediawiki/extensions/Cite@REL1_39] selenium: Refactor WebdriverIO tests from sync to async mode

https://gerrit.wikimedia.org/r/955817

gerritbot added a comment.Sep 8 2023, 7:25 AM

Change 952002 merged by Jforrester:

[mediawiki/extensions/MobileFrontend@REL1_39] selenium: Delete all tests

https://gerrit.wikimedia.org/r/952002

gerritbot added a comment.Sep 8 2023, 7:25 AM

Change 955790 merged by Jforrester:

[mediawiki/extensions/AbuseFilter@REL1_39] selenium: Refactor WebdriverIO tests from sync to async mode

https://gerrit.wikimedia.org/r/955790

gerritbot added a comment.Sep 8 2023, 7:37 AM

Change 955822 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@REL1_39] tests: Drop all Selenium testing from REL1_39

https://gerrit.wikimedia.org/r/955822

Maintenance_bot removed a project: Patch-For-Review.Sep 8 2023, 8:10 AM
Reedy mentioned this in T345500: Preventing browser tests breaking in REL1_XX every time we upgrade node.Sep 8 2023, 9:24 AM
gerritbot added a comment.Sep 8 2023, 10:03 AM

Change 955892 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/AbuseFilter@REL1_39] Disable failing "data is retained if saving fails" selenium test

https://gerrit.wikimedia.org/r/955892

gerritbot added a project: Patch-For-Review.Sep 8 2023, 10:03 AM
gerritbot added a comment.Sep 8 2023, 12:18 PM

Change 955892 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@REL1_39] Disable failing "data is retained if saving fails" selenium test

https://gerrit.wikimedia.org/r/955892

Jdforrester-WMF closed this task as Resolved.Sep 8 2023, 12:28 PM
Jdforrester-WMF claimed this task.
Maintenance_bot removed a project: Patch-For-Review.Sep 8 2023, 12:30 PM
gerritbot added a comment.Sep 8 2023, 12:31 PM

Change 955803 had a related patch set uploaded (by Jforrester; author: Zfilipin):

[mediawiki/extensions/MobileFrontend@REL1_40] selenium: Delete all tests

https://gerrit.wikimedia.org/r/955803

gerritbot added a project: Patch-For-Review.Sep 8 2023, 12:31 PM

Change 955803 abandoned by Jforrester:

[mediawiki/extensions/MobileFrontend@REL1_40] selenium: Delete all tests

Reason:

https://gerrit.wikimedia.org/r/955803

Dreamy_Jazz added a comment.Sep 8 2023, 12:35 PM

Thanks for fixing the selenium tests. Much appreciated.

gerritbot added a comment.Sep 8 2023, 12:42 PM

Change 955925 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/MobileFrontend@REL1_40] Drop storybook code for REL1_40, broken and never published

https://gerrit.wikimedia.org/r/955925

gerritbot added a comment.Sep 8 2023, 12:52 PM

Change 955925 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@REL1_40] Drop storybook code for REL1_40, broken and never published

https://gerrit.wikimedia.org/r/955925

Maintenance_bot removed a project: Patch-For-Review.Sep 8 2023, 1:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits