Page MenuHomePhabricator
Create Task
Maniphest T346030

Move to WDIO v8 for tests
Closed, ResolvedPublic
Actions

Description

Move WDIO version to above 8

  • Currently requires a compatible wdio-wikibase version.
  • needs ESM imports
  • All test cases should still run

Note: no official upgrade guide on the webpage.

Related Objects
Search...

Event Timeline

lojo_wmde created this task.Sep 11 2023, 10:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 11 2023, 10:34 AM
lojo_wmde added a subtask: T346025: Talk to PRPL about wdio-wikibase.Sep 11 2023, 10:35 AM
lojo_wmde added a subtask: T346029: Convert WDIO specs to ESM style imports.
lojo_wmde moved this task from Inbox to Focus: Improve our tooling for CI/CD on the Wikibase Suite Team board.
• roti_WMDE moved this task from Focus: Improve our tooling for CI/CD to Prioritised + Unrefined on the Wikibase Suite Team board.Sep 12 2023, 9:48 AM
darthmon_wmde changed the status of subtask T346025: Talk to PRPL about wdio-wikibase from Open to In Progress.Sep 13 2023, 12:24 PM
• roti_WMDE updated the task description. (Show Details)Sep 18 2023, 11:32 AM
• roti_WMDE moved this task from Prioritised + Unrefined to Sprint-∞ on the Wikibase Suite Team board.Sep 18 2023, 11:35 AM
• roti_WMDE edited projects, added Wikibase Suite Team (Sprint-∞); removed Wikibase Suite Team.
• roti_WMDE mentioned this in T345368: Consider moving more of our test setup into WDIO and out of shell scripts.Sep 18 2023, 11:49 AM
RickiJay-WMDE moved this task from Sprint Backlog to Doing on the Wikibase Suite Team (Sprint-∞) board.Sep 21 2023, 11:12 AM
RickiJay-WMDE claimed this task.Sep 22 2023, 7:56 AM
RickiJay-WMDE changed the task status from Open to In Progress.Sep 22 2023, 7:58 AM

Should we estimate this or may I?

RickiJay-WMDE updated the task description. (Show Details)Sep 22 2023, 8:05 AM
RickiJay-WMDE updated the task description. (Show Details)
RickiJay-WMDE added a comment.EditedSep 22 2023, 8:09 AM

IMPLEMENTATION NOTES

  • browser.config is replaced by browser.options, which largely does not allow for the use of custom fields. Environment variables are used where necessary.
  • wdio.conf.js moved to test directory
  • Patched wdio-mediawiki code:
    • test/helpers/WDIOMediawikiPagePatch.js patched wdio-mediawiki/Page
    • test/helpers/WDIOMediawikiScreenshotPatch.js patched screenshot-related functions in wdio-mediawiki/index.js

CORRECTIONS

  • ES Module imports not needed for 8; vice versa.
  • Was able to patch wdio-wikibase/WikibaseApi. See test/helpers/WikibaseApiPatch.js.

FOLOS NEEDED

  • Update wdio-mediawiki to v8, including the code correction specified above
  • Update wdio-wikibase to v8, including the code correction specified above
  • Move code to Typescript, which probably would have clued me into the options field errors a day earlier
RickiJay-WMDE mentioned this in T346623: Make WDIO wikibase work with WDIO 8.Sep 22 2023, 8:18 AM
RickiJay-WMDE mentioned this in T347137: Update wdio-mediawiki to work with both WebdriverIO v7 and v8.Sep 22 2023, 8:28 AM
RickiJay-WMDE added a subtask: T347137: Update wdio-mediawiki to work with both WebdriverIO v7 and v8.
darthmon_wmde changed the status of subtask T346029: Convert WDIO specs to ESM style imports from Open to In Progress.Sep 22 2023, 2:20 PM
RickiJay-WMDE moved this task from Doing to In Review on the Wikibase Suite Team (Sprint-∞) board.Sep 26 2023, 9:36 AM

Pull Request:
https://github.com/wmde/wikibase-release-pipeline/pull/474

adee_wmde closed subtask T346025: Talk to PRPL about wdio-wikibase as Resolved.Sep 26 2023, 9:45 AM
• roti_WMDE closed this task as Resolved.Sep 26 2023, 2:50 PM
• roti_WMDE moved this task from In Review to Done on the Wikibase Suite Team (Sprint-∞) board.
• roti_WMDE closed subtask T346029: Convert WDIO specs to ESM style imports as Resolved.Oct 10 2023, 9:17 AM
• roti_WMDE moved this task from Sprint-∞ to Archive (closed) on the Wikibase Suite Team board.Oct 10 2023, 9:47 AM
• roti_WMDE edited projects, added Wikibase Suite Team; removed Wikibase Suite Team (Sprint-∞).
RickiJay-WMDE changed the status of subtask T346623: Make WDIO wikibase work with WDIO 8 from Open to In Progress.Oct 17 2023, 2:16 PM
darthmon_wmde changed the status of subtask T347137: Update wdio-mediawiki to work with both WebdriverIO v7 and v8 from Open to In Progress.Oct 19 2023, 3:22 PM
RickiJay-WMDE closed subtask T346623: Make WDIO wikibase work with WDIO 8 as Resolved.Oct 30 2023, 2:58 PM
RickiJay-WMDE changed the status of subtask T347138: Update Code after patching WDIO-Mediawiki and WDIO-Wikibase from Open to In Progress.Oct 30 2023, 4:22 PM
zeljkofilipin closed subtask T347137: Update wdio-mediawiki to work with both WebdriverIO v7 and v8 as Resolved.Nov 16 2023, 5:44 PM
RickiJay-WMDE closed subtask T347138: Update Code after patching WDIO-Mediawiki and WDIO-Wikibase as Resolved.Nov 17 2023, 12:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits