Remove CheckUserUnionQueryBuilder
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

After investigation in T328997: Enable read new support in Special:CheckUser's 'Get users' mode it has been determined that using UNION queries is too expensive and three separate queries would be better for performance when a large number of results are selected.

Acceptance criteria

Remove the CheckUserUnionQueryBuilder and related code that is only used by the query builder

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove CheckUserUnionSelectQueryBuilder and associated methods	mediawiki/extensions/CheckUser	master	+0 -2 K
	Remove CheckUserUnionSelectQueryBuilderFactory from SpecialCheckUser	mediawiki/extensions/CheckUser	master	+5 -29

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Subtype	Assigned	Task
			· · ·
Resolved	Feature	• Dreamy_Jazz	T324907 Create separate tables for log events in CheckUser
Resolved		• Dreamy_Jazz	T337159 Make PHPUnit dataProvider static in CheckUser tests
Resolved		• Dreamy_Jazz	T346044 Remove CheckUserUnionQueryBuilder
			· · ·

Event Timeline

• Dreamy_Jazz created this task.Sep 11 2023, 2:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 11 2023, 2:45 PM

• Dreamy_Jazz claimed this task.Sep 11 2023, 2:47 PM

• Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (AHaT Sprint 32 - Baseball Cap) board.

• Dreamy_Jazz edited projects, added Anti-Harassment-Team; removed Anti-Harassment-Team (AHaT Sprint 32 - Baseball Cap).Sep 11 2023, 2:49 PM

• Dreamy_Jazz added a parent task: T324907: Create separate tables for log events in CheckUser.

• Dreamy_Jazz added a parent task: T337159: Make PHPUnit dataProvider static in CheckUser tests.Sep 12 2023, 1:14 PM

• Dreamy_Jazz mentioned this in T337159: Make PHPUnit dataProvider static in CheckUser tests.

Change 959253 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove CheckUserUnionSelectQueryBuilderFactory from SpecialCheckUser

https://gerrit.wikimedia.org/r/959253

gerritbot added a project: Patch-For-Review.Sep 21 2023, 5:38 PM

dom_walden mentioned this in T328995: Enable read new support in Special:CheckUser's 'Get edits' mode.Sep 28 2023, 2:25 PM

Change 959253 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove CheckUserUnionSelectQueryBuilderFactory from SpecialCheckUser

https://gerrit.wikimedia.org/r/959253

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 17 2023, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 17 2023, 12:10 PM

Change 975263 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove CheckUserUnionSelectQueryBuilder and associated methods

https://gerrit.wikimedia.org/r/975263

gerritbot added a project: Patch-For-Review.Nov 17 2023, 1:06 PM

• Dreamy_Jazz edited projects, added Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)); removed Anti-Harassment-Team.Nov 17 2023, 1:08 PM

• Dreamy_Jazz set the point value for this task to 1.Nov 20 2023, 4:21 PM

• Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)) board.

Tchanders moved this task from Needs review to Done on the Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)) board.Nov 27 2023, 4:06 PM

Change 975263 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove CheckUserUnionSelectQueryBuilder and associated methods

https://gerrit.wikimedia.org/r/975263

Maintenance_bot removed a project: Patch-For-Review.Nov 27 2023, 5:30 PM

• Dreamy_Jazz closed this task as Resolved.Nov 27 2023, 5:31 PM

Remove CheckUserUnionQueryBuilderClosed, ResolvedPublic1 Estimated Story PointsActions