Remove CheckUserUnionQueryBuilder
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

After investigation in T328997: Enable read new support in Special:CheckUser's 'Get users' mode it has been determined that using UNION queries is too expensive and three separate queries would be better for performance when a large number of results are selected.

Acceptance criteria

Remove the CheckUserUnionQueryBuilder and related code that is only used by the query builder

Details

	Subject	Repo	Branch	Lines +/-
	Remove CheckUserUnionSelectQueryBuilder and associated methods	mediawiki/extensions/CheckUser	master	+0 -2 K
	Remove CheckUserUnionSelectQueryBuilderFactory from SpecialCheckUser	mediawiki/extensions/CheckUser	master	+5 -29

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
			Restricted Task
			Restricted Task
Stalled		None	T255792 Quibble runs core:unit tests twice!
Open		None	T328919 Upgrade to PHPUnit 10
			Restricted Task
Resolved	Security	Zabe	T311337 CVE-2022-39193: Edits with the performer suppressed still show the performer in results from the CheckUser extension
Resolved	Security	Dreamy_Jazz	T316414 CVE-2022-39193: Special:Investigate can expose supressed information in check results
Resolved	Security	Dreamy_Jazz	T318166 CVE-2022-39193: CheckUser API can expose the suppressed performer
Resolved	Security	Dreamy_Jazz	T316360 Oversighted action text is shown in Special:CheckUser when the checkuser does not have the right to see it
			Restricted Task
Open	BUG REPORT	None	T326866 Special:Investigate can expose suppressed information for log events
Open	BUG REPORT	None	T326867 CheckUser API can expose suppressed information for log events
Open	BUG REPORT	None	T326865 Special:CheckUser can expose suppressed information for log events
Open		Dreamy_Jazz	T253796 Make CheckUser record the log_id of logged actions
Open		None	T139810 RFC: Overhaul the CheckUser extension
Open		None	T132892 CheckUser UI revamp
Open		None	T69811 CheckUsers "Get users" design needs improvements
Open	Feature	Dreamy_Jazz	T24120 Enhance Blocking and tagging from checkuser interface: add dropdowns
Duplicate		None	T145340 Split CheckUser mass-block interface to separate special page
Open	Feature	None	T318458 Add dropdown options for the reason in Special:InvestigateBlock (like Special:Block has)
Open	Feature	None	T319517 Allow the OOUI selectandother field to have the required status indicate that either the dropdown or the input box could be used
Open	Feature	None	T324709 Allow the HTMLForm Select and other field to have a minimum length set
Resolved	Feature	Dreamy_Jazz	T316441 Enforce minimum length of the tag on the client side for the checkuser block form
Resolved	Feature	Dreamy_Jazz	T321427 Allow HTMLForm text based elements to specify a minimum length
Resolved	Feature	Dreamy_Jazz	T321439 Allow TextInputWidget to specify the "minlength" attribute
Open	Feature	None	T316444 The CheckUser block form should explain why users were not blocked or tagged
Open	Feature	None	T314700 Restore the bottom paging links on 'Get users'
Resolved	BUG REPORT	Dreamy_Jazz	T314217 Checkuserblock form is broken when paging links are shown on 'Get users'
Open	Feature	None	T313451 Separate out when the blocks are made for IPs and users in Special:CheckUser 'get users' mode
Open	Feature	None	T18306 Allow user to specify block settings from CU form
Resolved		Glaisher	T41213 Block interface after "Get users" check should allow talk page/send email blocking
Open		None	T27053 Replace user / talk pages feature of "Get users" creates a user/talk page if it doesnt exist
Open	Feature	None	T318459 Make a clearer visual distinction between the UA and IP list in 'get users'
Resolved		Glaisher	T49505 CheckUser results (userlinks) cannot be customized
Resolved		Niharika	T24119 Enhance Blocking and tagging from checkuser interface: add new page
Resolved		None	T14808 Blocking and tagging from checkuser interface
Resolved	Feature	Dreamy_Jazz	T16699 More versatile searching in CheckUser log
Declined		None	T15789 Restore the global CheckUser log
Resolved	Feature	Dreamy_Jazz	T309924 Add check links for both the target and performer in Special:CheckUserLog
Resolved	Feature	Dreamy_Jazz	T309925 Implement User:Amalthea/culoghelper.js into the CheckUser extension
Duplicate		None	T140345 Userlinks in CheckUser should be customizable
Open		None	T21964 Provide a link to the user on account creation
Duplicate		None	T144099 Make CheckUser unit-testable
Resolved		Dreamy_Jazz	T309815 Use OOUI in Special:CheckUser
Resolved		Dreamy_Jazz	T310019 The Special:CheckUser block form should use OOUI
Resolved		Dreamy_Jazz	T266586 Use OOUI in SpecialCheckUserLog
			Restricted Task
Open	Feature	None	T26231 Allow CheckUsers to filter checks for account creations only
Resolved		Dreamy_Jazz	T139809 Bad output of AbuseFilter blocks in CU get edits
Open	BUG REPORT	None	T41013 Incomplete i18n for log entries in CheckUser
Resolved	BUG REPORT	Dreamy_Jazz	T268156 Partial blocks from namespaces are displayed odd
Open		None	T311354 Make CheckUser results easier to parse by userscripts
Open	Feature	None	T311380 Make certain types of edits in 'Get edits' highlightable for ease of parsing the results
Declined	Feature	None	T54849 Checkuser option "get users" should point out when user password is changed
Open	Feature	None	T315488 Show failed login attempts in the results list for the user
			Restricted Task
Open		Dreamy_Jazz	T145265 Store check user data action text in structured format
In Progress		kostajh	T257893 [EPIC] Support User-Agent Client Hints header in CheckUser
Open		None	T341094 Create client hint mapping rows for CheckUser-worthy events
Open		None	T248926 Performance review of checkuser database queries [NOT READY]
Open		None	T342613 CompareService::getTotalEditsFromIp queries exceeding TransactionProfiler limits
Open		None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
Open		None	T332865 PHPUnit data providers should be simple static functions that return plain data
Resolved		Dreamy_Jazz	T337159 Make PHPUnit dataProvider static in CheckUser tests
Open		None	T301992 Insert CheckUser row events during certain 2FA actions
Open		Tchanders	T326393 IP Address Reveal on Log page
Open	Feature	Dreamy_Jazz	T324907 Create separate tables for log events in CheckUser
Resolved		Dreamy_Jazz	T346044 Remove CheckUserUnionQueryBuilder

Event Timeline

Dreamy_Jazz created this task.Sep 11 2023, 2:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 11 2023, 2:45 PM

Dreamy_Jazz claimed this task.Sep 11 2023, 2:47 PM

Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

Dreamy_Jazz edited projects, added Anti-Harassment; removed Anti-Harassment (AHaT Sprint 32 - Baseball Cap).Sep 11 2023, 2:49 PM

Dreamy_Jazz added a parent task: T324907: Create separate tables for log events in CheckUser.

Dreamy_Jazz added a parent task: T337159: Make PHPUnit dataProvider static in CheckUser tests.Sep 12 2023, 1:14 PM

Dreamy_Jazz mentioned this in T337159: Make PHPUnit dataProvider static in CheckUser tests.

Change 959253 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove CheckUserUnionSelectQueryBuilderFactory from SpecialCheckUser

https://gerrit.wikimedia.org/r/959253

gerritbot added a project: Patch-For-Review.Sep 21 2023, 5:38 PM

dom_walden mentioned this in T328995: Enable read new support in Special:CheckUser's 'Get edits' mode.Sep 28 2023, 2:25 PM

Change 959253 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove CheckUserUnionSelectQueryBuilderFactory from SpecialCheckUser

https://gerrit.wikimedia.org/r/959253

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Fri, Nov 17, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Fri, Nov 17, 12:10 PM

Change 975263 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove CheckUserUnionSelectQueryBuilder and associated methods

https://gerrit.wikimedia.org/r/975263

gerritbot added a project: Patch-For-Review.Fri, Nov 17, 1:06 PM

Dreamy_Jazz edited projects, added Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Shamisen); removed Anti-Harassment.Fri, Nov 17, 1:08 PM

Dreamy_Jazz set the point value for this task to 1.Mon, Nov 20, 4:21 PM

Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Shamisen) board.

Tchanders moved this task from Needs review to Done on the Trust and Safety Product Sprint (Sprint Shamisen) board.Mon, Nov 27, 4:06 PM

Change 975263 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove CheckUserUnionSelectQueryBuilder and associated methods

https://gerrit.wikimedia.org/r/975263

Maintenance_bot removed a project: Patch-For-Review.Mon, Nov 27, 5:30 PM

Dreamy_Jazz closed this task as Resolved.Mon, Nov 27, 5:31 PM

Remove CheckUserUnionQueryBuilderClosed, ResolvedPublic1 Estimated Story PointsActions