Page MenuHomePhabricator
Create Task
Maniphest T346404

When reference previews is a beta feature the settings cog does not display for logged in users
Closed, DeclinedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • I'm also seeing 1,513,425 errors in last 7 days for "Page previews: No settings button found in preview." in logstash which supported the reality that the settings cog is no longer visible.
  • Hover over any reference on any page e.g [1]

What happens?:

  • On German Wikipedia, hovering over a reference shows a functional setting icon for logged out and logged in users
  • On English Wikipedia where the feature is still a beta feature, hovering over a reference shows a functional setting icon for logged out and logged in users

What should have happened instead?:

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Always show preview settings iconmediawiki/extensions/Popupsmaster+17 -33
Disable error logging for missing settings cog on references beta featuremediawiki/extensions/Popupsmaster+10 -4
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Sep 14 2023, 10:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2023, 10:01 PM
Jdlrobson mentioned this in T345829: Regression: Setting icon in ReferencePreview popups does nothing.Sep 14 2023, 10:02 PM
gerritbot added a comment.Sep 14 2023, 10:13 PM

Change 957832 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Always show preview settings icon

https://gerrit.wikimedia.org/r/957832

gerritbot added a project: Patch-For-Review.Sep 14 2023, 10:13 PM
Jdlrobson added a subscriber: thiemowmde.Sep 14 2023, 10:17 PM

@thiemowmde do you recall if this is intentional? Presumably the settings cog is not hidden because it doesn't link to the right pane on Special:Preferences (which my patch fixes)?

Jdlrobson renamed this task from When reference previews is a beta feature the settings cog does not display for logged in uers to When reference previews is a beta feature the settings cog does not display for logged in users.Sep 14 2023, 10:22 PM
thiemowmde added subscribers: Lena_WMDE, ECohen_WMDE.Sep 15 2023, 6:56 AM

Yes, this is an intentional product decision. Mentioned in T234205, T277639 and T276200.

Please don't quote me, but as far as I remember the idea is that a) these users actively opted-in, so they shouldn't be surprised to see these popups, as well as remember how to disable them. And b) it would need even more extra code to make it work when the checkbox is somewhere else. I hope that helps.

This special case will disappear together will all Beta feature code the moment we properly deployed the feature to all wikis. The relevant umbrella ticket is T282999. We are in the process of figuring out how to prioritize this.

ovasileva triaged this task as Medium priority.Sep 15 2023, 2:19 PM
Jdlrobson added a comment.Sep 15 2023, 4:15 PM

Okay if this is intentional we should disable the error logging given the volume. I'll post a patch today.

gerritbot added a comment.Sep 15 2023, 4:49 PM

Change 957961 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Disable error logging for missing settings cog on references beta feature

https://gerrit.wikimedia.org/r/957961

bwang moved this task from Incoming to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 15 2023, 6:08 PM
gerritbot added a comment.Sep 15 2023, 6:50 PM

Change 957961 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Disable error logging for missing settings cog on references beta feature

https://gerrit.wikimedia.org/r/957961

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.27; 2023-09-19).Sep 15 2023, 7:00 PM
gerritbot added a comment.Sep 15 2023, 7:00 PM

Change 957832 abandoned by Jdlrobson:

[mediawiki/extensions/Popups@master] Always show preview settings icon

Reason:

Abandoning this for now. Will leave this with WMDE in case they want to do a follow up.

https://gerrit.wikimedia.org/r/957832

Jdlrobson removed projects: Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6), Wikimedia-production-error.Sep 15 2023, 7:01 PM

Untagging web team since production error has been taken care of. WMDE should feel free to decline this ticket or talk more about the alternative solution in https://gerrit.wikimedia.org/r/957832

Maintenance_bot removed a project: Patch-For-Review.Sep 15 2023, 7:10 PM
thiemowmde closed this task as Declined.Sep 15 2023, 7:16 PM

Ok, thanks! We will automatically discuss this as part of T282999 or just remove the special case code together with all BetaFeatures code, so I think a separate ticket is not needed at the moment.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL