Page MenuHomePhabricator

Update FlaggedRevs to use the new HookContainer/HookRunner system
Open, Needs TriagePublic

Description

Implement the Hook system added in MediaWiki 1.35 in the extensions, see Hooks.md for documentation.

  • Use hook handlers for core hooks
  • Use hook handlers for Echo hooks (T315938)
  • Use hook handlers for UserMerge hooks
  • Use hook handlers for GoogleNewsSitemap hooks (T338446)
  • Use hook handlers for Scribunto hooks (T271026)

Event Timeline

Change 960212 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FlaggedRevs@master] Combine HookHandlers in same class into one handler

https://gerrit.wikimedia.org/r/960212

Change 960212 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Combine HookHandlers in same class into one handler

https://gerrit.wikimedia.org/r/960212

Change 970779 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FlaggedRevs@master] Use HookHandlers for Scribunto hook

https://gerrit.wikimedia.org/r/970779

  • Use hook handlers for Echo hooks (T315938)

Only one Echo hook is handled, and the hook handler’s documentation comment notes that it should be removed once T153570 is resolved. That task hasn’t seen much activity in the past three years, but I don’t think it makes much sense to migrate the to-be-removed code to a new system.

Change 970779 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Use HookHandlers for Scribunto hook

https://gerrit.wikimedia.org/r/970779