Page MenuHomePhabricator

[QB] [TECH] Ensure deployments to Query Builder succeed even after a Dependabot update
Open, Needs TriagePublic

Description

Currently, wikidata-query-builder-build doesn’t work when latest commit is by Dependabot. The commit-msg hook adds the Change-Id keyy for Gerrit in wrong place. See the following error message from build #34:

Error message from build #34
00:15:35 remote: ERROR: commit 5e65550: Change-Id must be in message footer
00:15:35 remote: 
00:15:35 remote: Hint: run
00:15:35 remote:   git commit --amend
00:15:35 remote: and move 'Change-Id: Ixxx..' to the bottom on a separate line
00:15:35 remote: 
00:15:35 To ssh://gerrit.wikimedia.org:29418/wikidata/query-builder/deploy
00:15:35  ! [remote rejected] HEAD -> refs/for/production%ready (commit 5e65550: Change-Id must be in message footer)
00:15:35 error: failed to push some refs to 'ssh://gerrit.wikimedia.org:29418/wikidata/query-builder/deploy'
00:15:35 Build step 'Execute shell' marked build as failure

Notes:

Acceprtance Criteria:

  • Deployments can be made even if the last commit is a Dependabot change.

Event Timeline

ItamarWMDE renamed this task from wikidata-query-builder-build doesn’t work when latest commit is by dependabot (commit-msg hook adds Change-Id in wrong place) to [QB] wikidata-query-builder-build doesn’t work when latest commit is by dependabot (commit-msg hook adds Change-Id in wrong place).Sep 28 2023, 11:58 AM
ItamarWMDE renamed this task from [QB] wikidata-query-builder-build doesn’t work when latest commit is by dependabot (commit-msg hook adds Change-Id in wrong place) to [QB] [TECH] wikidata-query-builder-build doesn’t work when latest commit is by dependabot (commit-msg hook adds Change-Id in wrong place).
ItamarWMDE moved this task from Incoming to [QT] By Project on the wmde-wikidata-tech board.

Task Prio Notes:

  • Does not affect end users /production
  • Does not affect monitoring
  • Affects development efforts
  • Does not affect onboarding efforts
  • Does not affect additional stakeholders
ItamarWMDE renamed this task from [QB] [TECH] wikidata-query-builder-build doesn’t work when latest commit is by dependabot (commit-msg hook adds Change-Id in wrong place) to [SW] [QB] [TECH] wikidata-query-builder-build doesn’t work when latest commit is by dependabot (commit-msg hook adds Change-Id in wrong place).Oct 24 2023, 1:19 PM
ItamarWMDE moved this task from [QT] By Project to [QT] Prioritized on the wmde-wikidata-tech board.
ItamarWMDE renamed this task from [SW] [QB] [TECH] wikidata-query-builder-build doesn’t work when latest commit is by dependabot (commit-msg hook adds Change-Id in wrong place) to [SW] [QB] [TECH] Ensure deployments to Query Builder succeed even after a Dependabot update.Oct 26 2023, 7:54 AM
ItamarWMDE renamed this task from [SW] [QB] [TECH] Ensure deployments to Query Builder succeed even after a Dependabot update to [QB] [TECH] Ensure deployments to Query Builder succeed even after a Dependabot update.
ItamarWMDE updated the task description. (Show Details)

QB moved to gitlab and Dependabot isn't natively supported in GitLab and it was missed to update dependabot