FloatingUI: Investigate performance improvements
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	AnneT
	Mon, Sep 18, 9:18 PM

Description

Background

T346099 covers implementing basic positioning of menus via FloatingUI in 3 components:

Select
Combobox
Lookup

This will be done in an internal composable, useFloatingMenu, so it can be applied to future menu components as well.

This task covers investigating and implementing performance improvements for this new functionality.

Implementation details

Notably, FloatingUI's autoUpdate feature seems to be triggered on scroll even when a menu is not open, causing it to recalculate the menu's position. Ideally, these calculations would not be made for invisible menus.

There may be other opportunities for performance enhancements as well.

Acceptance criteria

Investigate potential performance improvements
Implement them as necessary

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T346096 [EPIC] Add FloatingUI to Codex
		Open		None	T346698 FloatingUI: Investigate performance improvements

Event Timeline

AnneT created this task.Mon, Sep 18, 9:18 PM

Restricted Application added a project: Design-Systems-Team. · View Herald TranscriptMon, Sep 18, 9:18 PM

AnneT moved this task from Requests to Needs Refinement on the Design-Systems-Team board.Tue, Sep 19, 6:38 PM

Notably, FloatingUI's autoUpdate feature seems to be triggered on scroll even when a menu is not open, causing it to recalculate the menu's position. Ideally, these calculations would not be made for invisible menus.

This was resolved in the code review phase before https://gerrit.wikimedia.org/r/953740 was merged.

I'm not sure what other performance improvements we could consider. I did notice that when a menu is opened, its styles are updated twice (I think that's because the watcher is called once for menuVisibility changing and then again for floatingStyles changing), but that only happens on open so I don't think it's that big of a deal.

FloatingUI: Investigate performance improvementsOpen, Needs TriagePublicActions