Page MenuHomePhabricator
Create Task
Maniphest T346740

Look into loading images on every test run
Closed, ResolvedPublic5 Estimated Story PointsSpike
Actions

Description

Current situation

  • test suite starting runs docker load every time, this is slow

Goal

  • speed up test execution

Open Questions

  • Is it a general issue to decide how the build and the test system exchange their images?
  • What requirements do we have?
    • For local test development?
    • For CI runs?
  • Should the starting of the test stack be actually part of the test suite? Or could it also be left running?

Related Objects

Event Timeline

• roti_WMDE created this task.Sep 19 2023, 12:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2023, 12:40 PM
• roti_WMDE updated the task description. (Show Details)Sep 26 2023, 11:31 AM
• roti_WMDE renamed this task from Do not load docker images on every test run to Look into loading images on every test run.Sep 26 2023, 11:37 AM
• roti_WMDE added a project: Spike.
• roti_WMDE updated the task description. (Show Details)
Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptSep 26 2023, 11:37 AM
• roti_WMDE set the point value for this task to 5.Sep 26 2023, 11:38 AM
• roti_WMDE moved this task from Inbox to Sprint-∞ on the Wikibase Suite Team board.
• roti_WMDE edited projects, added: Wikibase Suite Team (Sprint-∞); removed: Wikibase Suite Team.
• roti_WMDE updated the task description. (Show Details)Sep 26 2023, 3:21 PM
adee_wmde changed the task status from Open to In Progress.Sep 27 2023, 2:03 PM
adee_wmde claimed this task.
adee_wmde moved this task from Sprint Backlog to Doing on the Wikibase Suite Team (Sprint-∞) board.
adee_wmde added a comment.Sep 28 2023, 1:51 PM

https://github.com/wmde/wikibase-release-pipeline/pull/483

adee_wmde moved this task from Doing to In Review on the Wikibase Suite Team (Sprint-∞) board.Sep 28 2023, 1:52 PM
adee_wmde closed this task as Resolved.Sep 28 2023, 2:50 PM

Went with a simple approach of checking if an image is already loaded before loading it. This means there weren't any changes to the interaction between building and testing. We should probably revisit that depending on / as part of T345689.

adee_wmde moved this task from In Review to Done on the Wikibase Suite Team (Sprint-∞) board.Sep 28 2023, 2:50 PM
• roti_WMDE moved this task from Sprint-∞ to Archive (closed) on the Wikibase Suite Team board.Oct 10 2023, 9:47 AM
• roti_WMDE edited projects, added: Wikibase Suite Team; removed: Wikibase Suite Team (Sprint-∞).
adee_wmde merged a task: T346225: Improve Test Suite speed.Oct 19 2023, 1:58 PM
adee_wmde merged a task: T346224: Improve test execution speed, docker image load.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits