Page MenuHomePhabricator

Action permissions error uses patchwork messages and produces half-translated sentences
Open, LowPublic

Description

The message "permissionserrorstext-withaction" ("You do not have permission to $2") uses "action-..." messages for parameter 2, which is in general bad for localisation (see http://www.mediawiki.org/wiki/Localisation#Avoid_patchwork_messages) and also produces half-translated sentences, when only either the main message or the action message is translated (a simple example for Spanish: "No tienes permiso para nuke pages").

We could get rid of the main message and use a full sentence for each action (e.g. "action-read" message being "You do not have permission to read this page") but that would mean a lot of translation duplication, so I'm not sure if that would be the best solution.

FYI, the relevant code is located in OutputPage::formatPermissionsErrorMessage()


Version: unspecified
Severity: normal
URL: https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Action-viewmywatchlist/hi
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=14246

Details

Reference
bz32683

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:02 AM
bzimport set Reference to bz32683.
bzimport added a subscriber: Unknown Object (MLST).

FYI, the code has been there for ages, it's not new. No actual problems have been reported for it. Missing translations is something we can't fix.

I know, but there are often bugs for which people don't complain, and imho the patchwork part is still something that could be improved (but it's not high priority, since it's there for a long time).

Maybe the qqq message for "permissionserrorstext-withaction" could be updated to ask the translators to make sure the "action-*" messages are translated too?
That will at least give a hint.

Maybe the qqq message for "permissionserrorstext-withaction" could be updated
to ask the translators to make sure the "action-*" messages are translated too?
That will at least give a hint.

Could this be closed when the qqq message is updated?

qqq would be good enough unless someone tells they can't translate properly in the current implementation.

(In reply to comment #5)

qqq would be good enough unless someone tells they can't translate properly
in
the current implementation.

Siddhartha Ghai, in the thread now in URL, asks for a list of messages used in conjunction with this in order to verify if translation is possible in all cases for Hindi.

Adding many blockers of bug 38638 to the list of "easy" bugs, to mark them as candidates for [[mw:Google Code-in]] tasks (gci2013). If you think this bug is not suitable, remove the keyword.