Page MenuHomePhabricator

Special:RunFunction - improvements needed for messages to users
Closed, ResolvedPublic

Assigned To
Authored By
Etonkovidova
Sep 20 2023, 12:02 AM
Referenced Files
F42397997: Screenshot from 2024-03-05 10-41-41.png
Mar 5 2024, 9:44 AM
F42397995: Screenshot from 2024-03-05 10-41-32.png
Mar 5 2024, 9:44 AM
F42397993: Screenshot from 2024-03-05 10-41-15.png
Mar 5 2024, 9:44 AM
F42312216: Screen Shot 2024-03-01 at 5.19.17 PM.png
Mar 2 2024, 2:12 AM
F37740636: Screen Shot 2023-09-19 at 4.15.04 PM.png
Sep 20 2023, 12:02 AM
F37740594: Screen Shot 2023-09-19 at 4.17.13 PM.png
Sep 20 2023, 12:02 AM
F37740596: Screen Shot 2023-09-19 at 4.16.33 PM.png
Sep 20 2023, 12:02 AM
F37740589: Screen Shot 2023-09-19 at 4.38.08 PM.png
Sep 20 2023, 12:02 AM
Tokens
"Yellow Medal" token, awarded by Etonkovidova.

Description

(1) "This function has no approved implementations." message is always present on Special:RunFunction
Steps:

  • go to Special:RunFunction
  • the page always displays This function has no approved implementations." even though no function was entered in the "Select function" field.

Screen Shot 2023-09-19 at 4.38.08 PM.png (960×2 px, 110 KB)

DONE (2) The message "The search has provided no result." is incorrectly displayed for existing (and found) functions.
(reported by @Bugreporter)
Steps:

  • go to Special:RunFunction
  • enter Z10167 into "Select function" field (click on the suggestion "uuid1 (Z10167)")
  • "The search has provided no result." message appears. Z10167 is a valid function without approved implementations.

Another example:

  • on Special:RunFunction enter Z10000 ( select the suggestion: join strings (Z10000))
  • "The search has provided no result." message appears along with the fields to enter functions parameters. The function can be run successfully:
Screen Shot 2023-09-19 at 4.16.33 PM.png (908×1 px, 66 KB)
Screen Shot 2023-09-19 at 4.17.13 PM.png (1×2 px, 176 KB)

DONE (3) "The provided content is not a valid Object" message displayed when an entered value is not a function
Steps

  • on Special:RunFunction enter Z20
  • "The provided content is not a valid Object" message will be displayed. The message is misleading and doesn't guide a user to correct a mistake. The more specific message will help: e.g. " the entered value is not a function".

Notice that when an input is invalid, e.g. enter KLS, the message will be "The search has provided no result."

Screen Shot 2023-09-19 at 4.15.04 PM.png (436×978 px, 33 KB)

Event Timeline

Jdforrester-WMF moved this task from To triage to Backlog on the Abstract Wikipedia team board.

Two of the issues reported on Special:RunFunction page are done and marked in the task description (checked as a part of verifying fixes T343395).

Change 1007661 had a related patch set uploaded (by Ecarg; author: jenkins-bot):

[mediawiki/extensions/WikiLambda@master] Remove unnecessary message when running a function

https://gerrit.wikimedia.org/r/1007661

Change 1007661 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] FunctionEvaluator: Hide 'no approved implementations' until function is selected

https://gerrit.wikimedia.org/r/1007661

Checked in wikifuctions beta - works as expected; the message "This function has no approved implementations." is not displayed on the initial load (before any functions is selected):

Screen Shot 2024-03-01 at 5.19.17 PM.png (956×2 px, 116 KB)

@ecarg - currently, on Special:RunFunction page a user enters a function that doesn't have an implementation*/Z10814 or a function with disconnected implementation Z10147, the form doesn't inform a user that the selected function cannot be run. When a user enters some values, Run function button remains inactive.
Should such case provide more feedback to a user, something like "The selected function cannot be run - no approved implementations exist"?

Change 1008519 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] FunctionEvaluator: Hide 'no approved implementations' until function is selected

https://gerrit.wikimedia.org/r/1008519

@Etonkovidova Thanks a lot for pointing this out, and thanks @ecarg for the quick fix. This is now merged:

Initial state:

Screenshot from 2024-03-05 10-41-15.png (203×957 px, 8 KB)

Function with implementations:

Screenshot from 2024-03-05 10-41-32.png (518×945 px, 22 KB)

Function with no active implementations:

Screenshot from 2024-03-05 10-41-41.png (437×947 px, 21 KB)

Change 1008519 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] FunctionEvaluator: Hide 'no approved implementations' until function is selected

https://gerrit.wikimedia.org/r/1008519