Page MenuHomePhabricator

Release the email participants feature
Closed, ResolvedPublic

Description

Background: Add any relevant context/background here.

Acceptance criteria

Release the email participants feature in the following order:

  • Testwiki and Test2wiki (must be done first and pass testing)
  • Meta-Wiki and OfficeWiki

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptSep 21 2023, 2:41 PM

Change 960559 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[operations/mediawiki-config@master] Enable Campaigns email on test wiki

https://gerrit.wikimedia.org/r/960559

Change 960559 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable Campaigns email on test wiki

https://gerrit.wikimedia.org/r/960559

Mentioned in SAL (#wikimedia-operations) [2023-09-28T13:06:59Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:960559|Enable Campaigns email on test wiki (T347065)]]

Mentioned in SAL (#wikimedia-operations) [2023-09-28T13:08:27Z] <urbanecm@deploy2002> urbanecm and mhorsey: Backport for [[gerrit:960559|Enable Campaigns email on test wiki (T347065)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-09-28T13:19:31Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:960559|Enable Campaigns email on test wiki (T347065)]] (duration: 12m 31s)

โœ… Testwiki and Test2wiki (must be done first and pass testing)

This is working correctly in testwiki and test2wiki with private and public participants with an array of email clients.

gmailhotmailoutlolokprotonyahoo
gmail.png (962ร—1 px, 305 KB)
hotmail.png (1ร—1 px, 403 KB)
outlook.png (1ร—1 px, 293 KB)
yahoo.png (1ร—1 px, 365 KB)
protonmail.png (1ร—1 px, 442 KB)

The only thing to note is an edge case that if the organizer sends an email with an excessively long title, it will be blocked by most email clients. Notably, proton did not block it, so I don't believe it is an issue on our end. We might want to consider including a max character limit on the title. But also, this is an edge case.

Thanks! Another issue I just realized from these screenshots is that the email does not state where it's coming from (i.e., it doesn't say who sent it, or for what event, or even just that it was sent as part of an event). I wonder how serious of an issue this might be. @ifried Any thoughts?

Thanks for pointing this out, @Daimona! I think this definitely makes the feature less useful, since it requires that the organizer knows to add in all of the contextual information in their message, when it would be natural for them to assume that the email itself will set such context for the participants. I have created a ticket to improve this in the future (T348043), which we can work on separately, but it should not block the release of this feature.

Change 963307 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] prod: Enable wgCampaignEventsEnableEmail in meta and officewiki

https://gerrit.wikimedia.org/r/963307

Change 963307 merged by jenkins-bot:

[operations/mediawiki-config@master] prod: Enable wgCampaignEventsEnableEmail in meta and officewiki

https://gerrit.wikimedia.org/r/963307

Mentioned in SAL (#wikimedia-operations) [2023-10-04T14:12:44Z] <lucaswerkmeister-wmde@deploy2002> Started scap: Backport for [[gerrit:963307|prod: Enable wgCampaignEventsEnableEmail in meta and officewiki (T347065)]]

Mentioned in SAL (#wikimedia-operations) [2023-10-04T14:14:12Z] <lucaswerkmeister-wmde@deploy2002> daimona and lucaswerkmeister-wmde: Backport for [[gerrit:963307|prod: Enable wgCampaignEventsEnableEmail in meta and officewiki (T347065)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-10-04T14:31:10Z] <lucaswerkmeister-wmde@deploy2002> Finished scap: Backport for [[gerrit:963307|prod: Enable wgCampaignEventsEnableEmail in meta and officewiki (T347065)]] (duration: 18m 26s)

vaughnwalters added a subscriber: gonyeahialam.

Messages sending correctly in Meta ๐ŸŽ‰

gmailhotmailoutlookprotonyahoo
Screenshot 2023-10-06 at 2.12.10 PM.png (1ร—1 px, 293 KB)
Screenshot 2023-10-06 at 2.38.43 PM.png (1ร—1 px, 383 KB)
Screenshot 2023-10-06 at 2.48.53 PM.png (1ร—1 px, 380 KB)
Screenshot 2023-10-06 at 2.50.52 PM.png (1ร—2 px, 448 KB)
Screenshot 2023-10-06 at 2.51.25 PM.png (1ร—1 px, 374 KB)

Sending this to design sign off. @gonyeahialam note that T348043 has been created as well.

@vaughnwalters
Is "Event details: Sandbox/VWalters..." the email subject?

@vaughnwalters
Is "Event details: Sandbox/VWalters..." the email subject?

Yes, that is the email subject

I don't know if you have already identified it but I think I may have found a bug. @vaughnwalters
What happens when an organizer tries to send a message of less than 10 characters? @Daimona

I entered a subject, then a message with less than 10 characters(the text area was red) clicked on send, and received the message sent confirmation but never got a message on my email.
I did this twice and got the same results
But when I tried with more than 10 characters I received the email.

Screen Recording 2023-10-09 at 19.23.36.gif (536ร—960 px, 113 KB)

I don't know if you have already identified it but I think I may have found a bug. @vaughnwalters
What happens when an organizer tries to send a message of less than 10 characters? @Daimona

I entered a subject, then a message with less than 10 characters(the text area was red) clicked on send, and received the message sent confirmation but never got a message on my email.
I did this twice and got the same results
But when I tried with more than 10 characters I received the email.

Screen Recording 2023-10-09 at 19.23.36.gif (536ร—960 px, 113 KB)

Ah good catch @gonyeahialam , this is a bug I had not seen yet. I was able to replicate this, but it occurs only when typing more than ten characters and then deleting to less than ten characters. I'll make a bug ticket for this.

I don't know if you have already identified it but I think I may have found a bug. @vaughnwalters
What happens when an organizer tries to send a message of less than 10 characters? @Daimona

I entered a subject, then a message with less than 10 characters(the text area was red) clicked on send, and received the message sent confirmation but never got a message on my email.
I did this twice and got the same results
But when I tried with more than 10 characters I received the email.

Screen Recording 2023-10-09 at 19.23.36.gif (536ร—960 px, 113 KB)

Ah good catch @gonyeahialam , this is a bug I had not seen yet. I was able to replicate this, but it occurs only when typing more than ten characters and then deleting to less than ten characters. I'll make a bug ticket for this.

follow up task T348475.

I don't know if you have already identified it but I think I may have found a bug. @vaughnwalters
What happens when an organizer tries to send a message of less than 10 characters? @Daimona

I entered a subject, then a message with less than 10 characters(the text area was red) clicked on send, and received the message sent confirmation but never got a message on my email.
I did this twice and got the same results
But when I tried with more than 10 characters I received the email.

Screen Recording 2023-10-09 at 19.23.36.gif (536ร—960 px, 113 KB)

Ah good catch @gonyeahialam , this is a bug I had not seen yet. I was able to replicate this, but it occurs only when typing more than ten characters and then deleting to less than ten characters. I'll make a bug ticket for this.

follow up task T348475.

This has been fixed now in T348475

The feature has been released, so I am marking this as Done.