getting grant ID
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ifried
	Sep 21 2023, 3:53 PM

Description

Acceptance criteria

Organizers should be able to add the grant ID to an event using the API
- The organizer should be able to add the numbers of the grant ID only, e.g., 1234-1234
When the organizer sends the request, we should validate that the grant ID is valid.
- If it is valid, the change should be made
- If it is invalid, the organizer should receive a error message, which reads: "The Grant ID you entered is invalid."
- If there is an error due to the Fluxx API, the user should see the following message: "Fluxx is currently unable to validate this Grant ID. Try again in a few minutes."
The organizer should be able to edit the grant ID via the API
The organizer should be able to delete the grant ID via the API
- The same validation logic applies to editing grant ID as it does to first entering the grant ID
The organizer should be able to obtain the current grant ID for an event by using the API.
The API documentation should be created for the following endpoints:
- Edit grant ID
- Delete grant ID
- Get grant ID

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Add endpoint for obtaining grant ID	mediawiki/extensions/WikimediaCampaignEvents	master	+212 -2
Add new endpoints	mediawiki/extensions/WikimediaCampaignEvents	master	+606 -1
Add hooks	mediawiki/extensions/CampaignEvents	master	+99 -24

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Daimona	T347876 Mark the WikimediaCampaignEvents extension as stable
Resolved	cmelo	T321814 EPIC: Add Grant ID support to event registration
Resolved	MHorsey-WMF	T347087 Create API endpoints for updating/deleting/getting grant ID

Event Timeline

ifried created this task.Sep 21 2023, 3:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2023, 3:53 PM

ifried added a parent task: T321814: EPIC: Add Grant ID support to event registration.Sep 21 2023, 3:54 PM

MHorsey-WMF updated the task description. (Show Details)Sep 28 2023, 1:30 PM

Daimona added a project: WikimediaCampaignEvents.Oct 2 2023, 5:18 PM

MHorsey-WMF edited projects, added Connection-Team (Connection-Current-Sprint); removed Connection-Team.Oct 12 2023, 9:38 AM

MHorsey-WMF claimed this task.Oct 16 2023, 9:33 AM

ifried changed the task status from Open to In Progress.Oct 19 2023, 2:52 PM

ifried moved this task from Upcoming / refining 💡 to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.

Daimona updated the task description. (Show Details)Oct 26 2023, 1:17 PM

Daimona updated the task description. (Show Details)Oct 26 2023, 1:38 PM

Change 969799 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Add hooks

https://gerrit.wikimedia.org/r/969799

gerritbot added a project: Patch-For-Review.Oct 30 2023, 3:39 PM

Pivoted this to provide new API for updating grant IDs rather than hooks

Daimona moved this task from Backlog to New functionality on the CampaignEvents board.Nov 10 2023, 6:00 PM

Change 969799 abandoned by Daimona Eaytoy:

[mediawiki/extensions/CampaignEvents@master] Add hooks

Reason:

Superseded by I2e859edaf922234801339ab489822423273097c9

https://gerrit.wikimedia.org/r/969799

Maintenance_bot removed a project: Patch-For-Review.Nov 20 2023, 2:10 PM

Daimona updated the task description. (Show Details)Nov 21 2023, 2:40 PM

Change 973208 had a related patch set uploaded (by Daimona Eaytoy; author: Mhorsey):

[mediawiki/extensions/WikimediaCampaignEvents@master] Add new endpoints

https://gerrit.wikimedia.org/r/973208

gerritbot added a project: Patch-For-Review.Nov 21 2023, 2:40 PM

Daimona renamed this task from Hooks for the enable/edit/get registration API endpoints, analogous to those for the special pages to Create API endpoints for updating/deleting/getting grant ID.Nov 21 2023, 2:41 PM

Change 976240 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/WikimediaCampaignEvents@master] Add endpoint for obtaining grant ID

https://gerrit.wikimedia.org/r/976240

Change 973208 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCampaignEvents@master] Add new endpoints

https://gerrit.wikimedia.org/r/973208

Change 976240 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCampaignEvents@master] Add endpoint for obtaining grant ID

https://gerrit.wikimedia.org/r/976240

Daimona mentioned this in rEWCE37686611a02d: Add endpoint for obtaining grant ID.Nov 23 2023, 12:43 PM

Daimona mentioned this in rEWCE7a6f50d769c2: Add new endpoints.

Maintenance_bot removed a project: Patch-For-Review.Nov 23 2023, 1:10 PM

Daimona updated the task description. (Show Details)Nov 23 2023, 3:07 PM

Documentation created, sending this task to QA.

vaughnwalters subscribed.Dec 1 2023, 8:11 PM

This comment was removed by vaughnwalters.

✅ Organizers should be able to add the grant ID to an event using the API

Screenshot 2023-12-01 at 2.14.14 PM.png (1×2 px, 238 KB)

✅ The organizer should be able to add the numbers of the grant ID only, e.g., 1234-1234

Any letters I put in with the test grant IDs were not accepted:

numbers only	letters / numbers

When the organizer sends the request, we should validate that the grant ID is valid.
✅ If it is valid, the change should be made

Screenshot 2023-12-01 at 2.50.18 PM.png (1×1 px, 182 KB)

✅ If it is invalid, the organizer should receive a error message, which reads: "The Grant ID you entered is invalid."

Screenshot 2023-12-01 at 2.51.38 PM.png (1×1 px, 244 KB)

✅ If there is an error due to the Fluxx API, the user should see the following message: "Fluxx is currently unable to validate this Grant ID. Try again in a few minutes."

Screenshot 2023-12-01 at 4.09.30 PM.png (1×2 px, 283 KB)

✅ The organizer should be able to edit the grant ID via the API

Screenshot 2023-12-01 at 3.01.50 PM.png (1×1 px, 178 KB)

✅ The organizer should be able to delete the grant ID via the API

Screenshot 2023-12-01 at 3.03.09 PM.png (1×2 px, 208 KB)

✅ The same validation logic applies to editing grant ID as it does to first entering the grant ID
This works the same for a new event the first time entering in the grant ID as it does to editing an event

editing the grant ID	first entering the grant ID

✅ The organizer should be able to obtain the current grant ID for an event by using the API.

Screenshot 2023-12-01 at 3.08.43 PM.png (1×2 px, 199 KB)

The API documentation should be created for the following endpoints:

✅ Edit grant ID
✅ Delete grant ID
✅ Get grant ID

vaughnwalters moved this task from QA 🐛 to Product sign-off 🖌️ on the Connection-Team (Connection-Current-Sprint) board.Dec 18 2023, 5:29 PM

ifried closed this task as Resolved.Feb 14 2024, 7:46 PM

ifried moved this task from Product sign-off 🖌️ to Done 🏁 on the Connection-Team (Connection-Current-Sprint) board.

	F41551877: Screenshot 2023-12-01 at 3.08.43 PM.png
	Dec 1 2023, 10:16 PM

	F41552078: Screenshot 2023-12-01 at 4.04.15 PM.png
	Dec 1 2023, 10:16 PM

	F41551938: Screenshot 2023-12-01 at 3.14.20 PM.png
	Dec 1 2023, 10:16 PM

	F41551870: Screenshot 2023-12-01 at 3.03.09 PM.png
	Dec 1 2023, 10:16 PM

	F41551866: Screenshot 2023-12-01 at 3.01.50 PM.png
	Dec 1 2023, 10:16 PM

	F41552082: Screenshot 2023-12-01 at 4.09.30 PM.png
	Dec 1 2023, 10:16 PM

	F41551843: Screenshot 2023-12-01 at 2.51.38 PM.png
	Dec 1 2023, 10:16 PM

	F41551842: Screenshot 2023-12-01 at 2.50.54 PM.png
	Dec 1 2023, 10:16 PM

Create API endpoints for updating/deleting/getting grant IDClosed, ResolvedPublicActions