Page MenuHomePhabricator
Create Task
Maniphest T347393

Store client hint mapping rows for user account creations on loginwiki
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

CheckUser currently integrates with the CentralAuth extension such that the wiki specified in $wgCentralAuthLoginWiki has account creation logs in the CheckUser results for all accounts created on any wiki in the wikifarm.

This in effect creates a minimal Global CheckUser and is used on WMF projects to find accounts cross-wiki for LTAs (long term abusers).

Client Hints data should be collected and displayed for these events for the wiki specified in $wgCentralAuthLoginWiki so that Client Hints data can be used to compare accounts on that wiki.

Acceptance criteria
  • Account creations shown in the $wgCentralAuthLoginWiki wiki CheckUser results have Client Hints data specified.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Store Client Hints data for autocreationsmediawiki/extensions/CheckUsermaster+333 -33
Fix clienthints.js selenium testsmediawiki/extensions/CheckUsermaster+79 -42
Set wgCheckUserLogLogins by default to truemediawiki/extensions/CheckUsermaster+1 -1
Make UserAgentClientHintsManager wiki aware for insertsmediawiki/extensions/CheckUsermaster+36 -30
[WIP] Add CopyClientHintsDataToCentralAuthAutoCreateWikisJobmediawiki/extensions/CheckUsermaster+163 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dreamy_Jazz created this task.Sep 26 2023, 12:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2023, 12:26 PM
Dreamy_Jazz moved this task from Backlog to Release 2 (iteration, increase data collection coverage) on the http-client-hints board.Sep 26 2023, 12:28 PM
Dreamy_Jazz edited projects, added: http-client-hints (Release 2 (iteration, increase data collection coverage)); removed: http-client-hints.
AmandaNP subscribed.Oct 18 2023, 8:35 PM
Tegel subscribed.Oct 18 2023, 9:01 PM
Dreamy_Jazz added a parent task: T328992: Add read new support to Special:CheckUser for event table migration.Oct 22 2023, 1:18 PM
Dreamy_Jazz removed a parent task: T328992: Add read new support to Special:CheckUser for event table migration.
Dreamy_Jazz added subtasks: T328992: Add read new support to Special:CheckUser for event table migration, T345817: Store client hint mapping rows for user account creation events.
Dreamy_Jazz closed subtask T328992: Add read new support to Special:CheckUser for event table migration as Resolved.Dec 11 2023, 5:21 PM
Dreamy_Jazz mentioned this in T371267: Create a script to backfill missing local accounts on loginwiki/metawiki for new global accounts.Jul 30 2024, 10:46 AM
kostajh added a project: Trust and Safety Product Sprint.Nov 15 2024, 8:07 AM
Dreamy_Jazz added a parent task: T341094: Create client hint mapping rows for CheckUser-worthy events.Nov 15 2024, 1:12 PM
kostajh added a project: WE4.2 Anti-abuse.Nov 15 2024, 8:16 PM
Dreamy_Jazz added a comment.Nov 18 2024, 5:16 PM

I think we can make use of copying the Client Hints data from the local wiki through a job that is queued once the user is created.

Dreamy_Jazz claimed this task.Nov 18 2024, 5:17 PM
Dreamy_Jazz set the point value for this task to 2.
Dreamy_Jazz edited projects, added: Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)); removed: Trust and Safety Product Sprint.
gerritbot added a comment.Nov 18 2024, 6:37 PM

Change #1092313 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Make UserAgentClientHintsManager wiki aware for inserts

https://gerrit.wikimedia.org/r/1092313

gerritbot added a project: Patch-For-Review.Nov 18 2024, 6:37 PM

Change #1092314 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Add CopyClientHintsDataToCentralAuthAutoCreateWikisJob

https://gerrit.wikimedia.org/r/1092314

kostajh moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.Nov 19 2024, 7:38 AM
gerritbot added a comment.Nov 20 2024, 12:00 AM

Change #1092314 abandoned by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] [WIP] Add CopyClientHintsDataToCentralAuthAutoCreateWikisJob

Reason:

On further looking, this isn't fully necessary.

https://gerrit.wikimedia.org/r/1092314

gerritbot added a comment.Nov 21 2024, 11:42 PM

Change #1094067 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Store Client Hints data for autocreations

https://gerrit.wikimedia.org/r/1094067

gerritbot added a comment.Nov 22 2024, 1:44 PM

Change #1092313 abandoned by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] Make UserAgentClientHintsManager wiki aware for inserts

Reason:

Should no longer be needed.

https://gerrit.wikimedia.org/r/1092313

gerritbot added a comment.Nov 22 2024, 4:46 PM

Change #1094487 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Fix clienthints.js selenium tests

https://gerrit.wikimedia.org/r/1094487

gerritbot added a comment.Nov 22 2024, 6:00 PM

Change #1094505 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Set wgCheckUserLogLogins by default to true

https://gerrit.wikimedia.org/r/1094505

gerritbot added a comment.Nov 25 2024, 11:50 AM

Change #1094505 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Set wgCheckUserLogLogins by default to true

https://gerrit.wikimedia.org/r/1094505

gerritbot added a comment.Nov 25 2024, 11:51 AM

Change #1094487 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Fix clienthints.js selenium tests

https://gerrit.wikimedia.org/r/1094487

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.5; 2024-11-25).Nov 25 2024, 12:00 PM
kostajh moved this task from In Progress to Needs QA on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.Nov 25 2024, 1:25 PM
gerritbot added a comment.Nov 25 2024, 2:02 PM

Change #1094067 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Store Client Hints data for autocreations

https://gerrit.wikimedia.org/r/1094067

Maintenance_bot removed a project: Patch-For-Review.Nov 25 2024, 2:30 PM
JJMC89 mentioned this in T381128: backfillLocalAccounts.php should fill Client Hints.Nov 28 2024, 10:44 PM
dom_walden moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.Dec 4 2024, 3:48 PM
dom_walden subscribed.

I can confirm we are adding rows to cu_useragent_clienthints and cu_useragent_clienthints_map after making an edit on the $wgCentralAuthLoginWiki wiki which created a temporary account. I confirmed that the uachm_reference_id corresponds to the correct cupe_id in cu_private_event.

Test environment: local docker CheckUser 2.5 (da1dd98) 07:21, 4 December 2024.

kostajh closed subtask T345817: Store client hint mapping rows for user account creation events as Resolved.Dec 5 2024, 8:30 AM
Dreamy_Jazz closed this task as Resolved.Dec 5 2024, 11:08 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits