Page MenuHomePhabricator
Create Task
Maniphest T347587

Display original data collection text if and only if Participant Questions not enabled
Closed, ResolvedPublic
Actions

Assigned To
Daimona
Authored By
ifried
Sep 28 2023, 2:08 PM
Tags
Referenced Files
F38510573: Screenshot 2023-10-17 at 2.02.56 PM.png
Oct 17 2023, 7:05 PM
F38510329: Screenshot 2023-10-17 at 11.33.58 AM.png
Oct 17 2023, 7:05 PM
F38211225: Screenshot 2023-10-11 at 3.21.57 PM.png
Oct 11 2023, 8:28 PM
F37830759: Screenshot 2023-09-28 at 10.36.08 AM.png
Sep 28 2023, 2:37 PM
F37153597: Enable Registration Form (2).png
Sep 28 2023, 2:09 PM
Subscribers
Aklapper
gonyeahialam
ifried
vaughnwalters

Description

Background: We currently have the following text displayed to the organizers at the bottom of the Event Registration configuration form: "Only usernames will be collected from participants during registration. Learn more." This text should be removed when Participant Questions is released and available to users, as we have a new explanatory text on data collection and the "Only usernames..." text will no longer be valid. However, before Participant Questions is enabled, the text should remain in the UI, so that organizers know about the currently applicable data collection policy.

Acceptance criteria

  • Display the original data collection text if and only if Participant Questions are not enabled (see text below)
    • The text is the following: "Only usernames will be collected from participants during registration. Learn more."

Visual example

Screenshot 2023-09-28 at 10.36.08 AM.png (466×1 px, 64 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Show registration form footer if event has no questions enabledmediawiki/extensions/CampaignEventsmaster+4 -1
Show registration form footer iff participant questions are not enabledmediawiki/extensions/CampaignEventsmaster+15 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

ifried created this task.Sep 28 2023, 2:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 28 2023, 2:08 PM
ifried updated the task description. (Show Details)Sep 28 2023, 2:09 PM
ifried renamed this task from Remove data collection text after Participant Questions released to Display data collection text if Participant Questions not enabled.Sep 28 2023, 2:22 PM
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)
ifried renamed this task from Display data collection text if Participant Questions not enabled to Display original data collection text if Participant Questions not enabled.Sep 28 2023, 2:26 PM
ifried updated the task description. (Show Details)
ifried mentioned this in T347595: Update Help link for Registration Configuration form.Sep 28 2023, 2:32 PM
ifried updated the task description. (Show Details)Sep 28 2023, 2:36 PM
ifried updated the task description. (Show Details)
Daimona added a parent task: T321822: [EPIC] Participant Questions - MVP.Sep 28 2023, 2:47 PM
Daimona renamed this task from Display original data collection text if Participant Questions not enabled to Display original data collection text if and only if Participant Questions not enabled.Sep 28 2023, 4:03 PM
Daimona claimed this task.
Daimona updated the task description. (Show Details)
gerritbot added a comment.Sep 28 2023, 4:15 PM

Change 961846 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Show registration form footer iff participant questions are not enabled

https://gerrit.wikimedia.org/r/961846

gerritbot added a project: Patch-For-Review.Sep 28 2023, 4:15 PM
Daimona edited projects, added Connection-Team (Connection-Current-Sprint); removed Connection-Team.Sep 28 2023, 4:15 PM
Daimona moved this task from Upcoming / refining 💡 to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.
gerritbot added a comment.Oct 11 2023, 2:13 PM

Change 961846 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Show registration form footer iff participant questions are not enabled

https://gerrit.wikimedia.org/r/961846

Daimona moved this task from Code Review 💬 to QA 🐛 on the Connection-Team (Connection-Current-Sprint) board.Oct 11 2023, 2:26 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 11 2023, 2:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Oct 11 2023, 3:00 PM
vaughnwalters subscribed.Oct 11 2023, 8:28 PM

This currently does not display if participant questions are not enabled:

See this event @Daimona

Screenshot 2023-10-11 at 3.21.57 PM.png (276×1 px, 44 KB)

vaughnwalters moved this task from QA 🐛 to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.Oct 11 2023, 8:36 PM
Daimona added a comment.Oct 11 2023, 9:40 PM
In T347587#9244374, @vaughnwalters wrote:

This currently does not display if participant questions are not enabled:

See this event @Daimona

Hmmm you mean that it's not displayed if no questions are enabled for a specific event, right? That's true. I'm not sure if it's worth fixing, though. @ifried How would we handle this when we implement T322209 and the organizer does not select any questions?

vaughnwalters added a comment.EditedOct 12 2023, 7:15 PM
In T347587#9244690, @Daimona wrote:
In T347587#9244374, @vaughnwalters wrote:

This currently does not display if participant questions are not enabled:

See this event @Daimona

Hmmm you mean that it's not displayed if no questions are enabled for a specific event, right? That's true. I'm not sure if it's worth fixing, though. @ifried How would we handle this when we implement T322209 and the organizer does not select any questions?

Correct, I meant for a specific event. From the AC I did not know that there was a distinction?

ifried updated the task description. (Show Details)Oct 12 2023, 8:01 PM
ifried updated the task description. (Show Details)Oct 12 2023, 8:12 PM
ifried updated the task description. (Show Details)
ifried added a subscriber: gonyeahialam.Oct 12 2023, 8:18 PM

@Daimona, I'm a little confused regarding why you said it's not worth getting fixed. Can you clarify? Apologies, I may not be grasping something. As for T322209, we don't know when we're working on that feature and no product research has been done on it yet (though perhaps @gonyeahialam may have some thoughts on how this should be handled?), but I do think it would probably make sense to display 'Only usernames will be collected...' if the organizer opts out of all participant questions in the future.

Daimona added a comment.Oct 12 2023, 9:03 PM
In T347587#9247824, @ifried wrote:

@Daimona, I'm a little confused regarding why you said it's not worth getting fixed. Can you clarify?

It's just that "fixing" this means keeping this text around forever, because there will always be times when it's needed. If we will need the text for T322209, then it might make sense to fix this bug and leave the text around. But if not, things would be simpler without this text, and we would only be keeping it around for older events created before the release of PQ. I thought that maybe we could rely on the "participant questions" section of the form to explain what is or isn't collected. At any rate, this would be easy to fix, it's just my preference for not leaving something around if we can do without it.

ifried added a comment.Oct 12 2023, 9:18 PM

Ah, I see. Yes, there's a good chance that some organizers in the future will either not have participant questions because they have not chosen to add them (if we do T322209) or because a community chose to not allow them at all via community configuration choices. So, in total, it probably makes sense to fix the bug. Is it a complex/gnarly fix or relatively straight-forward?

gerritbot added a comment.Oct 13 2023, 2:03 PM

Change 965747 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Show registration form footer if event has no questions enabled

https://gerrit.wikimedia.org/r/965747

gerritbot added a project: Patch-For-Review.Oct 13 2023, 2:03 PM
Daimona added a comment.Oct 13 2023, 2:05 PM
In T347587#9248002, @ifried wrote:

Is it a complex/gnarly fix or relatively straight-forward?

It's straightforward :) It wasn't about the complexity of the fix, but the cost of leaving this message around for just the events that were created before the release.

Daimona mentioned this in T347591: Remove original data collection text if Participant Questions enabled.Oct 13 2023, 2:06 PM
ifried added a comment.Oct 13 2023, 2:32 PM

Okay, great! And thanks for checking in about this and working on the fix!

gerritbot added a comment.Oct 17 2023, 12:45 PM

Change 965747 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Show registration form footer if event has no questions enabled

https://gerrit.wikimedia.org/r/965747

Daimona moved this task from Code Review 💬 to QA 🐛 on the Connection-Team (Connection-Current-Sprint) board.Oct 17 2023, 12:46 PM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.2; 2023-10-24); removed MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Oct 17 2023, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 17 2023, 1:10 PM
vaughnwalters attached a referenced file: F37153597: Enable Registration Form (2).png. (Show Details)Oct 17 2023, 7:05 PM
vaughnwalters moved this task from QA 🐛 to Design sign-off 🖌️ on the Connection-Team (Connection-Current-Sprint) board.

✅ Display the original data collection text if and only if Participant Questions are not enabled (see text below)
✅ The text is the following: "Only usernames will be collected from participants during registration. Learn more."

Screenshot 2023-10-17 at 11.33.58 AM.png (324×1 px, 65 KB)

Text does not show if Participant questions are enabled:

Screenshot 2023-10-17 at 2.02.56 PM.png (1×2 px, 229 KB)

This is functioning correctly now, sending to design sign off.

gonyeahialam moved this task from Design sign-off 🖌️ to Product sign-off 🖌️ on the Connection-Team (Connection-Current-Sprint) board.Oct 18 2023, 9:01 AM
ifried closed this task as Resolved.Nov 9 2023, 8:17 PM
ifried moved this task from Product sign-off 🖌️ to Done 🏁 on the Connection-Team (Connection-Current-Sprint) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits