Page MenuHomePhabricator

Declaration of MobileFormatter::parseItemsToRemove() must be compatible with HtmlFormatter\HtmlFormatter::parseItemsToRemove()
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Install MobileFrontend 2.4.1
  • Upgrade to MediaWiki 1.39.5

What happens?:

Error 500:

PHP Fatal error:  Declaration of MobileFormatter::parseItemsToRemove() must be compatible with HtmlFormatter\HtmlFormatter::parseItemsToRemove(): array in extensions/MobileFrontend/includes/MobileFormatter.php on line 67

Related Objects

Event Timeline

If you happen to have TextExtracts you should update that one too since recent changes will stop updating with edits otherwise

https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/TextExtracts/+/b5ecedb58c594a108bd9035795f0d553ed834afd

I have the same problem with Mediawiki 1.40. Upgrade to 1.40.1 returns in a Error 500. Going back to 1.40, all is ok again.

I have the same problem with Mediawiki 1.40. Upgrade to 1.40.1 returns in a Error 500. Going back to 1.40, all is ok again.

You will need to also update MobileFrontend from the REL1_40 branch when you update to 1.40.1.

I can confirm updating the extensions to the latest code on the REL1_39 branches resolved this problem for me on my site that was freshly updated to 1.39.5. Feels like the change that prompted this should have been called out somewhere given it was basically a breaking change in a minor patch release though

I have the same problem with Mediawiki 1.40. Upgrade to 1.40.1 returns in a Error 500. Going back to 1.40, all is ok again.

You will need to also update MobileFrontend from the REL1_40 branch when you update to 1.40.1.

Thanks.

But that means 1.40.1 is not only a security release, but also contains breaking changes. Why isn't this mentioned?

I got the same issue when I was on REL1_39 for Mobile Frontend—some version of February or April 2023. After updating to the latest revision on REL1_39, everything is working as expected again.

Software Version

  • MediaWiki 1.39.5 (774ca20) 02:59, 29. Sep. 2023
  • PHP 7.4.33 (cgi-fcgi)

Similar experience here: I updated to 1.40.1 but my mobile site hit this fatal error. For now I've disabled MobileFrontend until the issue is corrected.

You need to update the extension. The code was fixed while ago.

Krinkle claimed this task.