Page MenuHomePhabricator

[M] Add a new step to specify the threshold of originality for own work
Closed, ResolvedPublic

Description

Context
As part of improving the release rights step of Upload Wizard on Commons T347298, we will make UX improvements to the licensing step for own work.

This ticket is a subtask for T347596

Check latest prototype for estimation only (check link to UI below for implementation)

Link to UI

Acceptance Criteria

  • Show a new question to identify derivative works with three choices as shown in this first level UI options
  • This is the first question in the form
  • If the user clicks on the Next button without making a selection (scroll up to the question if off the screen) and show the error under q1 as shown in this UI
  • Campaigns can choose to hide this question entirely as shown in this example

First option

  • Show "This is entirely my own work" as first option under this question

Second option

  • Show "This work contains the work of others" as a second option with a subscript containing examples as shown in the UI
  • When the second option is selected - reveal the sub-question and selections as shown in this UI
  • If "I am not sure" is selected in the nested options, reveal a warning message as shown in this UI with specified links to the help pages
  • If "No, it is copyright protected" is selected in the nested options, reveal a warning message as shown in this UI with specified links to the help pages
  • If the user clicks on Next without selecting any of the nested options, then show an error message below the question as shown in this UI

Third option

  • Add the option to indicated that this was AI generated as shown in the UI (which adds a template {{PD-algorithm}} if selected as per https://commons.wikimedia.org/wiki/Template:PD-algorithm)
  • If this option is selected, reveal an additional input box for AI attribution as shown in this UI.
    • Show the title, input and example as shown in the UI link above
    • If the user leaves this field empty and proceeds, then show an error message with a copy "Answer to this question is required" as as shown in this UI

Event Timeline

MarkTraceur renamed this task from Add a new step to specify the threshold of originality for own work to [M] Add a new step to specify the threshold of originality for own work.Oct 4 2023, 5:03 PM
mfossati changed the task status from Open to In Progress.Oct 23 2023, 10:41 AM
mfossati claimed this task.
Weekly update

Made good progress, then spent some time debugging why code that handles warning messages for sub-radio buttons was never reached.
Note that acceptance criteria came on Wed 25 and augmented the previously estimated effort in my opinion.

Change 975871 had a related patch set uploaded (by Marco Fossati; author: Marco Fossati):

[mediawiki/extensions/UploadWizard@master] Release rights, own work: specify the threshold of originality

https://gerrit.wikimedia.org/r/975871

Weekly update

Back to work, continued where I left off.
Sent 3 incremental patches that are now ready for review.

Change 975871 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Release rights, own work: specify the threshold of originality

https://gerrit.wikimedia.org/r/975871

(0)

  • Show a new question to identify derivative works with three choices as shown in this first level UI options
  • This is the first question in the form
  • If the user clicks on the Next button without making a selection (scroll up to the question if off the screen) and show the error under q1 as shown in this UI
  • Campaigns can choose to hide this question entirely as shown in this example

(1)

First option

  • Show "This is entirely my own work" as first option under this question
mockupsbeta
Screen Shot 2023-12-01 at 9.58.06 AM.png (1×1 px, 286 KB)
Screen Shot 2023-12-01 at 9.03.33 AM.png (1×1 px, 220 KB)
Screen Shot 2023-12-01 at 10.23.37 AM.png (1×1 px, 358 KB)
Screen Shot 2023-12-01 at 9.03.07 AM.png (1×1 px, 383 KB)

(2)

Second option

  • Show "This work contains the work of others" as a second option with a subscript containing examples as shown in the UI
  • When the second option is selected - reveal the sub-question and selections as shown in this UI
mockupsbeta
Screen Shot 2023-12-01 at 2.13.51 PM.png (1×1 px, 206 KB)
Screen Shot 2023-12-01 at 12.30.12 PM.png (1×1 px, 266 KB)

Note: The warning appears automatically when a user clicks on the second option - added to T352477. In a sense, the warning might serve as an additional guidance to a user to indicate that the selection is required.

  • If "I am not sure" is selected in the nested options, reveal a warning message as shown in this UI with specified links to the help pages
  • If "No, it is copyright protected" is selected in the nested options, reveal a warning message as shown in this UI with specified links to the help pages
mockupsbeta
Screen Shot 2023-12-01 at 2.25.36 PM.png (1×1 px, 266 KB)
Screen Shot 2023-12-01 at 2.30.38 PM.png (1×1 px, 159 KB)
Screen Shot 2023-12-01 at 2.24.26 PM.png (1×2 px, 219 KB)
Screen Shot 2023-12-01 at 2.24.14 PM.png (986×1 px, 195 KB)
  • If the user clicks on Next without selecting any of the nested options, then show an error message below the question as shown in this UI
mockupsbeta
Screen Shot 2023-12-01 at 2.34.36 PM.png (1×1 px, 251 KB)
Screen Shot 2023-12-01 at 2.33.23 PM.png (1×2 px, 375 KB)

(3)

Third option

  • Add the option to indicated that this was AI generated as shown in the UI (which adds a template {{PD-algorithm}} if selected as per https://commons.wikimedia.org/wiki/Template:PD-algorithm)
  • If this option is selected, reveal an additional input box for AI attribution as shown in this UI.
    • Show the title, input and example as shown in the UI link above
    • If the user leaves this field empty and proceeds, then show an error message with a copy "Answer to this question is required" as as shown in this UI
mockupsbeta
Screen Shot 2023-12-01 at 2.36.45 PM.png (1×1 px, 266 KB)
Screen Shot 2023-12-01 at 2.43.57 PM.png (1×2 px, 357 KB)
Screen Shot 2023-12-01 at 2.37.07 PM.png (1×2 px, 373 KB)
Screen Shot 2023-12-01 at 2.43.57 PM.png (1×2 px, 357 KB)

Checked in commons wmf.9 - below are the screenshots with blue links (as per updated design):

Screen Shot 2023-12-13 at 2.41.52 PM.png (1×2 px, 272 KB)
Screen Shot 2023-12-13 at 2.41.38 PM.png (1×2 px, 291 KB)