Page MenuHomePhabricator

[L] Redesign choosing Creative Commons license for own work
Closed, ResolvedPublic

Description

Context
As part of improving the release rights step of Upload Wizard on Commons T347298, we will make UX improvements to the licensing step for own work.

This ticket is a subtask for T347596

Check latest prototype for estimation only (check the UI link provided below for implementation)

Link to UI

Acceptance Criteria

  • Remove assigning a license by default
  • Replace the existing statement and associated links (like 'chose a different license") with a question shown in UI.
  • Simplify the list of license that users can choose from i.e. only show the latest license types (total 3 licenses as shown in the UI)
  • Show appropriate icons for each license
  • Provide a learn more link for each license that direct to the license explanation on creative commons website
  • Provide additional help text under each license
  • The order of the license as shown in UI
  • The next button should be active all the time
  • If the user clicks on the Next button without selecting a license (scroll up to the question if off the screen) and show the error as shown in this UI
  • Campaigns could chose to only show the license/s that are needed for campaign pre-select as shown in this example.

Event Timeline

Open questions:

  • Is it okay to remove older license
  • Look into how cutting down options may affect campaign workflows
MarkTraceur renamed this task from Redesign choosing Creative Commons license for own work to [L] Redesign choosing Creative Commons license for own work.Oct 4 2023, 5:02 PM

Change 966197 had a related patch set uploaded (by Cparle; author: Cparle):

[mediawiki/extensions/UploadWizard@master] Change how licences are chosen for "current work"

https://gerrit.wikimedia.org/r/966197

Sneha updated the task description. (Show Details)

@Sneha some questions on the text displayed to the user here

Each license currently has associated text, which we need to change. In the current patch (above) I've just updated existing i18n messages for English, but in order to make sure changes propagate across all languages it's considered best practise to add new message keys

So for example currently the message for cc-zero looks like this
"mwe-upwiz-license-cc-zero": "Creative Commons CC0 Waiver (release all rights, like public domain: [$2 legal code])"

My new message will need to be something like this:
"mwe-upwiz-license-cc-zero-1": "Creative Commons CC0 Waiver $3 [$2 (learn more)]" (note that $3 will be replaced with the icon(s))

So my first question is - ought I replace all base licence msgs with new keys in the new format? Rather than just the default ones that you can see on the Miro board?

(fwiw I'm guessing the answer is "yes", but just wanted to make sure)


Next - about the explanation text that's shown in grey. We already have explanation text for each license, so for example the old text for CC0 is (Anyone may use, share or remix this work, with no restrictions at all.) whereas your text is (release all rights, anyone is free to use this work in any way). I know you have user-tested some of the text, but I'm not sure if you've user-tested the license explanations - if you have I think the obvious thing is to change just the English text rather than having a new message for the explanations too, if not I think we can probably just stick with the old explanations. What do you think?

(you can see the explanation text for all the licenses here https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/UploadWizard/+/refs/heads/master/i18n/en.json if you search for '-explain')

@Cparle for the first question yes it makes sense to update the message keys. The term "legal code" is less inviting than "learn more" and also if we are going to use the subtext we don't need explanations here.

For the second question, I see all the explanations in the link you shared however they have some some terms that users may not understand and area also longer in size. The copy in the wireframes was tested and most people read all of them and understood. Unless it is not accurate legally then I can change them. However, I am wondering where these messages (the one in the link) show up in the UI as I don't see them?

Sneha updated the task description. (Show Details)

Change 966197 abandoned by Cparle:

[mediawiki/extensions/UploadWizard@master] Change how licences are chosen for "current work"

Reason:

pushing to dev branch instead

https://gerrit.wikimedia.org/r/966197

Currently the explanations get shown only for the default licence, see the screenshot

image.png (126×905 px, 27 KB)

Campaigns can choose different default licenses

Change 966197 restored by Cparle:

[mediawiki/extensions/UploadWizard@master] Change how licences are chosen for "current work"

https://gerrit.wikimedia.org/r/966197

Change 966197 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Change how licences are chosen for "own work"

https://gerrit.wikimedia.org/r/966197

Change 968694 had a related patch set uploaded (by Cparle; author: Cparle):

[mediawiki/extensions/UploadWizard@master] Minor changes (visual plus text)

https://gerrit.wikimedia.org/r/968694

Change 968694 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Minor changes (visual plus text)

https://gerrit.wikimedia.org/r/968694

A few minor design fixes:

  • The spacing below the separator line should be same as above the line.
  • Increase the spacing between the licenses.. it can be same as the distance between question and license.
  • "Learn more" font size should be min 12px (I think its 11 right now a tad bit smaller)
  • The icons look pixelated. But I see that it is the same in current upload wizard.
  • When we add more questions we will need to add number to the font of this question. How can we make sure that gets done later?

@Etonkovidova

Change 968997 had a related patch set uploaded (by Cparle; author: Cparle):

[mediawiki/extensions/UploadWizard@master] Minor visual changes

https://gerrit.wikimedia.org/r/968997

Change 968997 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Minor visual changes

https://gerrit.wikimedia.org/r/968997

The spacing below the separator line should be same as above the line.

Done

Increase the spacing between the licenses.. it can be same as the distance between question and license.

Done

"Learn more" font size should be min 12px (I think its 11 right now a tad bit smaller)

Done

The icons look pixelated. But I see that it is the same in current upload wizard

No action required, I think

When we add more questions we will need to add number to the font of this question. How can we make sure that gets done later?

I thought that we could make this an ordered list in the next iteration? Does that make sense (cc @mfossati @matthiasmullie)
edit: I could make it an ordered list now if you like, but then it'd be numbered even though there's only one item

When we add more questions we will need to add number to the font of this question. How can we make sure that gets done later?

I thought that we could make this an ordered list in the next iteration? Does that make sense (cc @mfossati @matthiasmullie)
edit: I could make it an ordered list now if you like, but then it'd be numbered even though there's only one item

I was thinking the same 😄

Thanks @Cparle

Please also note a slight grammatical change to the question copy - add "a" before the words "free license" (based on Marco's feedback on slack)

Checked the adjustments mentioned by @Sneha in https://phabricator.wikimedia.org/T347756#9281570

before adjustmentsafter
new_release rights 2023-10-25.png (1×1 px, 355 KB)
Screen Shot 2023-10-26 at 1.41.26 PM.png (1×2 px, 408 KB)

@Sneha - I noticed that figma mockups use normal progressive buttons (e.g. figma link from this task description whereas UploadWizard uses a primary button for Next action. It's consistent with the current UploadWizard, so I assume there won't be any changes.

Thanks for pointing that out @Etonkovidova We can keep it as primary progressive. I will update it in Figma.

Could an option for screenshots of Wikimedia sites be added somewhere in the wizard?

I think that the choice to not have a default license for own work is a really bad decision. See discussion here.

I think maybe they should choose one and it becomes their default

Change 972430 had a related patch set uploaded (by Cparle; author: Cparle):

[mediawiki/extensions/UploadWizard@master] Fix typo

https://gerrit.wikimedia.org/r/972430

Change 972430 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Fix typo

https://gerrit.wikimedia.org/r/972430

Checked on common wmf.5 - the typo (https://gerrit.wikimedia.org/r/972430) is fixed and all looks as expected.

I think maybe they should choose one and it becomes their default

Thx, @aliu - I re-tested default license selection. A user's choice of license will be remembered (as you mentioned). Also, a user may select a license type in Special:Preferences-Upload Wizard; that selection works as before.

Thanks! I presume no one wants another option for screenshots of Wikimedia sites?

Thanks! I presume no one wants another option for screenshots of Wikimedia sites?

Hi, @aliu - can you clarify what that option would do? In which UploadWizard step should it be present?

Just another license in the license selector except after selecting, you'll get a text field or nested selector for the Wikimedia Wiki the screenshot is from

Just another license in the license selector except after selecting, you'll get a text field or nested selector for the Wikimedia Wiki the screenshot is from

@aliu - thanks for the clarification. You may want to file a phab task for that, so your comment won't be lost - thx, again!