Page MenuHomePhabricator

Enable wgMinervaEnableSiteNotice for newiki
Closed, ResolvedPublic

Description

We're currently doing a edit-a-thon like event in Nepali Wiki and majority of our users use mobile phones. It would be useful to reach them.

Event Timeline

Anoop changed the subtype of this task from "Feature Request" to "Task".
Frostly changed the subtype of this task from "Task" to "Administrative Request".Oct 2 2023, 4:04 AM
Anoop changed the subtype of this task from "Administrative Request" to "Task".Oct 2 2023, 5:13 AM
Anoop added subscribers: Frostly, Anoop.

@Frostly , this is not a administrative request, so i am setting it back as task

In the future, please always follow https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes when requesting such site configuration changes. Please provide link to community discussion. Thanks!

I actually don't think this requires any community consensus. Why are notices selectively hidden? I believe wgMinervaEnableSiteNotice was supposed to be temporary flag. If a community doesn not want to (for whatever reason) show notices on mobile there's already nomobile class which I believe works.

@Jdlrobson. I think the logic of $wgMinervaEnableSiteNotice (on wikimedia) should have been in the reverse. That's default true, and any community who wants opt out should request so.

I actually don't think this requires any community consensus. Why are notices selectively hidden? I believe wgMinervaEnableSiteNotice was supposed to be temporary flag. If a community doesn not want to (for whatever reason) show notices on mobile there's already nomobile class which I believe works.

Imo as a norm site configuration changes should have community consensus.

@Jdlrobson. I think the logic of $wgMinervaEnableSiteNotice (on wikimedia) should have been in the reverse. That's default true, and any community who wants opt out should request so.

it seems T269173: Migrate default of $wgMinervaEnableSiteNotice to true per minervasitenotice supposed to be disabled until the banners are mobile friendly

@Anoop @Ammarpad We already discussed this as part of the edit-a-thon. So this should be ready to go. Thanks

@Anoop @Ammarpad We already discussed this as part of the edit-a-thon. So this should be ready to go. Thanks

Please add discussion explaining enabling site notice on mobile devices, as I can see there no mention of enabling minervasitenotice

I actually don't think this requires any community consensus. Why are notices selectively hidden? I believe wgMinervaEnableSiteNotice was supposed to be temporary flag. If a community doesn not want to (for whatever reason) show notices on mobile there's already nomobile class which I believe works.

@Ammarpad, historically site notices have only run on desktop. Many of them were not tested on mobile and break display there, so one of the requirements was that it was intentional that communities discuss this before switching over.

It was meant to be temporary to make Minerva consistent with other skins. I think ideally site notices should be configurable on a per skin basis, inside MediaWIki core if we want to continue to support this behaviour.

If I recall I worked on this with @Tgr who is now in the MediaWiki Platform Team who would probably be in a better position to determine how site notices should be more configurable per skin and whether the Minerva default should be reconsidered at this point in time, particularly now many communities need this functionality (e.g. those using WikidataPageBanner, Wikifunctions) and now that the switchover to IP masking will add more noise to this area on the page. I suggest making a ticket tagged MediaWiki-Platform-Team if that seems like a good idea.

Change 963799 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[operations/mediawiki-config@master] Enable Minerva site notice for Nepali Wikipedia (newiki)

https://gerrit.wikimedia.org/r/963799

Change 963799 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable Minerva site notice for Nepali Wikipedia (newiki)

https://gerrit.wikimedia.org/r/963799

Mentioned in SAL (#wikimedia-operations) [2023-10-05T20:13:16Z] <thcipriani@deploy2002> Started scap: Backport for [[gerrit:963799|Enable Minerva site notice for Nepali Wikipedia (newiki) (T347814)]]

Mentioned in SAL (#wikimedia-operations) [2023-10-05T20:14:31Z] <thcipriani@deploy2002> ammarpad and thcipriani: Backport for [[gerrit:963799|Enable Minerva site notice for Nepali Wikipedia (newiki) (T347814)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-10-05T20:22:14Z] <thcipriani@deploy2002> Finished scap: Backport for [[gerrit:963799|Enable Minerva site notice for Nepali Wikipedia (newiki) (T347814)]] (duration: 08m 57s)

Ammarpad claimed this task.