Page MenuHomePhabricator
Create Task
Maniphest T347837

Deploy new purged version with UDS feature
Closed, ResolvedPublic
Actions

Description

Deploy new purged version with the UDS feature (https://gerrit.wikimedia.org/r/c/operations/software/purged/+/957362).

Roughly the list of activities should be:

  • Build the package for bullseye and import in APT repository
  • Upgrade on single cp host for test (cp4040)
    • Set profile::cache::purge::frontend_addr: "/run/varnish-privileged.socket" on test host (cp4040) and apply puppet
    • restart purged service on test host (cp4040) monitor that PURGE requests will be handled correctly by the new varnish configuration (T347192)
  • Upgrade purged package on all bullseye cp hosts: sudo cumin 'A:cp and A:bullseye' 'apt-get install -y purged=0.21+deb11u1'
  • Rebuild the package (with different versioning) for bookworm
  • Upgrade purged package on all bookworm cp hosts: sudo cumin 'A:cp and A:bookworm' 'apt-get install -y purged=0.21+deb12u1' (only cp4052)
  • Modify the purged systemd unit to switch to UDS socket (puppet)
  • Apply profile::cache::purge::frontend_addr: "/run/varnish-privileged.socket" to all cache hosts. purged service is restarted as puppet applies the systemd unit changes.
    • ulsfo
    • codfw
    • eqsin
    • eqiad
    • drmrs
    • esams
  • Update eventual documentation about this

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
purged: use unix socket for varnish in all DCs.operations/puppetproduction+2 -12
purged: use unix socket for varnish in drmrsoperations/puppetproduction+2 -0
purged: use unix socket for varnish in eqiadoperations/puppetproduction+2 -0
purged: use unix socket for varnish in eqiadoperations/puppetproduction+2 -0
purged: use unix socket for varnish in eqsinoperations/puppetproduction+2 -0
purged: use unix socket for varnish in codfwoperations/puppetproduction+2 -0
purged: use unix socket for varnish in ulsfooperations/puppetproduction+2 -1
purged: switch to unix socket for varnish requestsoperations/puppetproduction+2 -3
Release 0.21+deb12u1 for bookwormoperations/software/purgedmaster+6 -0
purged: parametrize purged frontend and backend addressoperations/puppetproduction+11 -3
Customize query in gerrit

Related Objects

Event Timeline

Fabfur created this task.Oct 2 2023, 9:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2023, 9:28 AM
Vgutierrez triaged this task as Medium priority.Oct 2 2023, 9:56 AM
Vgutierrez moved this task from Backlog to Actively Servicing on the Traffic board.
Stashbot added a comment.Oct 2 2023, 10:34 AM

Mentioned in SAL (#wikimedia-operations) [2023-10-02T10:34:17Z] <fabfur> depool cp4040 to test new purged version (T347837)

Stashbot added a comment.Oct 2 2023, 10:49 AM

Mentioned in SAL (#wikimedia-operations) [2023-10-02T10:49:18Z] <fabfur> swap purged on cp4040 to use UDS instead of TCP for Varnish (T347837)

Fabfur added a comment.Oct 2 2023, 11:02 AM

Tests on cp4040.ulsfo.wmnet shows that the new purged version connecting to the proper Varnish socket correctly processes the PURGE requests. An example snippet from varnishlog:

*   << Request  >> 588265619
-   ReqHeader      User-Agent: purged
-   ReqHeader      X-Client-IP: 0.0.0.0
-   RespStatus     204
-   RespReason     No Content
-   RespReason     Purged

*   << Request  >> 589387751
-   ReqHeader      User-Agent: purged
-   ReqHeader      X-Client-IP: 0.0.0.0
-   RespStatus     204
-   RespReason     No Content
-   RespReason     Purged

The new X-Client-IP (was 127.0.0.1) shows that purged is using UDS and ACLs in Varnish VCL are allowing that.

gerritbot added a comment.Oct 2 2023, 1:25 PM

Change 962611 had a related patch set uploaded (by Fabfur; author: Fabfur):

[operations/puppet@production] purged: parametrize purged frontend and backend address

https://gerrit.wikimedia.org/r/962611

gerritbot added a project: Patch-For-Review.Oct 2 2023, 1:25 PM
Fabfur updated the task description. (Show Details)Oct 2 2023, 1:39 PM
gerritbot added a comment.Oct 2 2023, 2:19 PM

Change 962611 merged by Fabfur:

[operations/puppet@production] purged: parametrize purged frontend and backend address

https://gerrit.wikimedia.org/r/962611

Stashbot added a comment.Oct 2 2023, 2:23 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-02T14:23:49Z] <fabfur> importing into bullseye-wikimedia package purged_0.21+deb11u1_amd64 (T347837)

Fabfur updated the task description. (Show Details)Oct 2 2023, 2:27 PM
Fabfur updated the task description. (Show Details)
Maintenance_bot removed a project: Patch-For-Review.Oct 2 2023, 2:30 PM
Stashbot added a comment.Oct 2 2023, 2:51 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-02T14:51:35Z] <fabfur> upgrade purged package to version 0.21+deb11u1 on all cp hosts (T347837)

Fabfur updated the task description. (Show Details)Oct 2 2023, 2:59 PM
Fabfur updated the task description. (Show Details)
gerritbot added a comment.Oct 2 2023, 3:28 PM

Change 962635 had a related patch set uploaded (by Fabfur; author: Fabfur):

[operations/software/purged@master] Repackage for bookworm

https://gerrit.wikimedia.org/r/962635

gerritbot added a project: Patch-For-Review.Oct 2 2023, 3:28 PM
gerritbot added a comment.Oct 2 2023, 3:59 PM

Change 962635 merged by Fabfur:

[operations/software/purged@master] Release 0.21+deb12u1 for bookworm

https://gerrit.wikimedia.org/r/962635

Fabfur mentioned this in rOSPU06dbaef5dff9: Release 0.21+deb12u1 for bookworm.Oct 2 2023, 3:59 PM
Stashbot added a comment.Oct 2 2023, 4:06 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-02T16:06:57Z] <fabfur> importing into bookworm-wikimedia package purged_0.21+deb12u1_amd64 (T347837)

Fabfur updated the task description. (Show Details)Oct 2 2023, 4:08 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 2 2023, 4:10 PM
Stashbot added a comment.Oct 2 2023, 5:00 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-02T17:00:14Z] <fabfur> upgrade purged package to version 0.21+deb12u1 cp4052 (bookworm) (T347837)

Fabfur updated the task description. (Show Details)Oct 2 2023, 5:01 PM
gerritbot added a comment.Oct 3 2023, 8:24 AM

Change 963002 had a related patch set uploaded (by Fabfur; author: Fabfur):

[operations/puppet@production] purged: switch to unix socket for varnish requests

https://gerrit.wikimedia.org/r/963002

gerritbot added a project: Patch-For-Review.Oct 3 2023, 8:24 AM
gerritbot added a comment.Oct 3 2023, 8:30 AM

Change 963002 abandoned by Fabfur:

[operations/puppet@production] purged: switch to unix socket for varnish requests

Reason:

https://gerrit.wikimedia.org/r/963002

Maintenance_bot removed a project: Patch-For-Review.Oct 3 2023, 8:30 AM
gerritbot added a comment.Oct 3 2023, 8:33 AM

Change 963004 had a related patch set uploaded (by Fabfur; author: Fabfur):

[operations/puppet@production] purged: use unix socket for varnish in ulsfo

https://gerrit.wikimedia.org/r/963004

gerritbot added a project: Patch-For-Review.Oct 3 2023, 8:34 AM
Fabfur updated the task description. (Show Details)Oct 3 2023, 8:34 AM
gerritbot added a comment.Oct 3 2023, 11:52 AM

Change 963004 merged by Fabfur:

[operations/puppet@production] purged: use unix socket for varnish in ulsfo

https://gerrit.wikimedia.org/r/963004

Stashbot added a comment.Oct 3 2023, 11:54 AM

Mentioned in SAL (#wikimedia-operations) [2023-10-03T11:54:34Z] <fabfur> merged https://gerrit.wikimedia.org/r/c/operations/puppet/+/963004 (T347837). purged daemon will be restarted by puppet in ulsfo in the next 30m

Fabfur updated the task description. (Show Details)Oct 3 2023, 11:54 AM
gerritbot added a comment.Oct 3 2023, 12:03 PM

Change 963020 had a related patch set uploaded (by Fabfur; author: Fabfur):

[operations/puppet@production] purged: use unix socket for varnish in codfw

https://gerrit.wikimedia.org/r/963020

gerritbot added a comment.Oct 3 2023, 1:52 PM

Change 963020 merged by Fabfur:

[operations/puppet@production] purged: use unix socket for varnish in codfw

https://gerrit.wikimedia.org/r/963020

Stashbot added a comment.Oct 3 2023, 2:01 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-03T14:01:51Z] <fabfur> merged https://gerrit.wikimedia.org/r/c/operations/puppet/+/963020 (T347837). purged daemon will be restarted by puppet in codfw in the next 30m

Fabfur updated the task description. (Show Details)Oct 3 2023, 2:04 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 3 2023, 2:11 PM
Fabfur updated the task description. (Show Details)Oct 3 2023, 2:16 PM
Fabfur updated the task description. (Show Details)Oct 3 2023, 2:35 PM
gerritbot added a comment.Oct 3 2023, 2:39 PM

Change 963081 had a related patch set uploaded (by Fabfur; author: Fabfur):

[operations/puppet@production] purged: use unix socket for varnish in eqsin

https://gerrit.wikimedia.org/r/963081

gerritbot added a project: Patch-For-Review.Oct 3 2023, 2:39 PM
gerritbot added a comment.Oct 3 2023, 8:16 PM

Change 963081 merged by Fabfur:

[operations/puppet@production] purged: use unix socket for varnish in eqsin

https://gerrit.wikimedia.org/r/963081

Stashbot added a comment.Oct 3 2023, 8:16 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-03T20:16:57Z] <fabfur> merged https://gerrit.wikimedia.org/r/c/operations/puppet/+/963081 (T347837). purged daemon will be restarted by puppet in eqsin in the next 30m

Fabfur updated the task description. (Show Details)Oct 3 2023, 8:17 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 3 2023, 8:30 PM
gerritbot added a comment.Oct 4 2023, 1:20 PM

Change 963302 had a related patch set uploaded (by Fabfur; author: Fabfur):

[operations/puppet@production] purged: use unix socket for varnish in eqiad

https://gerrit.wikimedia.org/r/963302

gerritbot added a project: Patch-For-Review.Oct 4 2023, 1:20 PM
gerritbot added a comment.Oct 4 2023, 1:24 PM

Change 963302 abandoned by Fabfur:

[operations/puppet@production] purged: use unix socket for varnish in eqiad

Reason:

https://gerrit.wikimedia.org/r/963302

gerritbot added a comment.Oct 4 2023, 1:25 PM

Change 963147 had a related patch set uploaded (by Fabfur; author: Fabfur):

[operations/puppet@production] purged: use unix socket for varnish in eqiad

https://gerrit.wikimedia.org/r/963147

gerritbot added a comment.Oct 4 2023, 1:26 PM

Change 963147 merged by Fabfur:

[operations/puppet@production] purged: use unix socket for varnish in eqiad

https://gerrit.wikimedia.org/r/963147

Stashbot added a comment.Oct 4 2023, 1:27 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-04T13:27:36Z] <fabfur> merged https://gerrit.wikimedia.org/r/c/operations/puppet/+/963147 (T347837). purged daemon will be restarted by puppet in eqiad in the next 30m

Fabfur updated the task description. (Show Details)Oct 4 2023, 1:28 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 4 2023, 1:30 PM
gerritbot added a comment.Oct 4 2023, 2:00 PM

Change 963321 had a related patch set uploaded (by Fabfur; author: Fabfur):

[operations/puppet@production] purged: use unix socket for varnish in drmrs

https://gerrit.wikimedia.org/r/963321

gerritbot added a project: Patch-For-Review.Oct 4 2023, 2:00 PM
gerritbot added a comment.Oct 4 2023, 2:23 PM

Change 963321 merged by Fabfur:

[operations/puppet@production] purged: use unix socket for varnish in drmrs

https://gerrit.wikimedia.org/r/963321

Stashbot added a comment.Oct 4 2023, 2:24 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-04T14:24:01Z] <fabfur> merged https://gerrit.wikimedia.org/r/c/operations/puppet/+/963321 (T347837). purged daemon will be restarted by puppet in drmrs in the next 30m

Fabfur renamed this task from Repackage purged for bullseye and bookworm to Deploy new purged version with UDS feature.Oct 4 2023, 2:25 PM
Fabfur updated the task description. (Show Details)
Maintenance_bot removed a project: Patch-For-Review.Oct 4 2023, 2:30 PM
gerritbot added a comment.Oct 4 2023, 2:34 PM

Change 963326 had a related patch set uploaded (by Fabfur; author: Fabfur):

[operations/puppet@production] purged: use unix socket for varnish in all DCs.

https://gerrit.wikimedia.org/r/963326

gerritbot added a project: Patch-For-Review.Oct 4 2023, 2:34 PM
Stashbot added a comment.Oct 4 2023, 4:59 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-04T16:59:54Z] <fabfur> merged https://gerrit.wikimedia.org/r/c/operations/puppet/+/963326 (T347837). purged daemon will be restarted by puppet in esams in the next 30m

gerritbot added a comment.Oct 4 2023, 5:00 PM

Change 963326 merged by Fabfur:

[operations/puppet@production] purged: use unix socket for varnish in all DCs.

https://gerrit.wikimedia.org/r/963326

Fabfur closed this task as Resolved.Oct 4 2023, 5:00 PM
Fabfur updated the task description. (Show Details)
Fabfur updated the task description. (Show Details)
Maintenance_bot removed a project: Patch-For-Review.Oct 4 2023, 5:10 PM
Stashbot added a comment.Oct 12 2023, 9:40 AM

Mentioned in SAL (#wikimedia-operations) [2023-10-12T09:40:20Z] <fabfur> repooling cp4040 (depooled for T347837 and forgot)

gerritbot added a comment.Sep 17 2024, 3:45 PM

Change #1073482 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/WikimediaCampaignEvents@master] Display error message to user when API issue occurs

https://gerrit.wikimedia.org/r/1073482

gerritbot added a project: Patch-For-Review.Sep 17 2024, 3:45 PM
Daimona removed a project: Patch-For-Review.Sep 19 2024, 12:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits