Page MenuHomePhabricator

Talk page empty state appears on pages with __NONEWSECTIONLINK__
Closed, ResolvedPublic

Description

Talk page empty state appears on pages with __NONEWSECTIONLINK__. It shouldn't (it should only appear when the "New topic" tab is present).

(reported at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#c-1989-20231001142900-Pop-up_on_talk_pages)

Example

image.png (2×3 px, 481 KB)

Event Timeline

Change 962634 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] HookUtils: Fix checking page props

https://gerrit.wikimedia.org/r/962634

Change 962634 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] HookUtils: Fix checking page props

https://gerrit.wikimedia.org/r/962634

Change 962213 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.41.0-wmf.28] HookUtils: Fix checking page props

https://gerrit.wikimedia.org/r/962213

Change 962213 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.41.0-wmf.28] HookUtils: Fix checking page props

https://gerrit.wikimedia.org/r/962213

Mentioned in SAL (#wikimedia-operations) [2023-10-02T21:07:45Z] <kindrobot@deploy2002> Started scap: Backport for [[gerrit:962212|Ignore <!--comment--> only site notices (T347645)]], [[gerrit:962213|HookUtils: Fix checking page props (T347878)]], [[gerrit:962214|Fix diff title escaping (T347578)]], [[gerrit:962215|Diff: Add missing .mw-diff-inline-moved selector]]

Mentioned in SAL (#wikimedia-operations) [2023-10-02T21:08:59Z] <kindrobot@deploy2002> kindrobot and matmarex: Backport for [[gerrit:962212|Ignore <!--comment--> only site notices (T347645)]], [[gerrit:962213|HookUtils: Fix checking page props (T347878)]], [[gerrit:962214|Fix diff title escaping (T347578)]], [[gerrit:962215|Diff: Add missing .mw-diff-inline-moved selector]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-10-02T21:17:51Z] <kindrobot@deploy2002> Finished scap: Backport for [[gerrit:962212|Ignore <!--comment--> only site notices (T347645)]], [[gerrit:962213|HookUtils: Fix checking page props (T347878)]], [[gerrit:962214|Fix diff title escaping (T347578)]], [[gerrit:962215|Diff: Add missing .mw-diff-inline-moved selector]] (duration: 10m 06s)

Fixed and deployed