Page MenuHomePhabricator
Create Task
Maniphest T347925

[Task] Reading controls popover support and bold / italics formatting
Closed, ResolvedPublic
Actions

Assigned To
JTannerWMF
Authored By
Seddon
Oct 3 2023, 2:36 AM
Tags
Referenced Files
F41819361: Screenshot 2024-02-08 at 3.38.03 PM
Feb 8 2024, 9:40 PM
F41819348: Screenshot 2024-02-08 at 3.36.25 PM.jpeg
Feb 8 2024, 9:40 PM
F41817600: IMG_5860.PNG
Feb 8 2024, 6:22 PM
F41817597: IMG_5859.PNG
Feb 8 2024, 6:22 PM
F41817593: IMG_5858.PNG
Feb 8 2024, 6:22 PM
F41817516: IMG_338DBA673D08-1.jpeg
Feb 8 2024, 6:22 PM
F41744996: IMG_0325.PNG
Feb 2 2024, 12:16 AM
F41744979: IMG_0326.PNG
Feb 2 2024, 12:16 AM
View All 13 Files
Subscribers
ABorbaWMF
Aklapper
JTannerWMF
Seddon
Tsevener

Description

Dependencies
T347870
T344508

Goal:
Add first formatters and connect theming popover!

Requirements:

  • Add bold, italic, and bold italic button
  • Add formatter inserts / deletions for bold, italic, and bold italic
  • Add selection states for bold, italic, and bold italic
  • Add syntax highlighting for bold, italic, and bold italic.
  • Add formatters for double tap on text.
  • Provides support for theming popover font size slider and theme change
  • Provides support for syntax highlighting toggle
  • Fix any cursor jumping
  • Confirm RTL works

Ticket UI focus

Text formatting submenuDouble tap, Syntax highlightingReading controls popover
IMG_0326.PNG (2×1 px, 307 KB)
IMG_0325.PNG (2×1 px, 461 KB)
Screenshot 2024-02-01 at 7.09.16 PM.jpeg (2×1 px, 321 KB)

Mocks
Figma

Testing Notes
Please test:

  1. Reading controls popover support (theme selection, syntax highlighting toggle, font size slider)
  2. Bold/italics syntax highlighting
  3. Bold/italics button function

Related Objects
Search...

Event Timeline

Seddon created this task.Oct 3 2023, 2:36 AM
Seddon updated the task description. (Show Details)Oct 3 2023, 2:40 AM
Seddon removed projects: Epic, iOS Release FY2023-24 (Archive).
Seddon updated the task description. (Show Details)Oct 3 2023, 3:03 AM
Seddon mentioned this in T347928: [Task] Add formatting options to NativeEditor tool bar.Oct 3 2023, 3:37 AM
Seddon mentioned this in T348072: [Sub Task] Add more text style formatting functions to NativeEditor toolbar.Oct 3 2023, 9:45 PM
Seddon mentioned this in T348073: [Sub Task] Add paragraph/header formatting functions to NativeEditor toolbar.
Seddon mentioned this in T348074: [Sub Task] Add template formatting functions.Oct 3 2023, 9:50 PM
Seddon mentioned this in T348088: [Sub Task] Add undo/redo buttons to NativeEditor.Oct 4 2023, 12:59 AM
Seddon mentioned this in T348089: [Sub Task] Add clear formatting functionality to NativeEditor.Oct 4 2023, 2:02 AM
Seddon renamed this task from [Task] Barebones implemetation of formatting toolbar to [Task] Barebones implemetation of NativeEditor.Oct 4 2023, 5:27 PM
Seddon added a subtask: T348096: [Bug] Cursor Jump Issue when Editing Text in Long Sections.
Seddon moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.Oct 13 2023, 12:15 PM
Seddon triaged this task as Low priority.Oct 13 2023, 2:12 PM
Tsevener claimed this task.Oct 31 2023, 7:04 PM
Tsevener added a project: iOS Release FY2023-24 (Archive).
Tsevener moved this task from Tasks from Product Backlog to Doing on the iOS Release FY2023-24 (Archive) board.
Tsevener moved this task from Doing to Blocked or Waiting on the iOS Release FY2023-24 (Archive) board.Nov 1 2023, 2:23 PM
Tsevener moved this task from Blocked or Waiting to Doing on the iOS Release FY2023-24 (Archive) board.Nov 3 2023, 2:48 PM
Tsevener added a comment.EditedNov 8 2023, 11:14 PM

PR: https://github.com/wikimedia/wikipedia-ios/pull/4672 - adds support for popover theme and font size

Tsevener updated the task description. (Show Details)Nov 8 2023, 11:15 PM
Tsevener updated the task description. (Show Details)EditedNov 15 2023, 5:24 AM

PR: https://github.com/wikimedia/wikipedia-ios/pull/4679 - adds syntax highlighting for bold / italics, plus syntax highlighting toggle support

Tsevener updated the task description. (Show Details)Nov 17 2023, 11:06 PM

PR: https://github.com/wikimedia/wikipedia-ios/pull/4681 - adds button selection states for bold and italic. Also adds formatting insertion and deletion upon button tap.

Tsevener added a comment.Nov 17 2023, 11:28 PM

So far I haven't seen much cursor jumping. Sometimes it jumps to the last text the user had selected, when you bring up the keyboard formatting input view, but I'm not sure if that's unexpected. Going to check this off for now and keep an eye out.

RTL mostly works. I have a fix for the expanding input accessory view orientation in T347870

Tsevener removed Tsevener as the assignee of this task.Nov 17 2023, 11:28 PM
Tsevener updated the task description. (Show Details)
Tsevener moved this task from Doing to Needs Code Review on the iOS Release FY2023-24 (Archive) board.
Tsevener subscribed.
Tsevener moved this task from Needs Code Review to Waiting for Build on the iOS Release FY2023-24 (Archive) board.Nov 28 2023, 7:18 PM
Tsevener added a comment.Nov 30 2023, 10:33 PM

Some cleanup and addressing some PR feedback here: https://github.com/wikimedia/wikipedia-ios/pull/4687

Tsevener moved this task from Waiting for Build to Needs Code Review on the iOS Release FY2023-24 (Archive) board.Nov 30 2023, 10:33 PM
Tsevener claimed this task.Dec 1 2023, 10:25 PM
Mazevedo moved this task from Needs Code Review to Waiting for Build on the iOS Release FY2023-24 (Archive) board.Dec 5 2023, 10:26 PM
Tsevener removed Tsevener as the assignee of this task.Dec 5 2023, 11:04 PM
Tsevener added a comment.EditedDec 5 2023, 11:15 PM

Can be tested in TestFlight Experimental build 7.4.6 (60). Moving to Needs Design Review.

Tsevener moved this task from Waiting for Build to Needs Design Review on the iOS Release FY2023-24 (Archive) board.Dec 5 2023, 11:17 PM
Tsevener added a comment.EditedDec 7 2023, 3:54 PM

Related bug fixes:

https://github.com/wikimedia/wikipedia-ios/pull/4692
https://github.com/wikimedia/wikipedia-ios/pull/4695

OTichonova moved this task from Needs Design Review to Needs Code Review on the iOS Release FY2023-24 (Archive) board.Dec 18 2023, 8:34 PM
Tsevener moved this task from Needs Code Review to Waiting for Build on the iOS Release FY2023-24 (Archive) board.Jan 8 2024, 11:05 PM
Tsevener raised the priority of this task from Low to Medium.Jan 19 2024, 9:31 PM
Tsevener renamed this task from [Task] Barebones implemetation of NativeEditor to [Task] Theming popover and bold / italics formatting.Feb 1 2024, 11:55 PM
Tsevener updated the task description. (Show Details)
Tsevener moved this task from Waiting for Build to Needs QA on the iOS Release FY2023-24 (Archive) board.
Tsevener updated the task description. (Show Details)
Tsevener renamed this task from [Task] Theming popover and bold / italics formatting to [Task] Reading controls popover support and bold / italics formatting.Feb 1 2024, 11:58 PM
Tsevener updated the task description. (Show Details)
Tsevener updated the task description. (Show Details)Feb 2 2024, 12:10 AM
Tsevener updated the task description. (Show Details)Feb 2 2024, 12:16 AM
Tsevener updated the task description. (Show Details)Feb 2 2024, 12:19 AM
Tsevener updated the task description. (Show Details)
Tsevener updated the task description. (Show Details)Feb 2 2024, 12:21 AM
Tsevener updated the task description. (Show Details)
ABorbaWMF moved this task from Needs QA to Ready for PM Signoff on the iOS Release FY2023-24 (Archive) board.EditedFeb 8 2024, 6:22 PM
ABorbaWMF subscribed.

Looking pretty good to me, aside from the comments below, on 7.4.7 (3162)

I noticed some oddities that I wanted to pass on:

Bold/Italics seem to work when using the buttons, but when typing in apostrophes, using the four apostrophes (e.g. ''''Bold Italics'''') does not produce the expected result.

IMG_338DBA673D08-1.jpeg (2×1 px, 458 KB)

When highlighting one word in a multi-word bold text string, selecting the bold button to remove bolding, there are some odd results. If the word is unbolded, it adds apostrophes rather than removing the bolding, resulting in bold and italics.

HighlightUnboldingPreview
IMG_5858.PNG (2×1 px, 369 KB)
IMG_5859.PNG (2×1 px, 294 KB)
IMG_5860.PNG (2×1 px, 685 KB)
Tsevener added a comment.Feb 8 2024, 9:40 PM

@ABorbaWMF

Bold/Italics seem to work when using the buttons, but when typing in apostrophes, using the four apostrophes (e.g. ''''Bold Italics'''') does not produce the expected result.

I set it up to bold and italic using five apostrophes (3 for bold, plus 2 for italics). Let me know if I set that logic up wrong though.

When highlighting one word in a multi-word bold text string, selecting the bold button to remove bolding, there are some odd results. If the word is unbolded, it adds apostrophes rather than removing the bolding, resulting in bold and italics.

Good catch, it is a bit weird. Looks like our old web editor can do this properly. I checked the Android app and their implementation matches what our native editor does.

iOS web editor

Screenshot 2024-02-08 at 3.36.25 PM.jpeg (2×1 px, 690 KB)

Android editor

Screenshot 2024-02-08 at 3.38.03 PM (2×1 px, 1 MB)

Tsevener mentioned this in T356461: Release 7.4.7.Feb 12 2024, 9:44 PM
JTannerWMF moved this task from Ready for PM Signoff to Ready for Release on the iOS Release FY2023-24 (Archive) board.Feb 13 2024, 12:02 AM
JTannerWMF closed this task as Resolved.Feb 13 2024, 8:58 PM
JTannerWMF claimed this task.
ABorbaWMF closed subtask T348096: [Bug] Cursor Jump Issue when Editing Text in Long Sections as Resolved.Feb 28 2025, 12:02 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits