Page MenuHomePhabricator

[Sub Task] Add more text style formatting functions to NativeEditor toolbar
Closed, ResolvedPublic

Description

Goal:
Add more text style formatting functions to NativeEditor toolbar

Dependencies
T347870
T344508
T347925

Requirements:

  • Add references
  • Add strikethrough
  • Add underline
  • Add subscript
  • Add superscript
  • Add comments
  • Add button selection states
  • Add buttons to text style modal
  • Add formatter inserts / deletions
  • Add syntax highlighting for styles.
  • Confirm RTL support

Mocks
Figma

Testing notes
Please test reference, strikethrough, underline, subscript, superscript, and comment syntax highlighting on native editor. Also test button function for all of these.

Engineering note
Old prototype work here should be in app > native-editor-prototype branch

Event Timeline

Seddon updated the task description. (Show Details)
Seddon renamed this task from Add more text style formatting functions to Add more text style formatting functions to NativeEditor toolbar.Oct 3 2023, 9:47 PM
Seddon updated the task description. (Show Details)
Seddon renamed this task from Add more text style formatting functions to NativeEditor toolbar to [Sub Task] Add more text style formatting functions to NativeEditor toolbar.Oct 4 2023, 12:52 AM

@Mazevedo Can you create PRs for underline (<u></u>), subscript (<sub></sub>), and superscript (<sup></sup>) support? I have already created a strikethrough PR that you can reference - you'll need to make new Objective-C formatter classes and button action extensions for each of these 3 types, but the logic for these will be very similar to what you see in that PR (I only expect the regex and the toggle starting/ending formatting strings to need changing). You'll also need to make the other PR changes that you see in the mediator and view controller for these new types.

The color of the tags should be the same green as the strikethrough (<s></s>) tags in that PR. The text within can remain the standard base formatting (i.e. black text for .light theme). You might be able to avoid some minor duplicate work if you first merge the strikethrough PR before creating your new branches off of main.

Note there's some trickiness in exposing your new Objective-C formatting classes to the rest of the project. The readme should help you here.

Thanks!

Tsevener moved this task from Doing to Ready for Development on the iOS Release FY2023-24 board.
Tsevener added a subscriber: Tsevener.
Tsevener moved this task from Doing to Ready for Development on the iOS Release FY2023-24 board.
Tsevener raised the priority of this task from Low to Medium.
Tsevener moved this task from Ready for Development to Doing on the iOS Release FY2023-24 board.
Tsevener updated the task description. (Show Details)
ABorbaWMF added a subscriber: ABorbaWMF.

Looking good from my side on 7.4.7 (3152)

JTannerWMF claimed this task.