Linter: Wikilink inside link nested inside ref nested inside efn not detected
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jonesey95
	Oct 4 2023, 2:42 PM

Project Tags

Referenced Files

None

Subscribers

Description

Steps to replicate the issue (include links if applicable):

Go to https://en.wikipedia.org/w/index.php?title=User:Jonesey95/sandbox&oldid=1178572891
Run a Linter error detection script.

What happens?:

Note that the first two instances of the wikilink inside an external link are properly detected by the Linter error detection script. The third instance is not detected.

What should have happened instead?:

The third instance of a wikilink inside an external link should be detected and reported on the Page Information page.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
This error is not an invented edge case. It existed at https://en.wikipedia.org/w/index.php?title=%C3%86olus_(1783_ship)&oldid=1167512994 and was found by WPCleaner, reported at https://en.wikipedia.org/w/index.php?title=Wikipedia:CHECKWIKI/WPC_513_dump&oldid=1178536639

The difference between the third error and the two that are detected is that it is inside a pair of ref tags that are in turn nested inside an efn template.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use unioned data-mw so linting can proceed	mediawiki/extensions/Cite	master	+35 -22

Customize query in gerrit

Related Objects

Mentioned In: T333162: Linter link-in-link error not reported when link is inside nested reference
Mentioned Here: T214241: data-mw info is clobbered by template annotations

Event Timeline

Jonesey95 created this task.Oct 4 2023, 2:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 4 2023, 2:42 PM

I found and fixed similar (and different, but still undetected) cases at:

There were a couple dozen more. I have excluded some that had essentially the same format.

MSantos added a project: Parsoid.Oct 19 2023, 2:25 PM

MSantos moved this task from Backlog to Parsoid on the MediaWiki-extensions-Linter board.

MSantos moved this task from Needs Triage to Linting on the Parsoid board.

This bug is still present. See https://en.wikipedia.org/w/index.php?title=User:Jonesey95/sandbox&oldid=1303358064

I just fixed an instance in an article at en.WP: https://en.wikipedia.org/w/index.php?title=Sue_Anderson_%28musician%29&diff=1303358099&oldid=1300333824

Sorry for taking so long to triage. The issue is more general than template efn and happens when the ref is the first node of the template. It's is a case of T214241

λ (master) echo "{{1x|1=asdf <ref>[http://www.northernmidlands.tas.gov.au/Page/Page.aspx?Page_Id=345 Northern [[Midlands (Tasmania)|Midlands]] Convict Trail.]</ref>}}" | php bin/parse.php --integrated --wt2lint
{"type":"wikilink-in-extlink","dsr":[0,149,null,null],"templateInfo":{"name":"Template:1x"},"params":[]}

λ (master) echo "{{1x|1=<ref>[http://www.northernmidlands.tas.gov.au/Page/Page.aspx?Page_Id=345 Northern [[Midlands (Tasmania)|Midlands]] Convict Trail.]</ref>}}" | php bin/parse.php --integrated --wt2lint

Change #1174532 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/Cite@master] [WIP] Clobber transclusion data-mw so linting can proceed

https://gerrit.wikimedia.org/r/1174532

gerritbot added a project: Patch-For-Review.Jul 30 2025, 7:15 PM

ABreault-WMF moved this task from Backlog to In Progress on the Content-Transform-Team (Work In Progress) board.Jul 30 2025, 7:16 PM

ABreault-WMF moved this task from In Progress to Code Review on the Content-Transform-Team (Work In Progress) board.Jul 30 2025, 9:09 PM

Change #1174532 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Use unioned data-mw so linting can proceed

https://gerrit.wikimedia.org/r/1174532

ABreault-WMF moved this task from Code Review to To Deploy on the Content-Transform-Team (Work In Progress) board.Aug 5 2025, 8:25 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 5 2025, 8:32 PM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.14; 2025-08-12).Aug 5 2025, 9:00 PM