Parent task with the complete description is: T348041.
The summary is that our current configuration uses ACAST_PS_ADVERTISE everywhere but since we will be advertising unicast IPs from bird as well, that variable name will no longer be correct. We should use the generic BIRD_IP_ADVERTISE instead so that we ascribe the correct usage to it.
The rollout of this change means that anycast-healthchecker.service will be restarted and therefore subsequently bird.service because of the systemd bindings. Thus, we have to be careful in rolling this out, making sure to disable Puppet on all hosts that use bird and roll this out progressively, with -b1 -s30 or something similar in cumin.
sukhe@cumin2002:~$ sudo cumin 'C:bird' 49 hosts will be targeted: centrallog2002.codfw.wmnet,centrallog1002.eqiad.wmnet,cloudlb[2001-2003]-dev.codfw.wmnet,cloudlb[1001-1002].eqiad.wmnet,cloudservices[2004-2005]-dev.codfw.wmnet,cloudservices[1005-1006].eqiad.wmnet,dns[1004-1006,2004-2006,3003-3004,4003-4004,5003-5004,6001-6002].wikimedia.org,doh[1001-1002,2001-2002,3003-3004,4001-4002,5001-5002,6001-6002].wikimedia.org,durum[2001-2002].codfw.wmnet,durum[6001-6002].drmrs.wmnet,durum[1001-1002].eqiad.wmnet,durum[5001-5002].eqsin.wmnet,durum[3003-3004].esams.wmnet,durum[4001-4002].ulsfo.wmnet
We will have to rename it in the following places:
modules/bird/templates/bird_anycast.conf.erb
function match_route() { return net ~ ACAST_PS_ADVERTISE; } <% if @do_ipv6 -%> function match_route6() { return net ~ ACAST6_PS_ADVERTISE; } <% end -%>
And then:
modules/bird/templates/anycast-healthchecker.conf.erb
bird_variable = ACAST_PS_ADVERTISE bird6_variable = ACAST6_PS_ADVERTISE