Page MenuHomePhabricator

Refactor LoginSignupPage benefits block to Codex
Closed, DeclinedPublic

Description

In T300273 we've introduced a dedicated benefits block in the LoginSignupPage for temporary users and also a dedicated notice box. The default benefits block was introduced long ago and uses MW add-hoc styles. LoginSignupPage::getBenefitsContainerHtml could benefit from some style/design standarisation that uses current DSG and Codex css-only components so it aligns better with our current DSG and UI lib preference.

Notes

  • The Figma specs for the temporary user benefits block assume a different Login page markup than the existing one. Some inconsistencies are the current login form margin right of 100px, the benefits block width and the breakpoint for the second column on narrow screens.
  • There's a FIXME this should probably be a template, but use a sensible language (handlebars?) comment in getPageHtml that maybe is worth to tackle first
Screenshot 2023-10-05 at 12.33.40.png (1,854×1,952 px, 286 KB)
Screenshot 2023-10-05 at 12.33.33.png (1,846×1,946 px, 385 KB)
Screenshot 2023-10-05 at 12.37.39.png (1,578×1,712 px, 260 KB)
DefaultTemporary userTemporary user spec

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Maybe it's worth to make a design review of the benefits block before accepting this issue, what do you think @RHo @JFernandez-WMF ?