Maniphest T348266

Test checkUserHelper.js
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Oct 5 2023, 4:18 PM

Tags

Referenced Files

None

Subscribers

Description

To allow adding support for Client Hints to the checkUserHelper.js script, the current script needs testing to ensure that the current behaviour works as expected. Without these tests, the changes to the script could break the summary table in a way which is not noticed.

Acceptance criteria

The checkUserHelper.js script should be tested and at least tested in all code that would be modified for the addition of Client Hints data to the table.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Split and test checkUserHelper.js	mediawiki/extensions/CheckUser	master	+1 K -289

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		kostajh	T257893 [EPIC] Support User-Agent Client Hints header in CheckUser
		Resolved		Dreamy_Jazz	T337942 Display client hint data
		Resolved		Dreamy_Jazz	T340990 Display client hint data in Special:CheckUser's CheckUser helper table
		Resolved		Dreamy_Jazz	T348266 Test checkUserHelper.js
		Resolved		Dreamy_Jazz	T345180 Implement JS testing in CheckUser

Event Timeline

Dreamy_Jazz created this task.Oct 5 2023, 4:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2023, 4:18 PM

Dreamy_Jazz added a subtask: T345180: Implement JS testing in CheckUser.Oct 5 2023, 4:18 PM

Dreamy_Jazz added a parent task: T340990: Display client hint data in Special:CheckUser's CheckUser helper table.

Change 963711 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Split and test checkUserHelper.js

https://gerrit.wikimedia.org/r/963711

gerritbot added a project: Patch-For-Review.Oct 5 2023, 4:20 PM

Change 963711 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Split and test checkUserHelper.js

https://gerrit.wikimedia.org/r/963711

Dreamy_Jazz added a project: Anti-Harassment-Team (AHaT Sprint 32 - Baseball Cap).Oct 6 2023, 12:29 PM

Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment-Team (AHaT Sprint 32 - Baseball Cap) board.

Change 963711 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Split and test checkUserHelper.js

https://gerrit.wikimedia.org/r/963711

Dreamy_Jazz closed this task as Resolved.Oct 20 2023, 3:12 PM

Dreamy_Jazz updated the task description. (Show Details)

Dreamy_Jazz moved this task from Code Review 🔍 to Done Q1 2023-2024 on the Anti-Harassment-Team (AHaT Sprint 32 - Baseball Cap) board.

Dreamy_Jazz closed subtask T345180: Implement JS testing in CheckUser as Resolved.