Page MenuHomePhabricator
Create Task
Maniphest T348281

Make the CampaignEvents database configuration use the new DatabaseVirtualDomains config
Closed, ResolvedPublic
Actions

Description

For context, see T330590. This is now the preferred way of connecting to an external database, as opposed to the current wgCampaignEventsDatabaseCluster / wgCampaignEventsDatabaseName config options.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove old CampaignEvents DB config (prod)operations/mediawiki-configmaster+0 -4
Remove old CampaignEvents DB config (beta)operations/mediawiki-configmaster+0 -2
Convert database configuration to DatabaseVirtualDomainsmediawiki/extensions/CampaignEventsmaster+17 -40
Update for the CampaignEvents virtual DB domainmediawiki/extensions/WikimediaCampaignEventsmaster+7 -16
Add virtual domain mapping for CampaignEvents (beta)operations/mediawiki-configmaster+4 -0
Add virtual domain mapping for CampaignEvents (prod)operations/mediawiki-configmaster+4 -0
Add setting to determine if CampaignEvents should use the global DBoperations/mediawiki-configmaster+11 -0
Add setting to determine if CampaignEvents should use the global DBoperations/mediawiki-configmaster+11 -0
Add virtual domain mapping for CampaignEvents (prod)operations/mediawiki-configmaster+4 -0
Add virtual domain mapping for CampaignEvents (beta)operations/mediawiki-configmaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Daimona created this task.Oct 5 2023, 9:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2023, 9:19 PM
Ladsgroup subscribed.Oct 5 2023, 9:20 PM
Ladsgroup added a parent task: T348573: All Wikimedia extensions that store their data outside the main database should use a virtual database domain.Oct 10 2023, 7:20 PM
Tgr renamed this task from Make the database configuration use the new DatabaseVirtualDomains config to Make the CampaignEvents database configuration use the new DatabaseVirtualDomains config.Oct 10 2023, 8:23 PM
Daimona moved this task from Backlog to Tech debt on the CampaignEvents board.Nov 10 2023, 5:59 PM
Daimona added a parent task: T341392: Mark the CampaignEvents extension as stable.Feb 23 2024, 4:48 PM
Daimona mentioned this in T341392: Mark the CampaignEvents extension as stable.
Daimona moved this task from Backlog to To be Estimated/Discussed on the Connection-Team board.
Daimona added a parent task: T361026: Remove the ICampaignsDatabase abstraction.Mar 26 2024, 5:38 PM
Daimona edited projects, added Connection-Team (Connection-Current-Sprint); removed Connection-Team.
Daimona claimed this task.Mar 26 2024, 6:43 PM
Daimona moved this task from Upcoming / refining 💡 to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.
gerritbot added a comment.Mar 26 2024, 7:24 PM

Change #1014595 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Convert database configuration to DatabaseVirtualDomains

https://gerrit.wikimedia.org/r/1014595

gerritbot added a project: Patch-For-Review.Mar 26 2024, 7:24 PM
gerritbot added a comment.Mar 26 2024, 9:50 PM

Change #1014620 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] Add setting to determine if CampaignEvents should use the global DB

https://gerrit.wikimedia.org/r/1014620

gerritbot added a comment.Mar 26 2024, 9:52 PM

Change #1014621 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] Add virtual domain mapping for CampaignEvents (prod)

https://gerrit.wikimedia.org/r/1014621

gerritbot added a comment.Mar 26 2024, 9:54 PM

Change #1014623 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] Add virtual domain mapping for CampaignEvents (beta)

https://gerrit.wikimedia.org/r/1014623

gerritbot added a comment.Mar 26 2024, 9:55 PM

Change #1014625 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] Remove old CampaignEvents DB config (beta)

https://gerrit.wikimedia.org/r/1014625

gerritbot added a comment.Mar 26 2024, 9:57 PM

Change #1014626 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] Remove old CampaignEvents DB config (prod)

https://gerrit.wikimedia.org/r/1014626

Daimona moved this task from Development In Progress 💻 to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.Mar 26 2024, 10:13 PM
gerritbot added a comment.Mar 27 2024, 2:07 PM

Change #1014620 merged by jenkins-bot:

[operations/mediawiki-config@master] Add setting to determine if CampaignEvents should use the global DB

https://gerrit.wikimedia.org/r/1014620

gerritbot added a comment.Mar 27 2024, 2:10 PM

Change #1014621 merged by jenkins-bot:

[operations/mediawiki-config@master] Add virtual domain mapping for CampaignEvents (prod)

https://gerrit.wikimedia.org/r/1014621

gerritbot added a comment.Mar 27 2024, 2:10 PM

Change #1014623 merged by jenkins-bot:

[operations/mediawiki-config@master] Add virtual domain mapping for CampaignEvents (beta)

https://gerrit.wikimedia.org/r/1014623

gerritbot added a comment.Mar 27 2024, 2:16 PM

Change #1015042 had a related patch set uploaded (by Dreamy Jazz; author: Daimona Eaytoy):

[operations/mediawiki-config@master] Add setting to determine if CampaignEvents should use the global DB

https://gerrit.wikimedia.org/r/1015042

gerritbot added a comment.Mar 27 2024, 2:20 PM

Change #1015043 had a related patch set uploaded (by Dreamy Jazz; author: Daimona Eaytoy):

[operations/mediawiki-config@master] Add virtual domain mapping for CampaignEvents (prod)

https://gerrit.wikimedia.org/r/1015043

gerritbot added a comment.Mar 27 2024, 2:21 PM

Change #1015044 had a related patch set uploaded (by Dreamy Jazz; author: Daimona Eaytoy):

[operations/mediawiki-config@master] Add virtual domain mapping for CampaignEvents (beta)

https://gerrit.wikimedia.org/r/1015044

gerritbot added a comment.Mar 28 2024, 1:25 PM

Change #1015042 merged by jenkins-bot:

[operations/mediawiki-config@master] Add setting to determine if CampaignEvents should use the global DB

https://gerrit.wikimedia.org/r/1015042

gerritbot added a comment.Mar 28 2024, 1:25 PM

Change #1015043 merged by jenkins-bot:

[operations/mediawiki-config@master] Add virtual domain mapping for CampaignEvents (prod)

https://gerrit.wikimedia.org/r/1015043

gerritbot added a comment.Mar 28 2024, 1:26 PM

Change #1015044 merged by jenkins-bot:

[operations/mediawiki-config@master] Add virtual domain mapping for CampaignEvents (beta)

https://gerrit.wikimedia.org/r/1015044

Stashbot added a comment.Mar 28 2024, 1:27 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-28T13:26:56Z] <dreamyjazz@deploy1002> Started scap: Backport for [[gerrit:1015042|Add setting to determine if CampaignEvents should use the global DB (T348281)]], [[gerrit:1015043|Add virtual domain mapping for CampaignEvents (prod) (T348281)]], [[gerrit:1015044|Add virtual domain mapping for CampaignEvents (beta) (T348281)]]

Stashbot added a comment.Mar 28 2024, 1:29 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-28T13:29:25Z] <dreamyjazz@deploy1002> dreamyjazz: Backport for [[gerrit:1015042|Add setting to determine if CampaignEvents should use the global DB (T348281)]], [[gerrit:1015043|Add virtual domain mapping for CampaignEvents (prod) (T348281)]], [[gerrit:1015044|Add virtual domain mapping for CampaignEvents (beta) (T348281)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Mar 28 2024, 1:45 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-28T13:45:45Z] <dreamyjazz@deploy1002> Finished scap: Backport for [[gerrit:1015042|Add setting to determine if CampaignEvents should use the global DB (T348281)]], [[gerrit:1015043|Add virtual domain mapping for CampaignEvents (prod) (T348281)]], [[gerrit:1015044|Add virtual domain mapping for CampaignEvents (beta) (T348281)]] (duration: 18m 49s)

gerritbot added a comment.Mar 28 2024, 5:01 PM

Change #1015353 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/WikimediaCampaignEvents@master] Update for the CampaignEvents virtual DB domain

https://gerrit.wikimedia.org/r/1015353

gerritbot added a comment.Apr 2 2024, 5:14 PM

Change #1014595 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Convert database configuration to DatabaseVirtualDomains

https://gerrit.wikimedia.org/r/1014595

gerritbot added a comment.Apr 2 2024, 5:14 PM

Change #1015353 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCampaignEvents@master] Update for the CampaignEvents virtual DB domain

https://gerrit.wikimedia.org/r/1015353

Daimona mentioned this in rEWCEc94a8a570b4a: Update for the CampaignEvents virtual DB domain.Apr 2 2024, 5:34 PM
Daimona moved this task from Code Review 💬 to Blocked ⛔ on the Connection-Team (Connection-Current-Sprint) board.Apr 3 2024, 12:34 AM

All that's left to do is cleaning up the old config. I'll schedule my patches next week, as we need to wait for the train.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.26; 2024-04-09).Apr 3 2024, 2:02 PM
Daimona moved this task from Blocked ⛔ to Ready for development on the Connection-Team (Connection-Current-Sprint) board.Apr 13 2024, 12:49 AM
Daimona mentioned this in T348573: All Wikimedia extensions that store their data outside the main database should use a virtual database domain.Apr 15 2024, 4:27 PM
Daimona removed Daimona as the assignee of this task.Apr 15 2024, 5:24 PM

This should be ready now, the only thing left to do is the deployment of the two remaining config changes. I'm removing myself as assignee as I'll be OOO for the rest of the week and most of next week.

Jdforrester-WMF subscribed.May 13 2024, 2:38 PM
In T348281#9714738, @Daimona wrote:

This should be ready now, the only thing left to do is the deployment of the two remaining config changes. I'm removing myself as assignee as I'll be OOO for the rest of the week and most of next week.

Anything I can do to help move this along? Would be lovely to have T343098's tree closed.

Daimona claimed this task.May 13 2024, 3:35 PM
Daimona moved this task from Ready for development to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.
In T348281#9790527, @Jdforrester-WMF wrote:
In T348281#9714738, @Daimona wrote:

This should be ready now, the only thing left to do is the deployment of the two remaining config changes. I'm removing myself as assignee as I'll be OOO for the rest of the week and most of next week.

Anything I can do to help move this along? Would be lovely to have T343098's tree closed.

The only thing left to do here is the two cleanup patches that need to be deployed. That was first blocked on waiting for the train, then on me being OOO, and more recently on me stumbling upon this task at whatever time of the day is the farthest from a deployment window.

I've just gone ahead and scheduled them for the next window (in 4.5 hours).

gerritbot added a comment.May 13 2024, 8:10 PM

Change #1014625 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove old CampaignEvents DB config (beta)

https://gerrit.wikimedia.org/r/1014625

gerritbot added a comment.May 13 2024, 8:15 PM

Change #1014626 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove old CampaignEvents DB config (prod)

https://gerrit.wikimedia.org/r/1014626

Stashbot added a comment.May 13 2024, 8:17 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-13T20:16:59Z] <ebernhardson@deploy1002> Started scap: Backport for [[gerrit:1014626|Remove old CampaignEvents DB config (prod) (T348281)]]

Stashbot added a comment.May 13 2024, 8:19 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-13T20:19:24Z] <ebernhardson@deploy1002> ebernhardson and daimona: Backport for [[gerrit:1014626|Remove old CampaignEvents DB config (prod) (T348281)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.May 13 2024, 8:32 PM
Stashbot added a comment.May 13 2024, 8:38 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-13T20:38:13Z] <ebernhardson@deploy1002> Finished scap: Backport for [[gerrit:1014626|Remove old CampaignEvents DB config (prod) (T348281)]] (duration: 21m 14s)

Daimona moved this task from Development In Progress 💻 to QA 🐛 on the Connection-Team (Connection-Current-Sprint) board.May 13 2024, 9:04 PM

Now ready for a final round of QA, just making sure that there are no regressions related to database access in a multi-wiki setup.

Jdforrester-WMF added a comment.May 13 2024, 9:39 PM
In T348281#9792273, @Daimona wrote:

Now ready for a final round of QA, just making sure that there are no regressions related to database access in a multi-wiki setup.

<3

vaughnwalters moved this task from QA 🐛 to Product sign-off 🖌️ on the Connection-Team (Connection-Current-Sprint) board.May 14 2024, 6:12 PM
vaughnwalters subscribed.

Went through all of the extension's special pages on meta and everything is working as expected. Moving this to product sign off.

ifried closed this task as Resolved.Jun 7 2024, 10:31 PM
ifried moved this task from Product sign-off 🖌️ to Done 🏁 on the Connection-Team (Connection-Current-Sprint) board.
Daimona mentioned this in T397270: Create a script to update the country schema to the new format.Jul 23 2025, 3:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits