Page MenuHomePhabricator
Create Task
Maniphest T348287

Migrate all skin styles for .oo-ui-windowManager and .oo-ui-defaultOverlay to #mw-teleport-target
Closed, ResolvedPublic
Actions

Description

All skins that currently override the styles for .oo-ui-windowManager or .oo-ui-defaultOverlay should override them for #mw-teleport-target instead, once the OOUI nodes are moved inside the MW node. This will allow them to also style font size of dialogs etc. provided by Codex and any future libraries. See T347199: Apply skin body styles to teleported elements for context.

This work can be done at any point after T348286: Move the default OOUI overlay and window manager inside the MediaWiki teleport target (it doesn't have to be done immediately).

This task covers WMF-deployed skins (Codesearch):

Other skins (Codesearch) that could be changed in the same way (but it's not required) include: BlueSpiceCalumma, BlueSpiceDiscovery, Cosmos, DarkVector, FemiwikiSkin, GreyStuff, Metrolook, Mirage, Nimbus, Splash; and the Theme extension.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Migrate OOUI overlay styles to #mw-teleport-targetBartosz Dziewońskimediawiki/skins/CologneBluemaster+5 -6
Migrate OOUI overlay styles to #mw-teleport-targetBartosz Dziewońskimediawiki/skins/MonoBookmaster+4 -5
Migrate OOUI overlay styles to #mw-teleport-targetBartosz Dziewońskimediawiki/skins/Modernmaster+6 -8
Migrate OOUI overlay styles to #mw-teleport-targetBartosz Dziewońskimediawiki/skins/Timelessmaster+4 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

• matmarex created this task.Oct 5 2023, 11:29 PM
Restricted Application added subscribers: Lens0021, Masumrezarock100. · View Herald TranscriptOct 5 2023, 11:29 PM
• matmarex added a subtask: T348286: Move the default OOUI overlay and window manager inside the MediaWiki teleport target.Oct 5 2023, 11:30 PM
• matmarex added a parent task: T348288: Move VisualEditor overlays and window managers inside the MediaWiki teleport target, remove uses of 'vector-body'.
• matmarex mentioned this in T348289: Migrate Vector skin styles for .oo-ui-windowManager and .oo-ui-defaultOverlay to #mw-teleport-target.
• matmarex added a subtask: T348289: Migrate Vector skin styles for .oo-ui-windowManager and .oo-ui-defaultOverlay to #mw-teleport-target.
• matmarex updated the task description. (Show Details)
• matmarex mentioned this in T347199: Apply skin body styles to teleported elements.Oct 5 2023, 11:43 PM
Sgs subscribed.Oct 11 2023, 3:45 PM
• matmarex claimed this task.Oct 25 2023, 7:46 PM
Jdforrester-WMF closed subtask T348286: Move the default OOUI overlay and window manager inside the MediaWiki teleport target as Resolved.Oct 30 2023, 1:04 PM
Jdforrester-WMF closed subtask T348289: Migrate Vector skin styles for .oo-ui-windowManager and .oo-ui-defaultOverlay to #mw-teleport-target as Resolved.
Jdforrester-WMF updated the task description. (Show Details)
• matmarex added a project: Patch-For-Review.Oct 31 2023, 8:45 PM
gerritbot added a comment.Oct 31 2023, 8:45 PM

Change 970444 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/CologneBlue@master] Migrate OOUI overlay styles to #mw-teleport-target

https://gerrit.wikimedia.org/r/970444

gerritbot added a comment.Oct 31 2023, 8:45 PM

Change 970445 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Modern@master] Migrate OOUI overlay styles to #mw-teleport-target

https://gerrit.wikimedia.org/r/970445

gerritbot added a comment.Oct 31 2023, 8:46 PM

Change 970446 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/MonoBook@master] Migrate OOUI overlay styles to #mw-teleport-target

https://gerrit.wikimedia.org/r/970446

gerritbot added a comment.Oct 31 2023, 8:46 PM

Change 970447 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Timeless@master] Migrate OOUI overlay styles to #mw-teleport-target

https://gerrit.wikimedia.org/r/970447

PatchDemoBot added a comment.Oct 31 2023, 9:49 PM

Test wiki created on Patch demo by Matma Rex using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/084901cf7c/w

gerritbot added a comment.Oct 31 2023, 10:19 PM

Change 970447 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Migrate OOUI overlay styles to #mw-teleport-target

https://gerrit.wikimedia.org/r/970447

gerritbot added a comment.Oct 31 2023, 10:19 PM

Change 970446 merged by jenkins-bot:

[mediawiki/skins/MonoBook@master] Migrate OOUI overlay styles to #mw-teleport-target

https://gerrit.wikimedia.org/r/970446

gerritbot added a comment.Oct 31 2023, 10:20 PM

Change 970445 merged by jenkins-bot:

[mediawiki/skins/Modern@master] Migrate OOUI overlay styles to #mw-teleport-target

https://gerrit.wikimedia.org/r/970445

gerritbot added a comment.Oct 31 2023, 10:20 PM

Change 970444 merged by jenkins-bot:

[mediawiki/skins/CologneBlue@master] Migrate OOUI overlay styles to #mw-teleport-target

https://gerrit.wikimedia.org/r/970444

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.4; 2023-11-07).Oct 31 2023, 11:00 PM
• matmarex closed this task as Resolved.Oct 31 2023, 11:42 PM
• matmarex removed a project: Patch-For-Review.
• matmarex updated the task description. (Show Details)
• matmarex added a parent task: T350467: Vector 2022: Big font in OOUI windows and popups.Nov 3 2023, 9:32 PM
Nardog removed a parent task: T350467: Vector 2022: Big font in OOUI windows and popups.Nov 4 2023, 10:06 AM
Nardog added a subtask: T350467: Vector 2022: Big font in OOUI windows and popups.
Nardog subscribed.Nov 4 2023, 10:26 AM
• matmarex mentioned this in T350544: OOUI widgets now have huge fonts and misaligned buttons in some places.Nov 6 2023, 12:16 AM

@Nardog I'll swap this back, to group bugs caused by this work on the "opposite" side of the task tree. It's easier for me to track them that way, and I hope you don't mind.

• matmarex removed a subtask: T350467: Vector 2022: Big font in OOUI windows and popups.Nov 6 2023, 12:17 AM
• matmarex added a parent task: T350467: Vector 2022: Big font in OOUI windows and popups.
• matmarex added parent tasks: T350544: OOUI widgets now have huge fonts and misaligned buttons in some places, T350494: Overlapping page elements when previewing source edits with 2017 wikitext editor mode.
• matmarex added a parent task: T350570: Visual editor preview overlaps with Vector 2022 header.Nov 6 2023, 1:47 PM
• matmarex mentioned this in T351003: oo-ui-windowManager-floating broken on Timeless.Nov 11 2023, 12:58 AM
PatchDemoBot added a comment.Nov 16 2023, 7:30 PM

Test wiki on Patch demo by Matma Rex using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/084901cf7c/w/

Jack_who_built_the_house mentioned this in T369886: #mw-teleport-target in Monobook has low line-height.Jul 12 2024, 9:37 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits