Page MenuHomePhabricator
Create Task
Maniphest T348288

Move VisualEditor overlays and window managers inside the MediaWiki teleport target, remove uses of 'vector-body'
Closed, ResolvedPublic
Actions

Description

See T348286: Move the default OOUI overlay and window manager inside the MediaWiki teleport target.

This is the same idea, but for the custom OOUI overlays and window managers created by VisualEditor. We don't use the default ones in VE (almost?) anywhere.

We'll need to introduce some API in standalone VE to use instead of the MW teleport target, since it's not available there.

As a result, we should be able to remove the various hacky uses of 'vector-body', and maybe delete some skinStyles currently applied for Vector.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Attach content to teleport target instead of <body>, remove Vector hacksBartosz Dziewońskimediawiki/extensions/VisualEditormaster+10 -60
Attach content to teleport target instead of <body>Bartosz Dziewońskimediawiki/extensions/Citoidmaster+1 -3
Update VE core submodule to master (af9ff31db)Bartosz Dziewońskimediawiki/extensions/VisualEditormaster+1 -10
Attach content to teleport target instead of <body>Bartosz DziewońskiVisualEditor/VisualEditormaster+2 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

• matmarex created this task.Oct 5 2023, 11:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2023, 11:30 PM
• matmarex added a subtask: T348287: Migrate all skin styles for .oo-ui-windowManager and .oo-ui-defaultOverlay to #mw-teleport-target.Oct 5 2023, 11:30 PM
• matmarex mentioned this in T339058: Zebra: VE surface widgets have too much padding on Vector Zebra.Oct 5 2023, 11:33 PM
• matmarex claimed this task.Oct 25 2023, 7:46 PM
DLynch subscribed.Oct 31 2023, 4:34 PM
gerritbot added a comment.Oct 31 2023, 9:37 PM

Change 970451 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] Attach content to teleport target instead of <body>

https://gerrit.wikimedia.org/r/970451

gerritbot added a project: Patch-For-Review.Oct 31 2023, 9:37 PM

Change 970452 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Attach content to teleport target instead of <body>, remove Vector hacks

https://gerrit.wikimedia.org/r/970452

gerritbot added a comment.Oct 31 2023, 9:39 PM

Change 970453 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Citoid@master] Attach content to teleport target instead of <body>

https://gerrit.wikimedia.org/r/970453

• matmarex added a parent task: T339058: Zebra: VE surface widgets have too much padding on Vector Zebra.Oct 31 2023, 9:43 PM
• matmarex removed a parent task: T339058: Zebra: VE surface widgets have too much padding on Vector Zebra.
• matmarex added a project: Editing-team (Kanban Board).Oct 31 2023, 9:48 PM
• matmarex moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.

(discussed in the engineers' meeting today)

PatchDemoBot added a comment.Oct 31 2023, 9:49 PM

Test wiki created on Patch demo by Matma Rex using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/084901cf7c/w

gerritbot added a comment.Oct 31 2023, 10:20 PM

Change 970451 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Attach content to teleport target instead of <body>

https://gerrit.wikimedia.org/r/970451

• matmarex closed subtask T348287: Migrate all skin styles for .oo-ui-windowManager and .oo-ui-defaultOverlay to #mw-teleport-target as Resolved.Oct 31 2023, 11:42 PM
gerritbot added a comment.Nov 2 2023, 10:10 PM

Change 971325 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (af9ff31db)

https://gerrit.wikimedia.org/r/971325

gerritbot added a comment.Nov 2 2023, 10:48 PM

Change 971325 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (af9ff31db)

https://gerrit.wikimedia.org/r/971325

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.4; 2023-11-07).Nov 2 2023, 11:00 PM
DLynch mentioned this in T350494: Overlapping page elements when previewing source edits with 2017 wikitext editor mode.Nov 3 2023, 4:54 PM
gerritbot added a comment.Nov 3 2023, 5:37 PM

Change 970453 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Attach content to teleport target instead of <body>

https://gerrit.wikimedia.org/r/970453

• matmarex merged a task: T350494: Overlapping page elements when previewing source edits with 2017 wikitext editor mode.Nov 6 2023, 12:21 AM
• matmarex added subscribers: EdoAug, jhsoby.
PatchDemoBot added a comment.Nov 6 2023, 1:19 AM

Test wiki created on Patch demo by Matma Rex using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/bdce762b0e/wiki/T350544

• matmarex merged a task: T350570: Visual editor preview overlaps with Vector 2022 header.Nov 6 2023, 1:48 PM
• matmarex added subscribers: Nikerabbit, Esanders, Jdlrobson, Johannnes89.
gerritbot added a comment.Nov 6 2023, 4:26 PM

Change 970452 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Attach content to teleport target instead of <body>, remove Vector hacks

https://gerrit.wikimedia.org/r/970452

Maintenance_bot removed a project: Patch-For-Review.Nov 6 2023, 4:30 PM
• matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Nov 6 2023, 5:59 PM
• matmarex added a project: Editing QA.

For QA, please ensure that the various dialogs and popups still use the same font style as the article text, and that they do not conflict with skin elements like the sticky header. There's a long gallery of places to check in T315596 (near the bottom of my comment).

PatchDemoBot added a comment.Nov 16 2023, 7:30 PM

Test wiki on Patch demo by Matma Rex using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/084901cf7c/w/

PatchDemoBot added a comment.Nov 16 2023, 7:30 PM

Test wiki on Patch demo by Matma Rex using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/bdce762b0e/w/

VPuffetMichel moved this task from To Triage to Triaged on the VisualEditor board.Dec 14 2023, 4:08 PM
VPuffetMichel closed this task as Resolved.Feb 12 2024, 6:15 PM
VPuffetMichel edited projects, added: Skipped QA; removed: Editing QA.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits