Page MenuHomePhabricator

Undoing reset doesn't work
Closed, ResolvedPublic

Description

I can click on "reset" (radio box) so WebFonts is disabled on that particular page view. I cannot undo that, so it remains disabled unless I refresh my page.

It is the case on most if not all browsers (tested on Windows 7), so I thought it was an obvious bug and was already being taken care of, but it's still not fixed, so here is the bug report...


Version: unspecified
Severity: normal

Details

Reference
bz32830

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:02 AM
bzimport set Reference to bz32830.
bzimport added a subscriber: Unknown Object (MLST).

Seems to be browser/OS-independent, it's also on Linux.

Sorry, I could not understand it clearly. What do you meant by Undo of reset? For me, it is selecting a font name and it works for me. I can select a font , after resetting in a page.Please elaborate the expected behavior.

Ah, now I tested it with e.g. Tamil as user language, I see that it gives various fonts as options.
So the bug is only present when you are using a user language (like English) which doesn't have fonts in WebFonts. Then there aren't any font names, so you only have "reset" as a select option. I can click on reset, which disables WebFonts on that page view. I cannot unselect it to enable WebFonts again.

Try it on e.g. https://translatewiki.net/wiki/WebFonts_assessment?uselang=en where the content has various fonts, no matter which interface language you are using.

If there is only reset option and no other fonts are shown in the menu, imho this is the expected behavior. We show only reset menu since we have applied webfonts on elements with lang attribute, but userlanguage or content language does not have any fonts. We expect users to refresh the page if they want to view the page again with the webfonts.

(In reply to comment #4)

We expect users to refresh the page if they want to view the page again with the webfonts.

I don't agree on that.. It makes much more sense to be able to unselect it. I would make it a checkbox when there is only the reset option.

Please reconsider this bug.

Thanks for fixing this! I'm marking it FIXED, it was still marked INVALID.