As of yesterday, October 6 2023, the tideways_xhprof PHP extension has been archived. The suggested replacement is the "classic" xhprof extension, which has been made compatible with PHP 7 (and then 8) a few years ago. Even though we primarily use Excimer nowadays (TTBOMK), MW still supports tideways_xhprof and uses it in a bunch of places. Some of them, like ProfilerXhprof.php, already support both xhprof and tideways_xhprof, so for them this is just a matter of removing the latter. In places where we currently install tideways_xhprof (e.g., CI, vagrant), we should replace that with xhprof.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove support for tideways_xhprof | mediawiki/core | master | +5 -18 | |
| build: Add Phan stub for php-xhprof | mediawiki/core | master | +15 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T348379 Migrate use of php-tideways_xhprof to php-xhprof | |||
| Resolved | Krinkle | T400109 Ensure MediaWiki-Core-Profiler works with php-xhprof 2.x (PHP 8.3) | |||
| Open | None | T401115 Replace php-tideways_xhprof with php-xhprof in MediaWiki-Docker | |||
| Declined | None | T401255 Switch PHP 8.3 image of MediaWiki-Docker from Sury to WMF | |||
| Resolved | Krinkle | T401152 Switch wmf-config/Profiler from Tideways to XHProf |
Event Timeline
Comment Actions
Change #1057263 had a related patch set uploaded (by Legoktm; author: Legoktm):
[mediawiki/core@master] Remove support for tideways_xhprof
Comment Actions
tidways_xhprof was removed in Debian today so I noticed this as well and submitted a patch. I don't know how actively people are using tideways_xhprof, and whether it's premature to remove support if it still works on e.g. Debian stable.
Comment Actions
@Jdforrester-WMF flagged that this is very widely used in production (c.f. https://codesearch.wmcloud.org/search/?q=tideways&files=&excludeFiles=&repos=).
I think we should get a new php-xhprof package in our apt repo and probably Debian itself so we can swap everything over in a coordinated and non-breaking way.
Comment Actions
Change #1175619 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/core@master] build: Add Phan stub for php-xhprof
Comment Actions
Change #1175619 merged by jenkins-bot:
[mediawiki/core@master] build: Add Phan stub for php-xhprof
Comment Actions
Change #1057263 abandoned by Hashar:
[mediawiki/core@master] Remove support for tideways_xhprof
Comment Actions
Change #1057263 restored by Thcipriani:
[mediawiki/core@master] Remove support for tideways_xhprof