Page MenuHomePhabricator
Create Task
Maniphest T348510

Function Viewer: When non functioneer tries to connect/disconnect an implementation/tester, no "disallowed" message is shown
Closed, ResolvedPublicBUG REPORT
Actions

Description

Description

Steps to reproduce:

  1. As a user with no functioneer permissions, go to any function details page
  2. Select an implementation and connect or disconnect it

Observed behavior:

  • The action does not successfully finish, but there's no warning saying that the user did not have permission

Expected behavior (Acceptance criteria):

  • The user should be clearly notified that their action cannot be done
  • The button should probably not be enabled (related to T301670)

Devices and Design (URLs or screenshots, if applicable):

  • Desktop: ...
  • Small screens/mobile: ...

Completion checklist

Related Objects

Event Timeline

gengh created this task.Oct 10 2023, 10:17 AM
Jdforrester-WMF triaged this task as Medium priority.Oct 12 2023, 4:39 PM
Jdforrester-WMF moved this task from To Triage to Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF subscribed.Oct 30 2023, 5:36 PM

I think we now won't get into this issue, as the buttons are disabled with canApprove/canDeactivate, right?

AAlhazwani-WMF subscribed.EditedNov 15 2023, 3:33 PM
In T348510#9292559, @Jdforrester-WMF wrote:

I think we now won't get into this issue, as the buttons are disabled with canApprove/canDeactivate, right?

i tested this in prod and yes, as a user in Users group i can attempt to connect or disconnect an implementation and/or test. the action does not complete, but we do display an error message.

image.png (1×2 px, 223 KB)

see also T350927: Users group - error message on attempting to Connect implementation needs to be placed closer to the button , so we could probably mark this task as solved?

Jdforrester-WMF closed this task as Resolved.Nov 16 2023, 9:03 PM
Jdforrester-WMF assigned this task to gengh.
Jdforrester-WMF moved this task from Backlog to Verify in production on the Abstract Wikipedia team board.
In T348510#9334504, @AAlhazwani-WMF wrote:
In T348510#9292559, @Jdforrester-WMF wrote:

I think we now won't get into this issue, as the buttons are disabled with canApprove/canDeactivate, right?

i tested this in prod and yes, as a user in Users group i can attempt to connect or disconnect an implementation and/or test. the action does not complete, but we do display an error message.

image.png (1×2 px, 223 KB)

see also T350927: Users group - error message on attempting to Connect implementation needs to be placed closer to the button , so we could probably mark this task as solved?

WFM.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits