Page MenuHomePhabricator

Wrong font size in OOUI dropdowns in Vector
Closed, ResolvedPublic

Description

OOUI dropdowns in Vector (both modern and legacy) use different font size than the forms themselves. This is a regression in MW 1.41.0-wmf.30.

Steps to reproduce:

  1. Visit Special:WhatLinksHere (or any other special page with a dropdown menu)
  2. Click the dropdown handle

Vector 2022:

Vector legacy:

Other skins are not affected, for example Timeless:

QA Results - Prod

ACStatusDetails
1T348572#9251916

Event Timeline

Change 964972 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Move @font-size-base into mediawiki.skin.variables.less

https://gerrit.wikimedia.org/r/964972

Change 964976 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Move font-size declaration into skin variables

https://gerrit.wikimedia.org/r/964976

Change 964977 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Simplify teleport styles

https://gerrit.wikimedia.org/r/964977

T345766 is somewhat related, but it's also related to work on standardizing a teleport target: T347199 and simplifying our font size stack.

On long term we should do this to simplify this further: https://gerrit.wikimedia.org/r/964977

(FWIW this looks like an improvement to me but I understand it's unintended!)

Change 964976 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Move font-size declaration into skin variables

Reason:

See https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/964972

https://gerrit.wikimedia.org/r/964976

Change 964601 had a related patch set uploaded (by Jdlrobson; author: Jdrewniak):

[mediawiki/skins/Vector@wmf/1.41.0-wmf.30] Move @font-size-base into mediawiki.skin.variables.less

https://gerrit.wikimedia.org/r/964601

Change 964972 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Move @font-size-base into mediawiki.skin.variables.less

https://gerrit.wikimedia.org/r/964972

I verified in Pixel there are no UI regressions with this change but it does need to be backported.
https://pixel.wmcloud.org/reports/desktop/index.html

Change 964601 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.41.0-wmf.30] Move @font-size-base into mediawiki.skin.variables.less

https://gerrit.wikimedia.org/r/964601

Mentioned in SAL (#wikimedia-operations) [2023-10-11T08:00:02Z] <hashar@deploy2002> Synchronized php-1.41.0-wmf.30/skins/Vector: Backports for Vector styling issues T348572 T348530 (duration: 06m 16s)

hashar subscribed.

I have deployed the backport, the font size looks fine now on mediawiki.org (thanks for the test links and screenshots!)

@matmarex I forgot to thank you this morning for the very nice bug report. I have used the URLs to verify the deployment and the screenshots provided a very nice explanation of the defect I had to verify. Kudos!

Test Result - Prod

Status: ✅ PASS
Environment: mediawiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Steps to reproduce:

  1. Visit Special:WhatLinksHere (or any other special page with a dropdown menu)
  2. Click the dropdown handle

✅ AC1: The font in the drop down should be the same size as the other fonts sizes on the forms.
@Jdlrobson, these were not validated in beta, please take a look at them. I did also verify that in timeless the font is the same as other font sizes.

Vector 2022:

Vector legacy:

Edtadros added a project: Verified.

This was verified during task sync.