Page MenuHomePhabricator
Create Task
Maniphest T348669

GlobalBlocking navigation bar is double-escaped
Closed, ResolvedPublic
Actions

Description

image.png (318×1 px, 46 KB)

This is a regression from https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GlobalBlocking/+/aea54f2bbeecb2fed7bd509bf3cc9f06a04a16fe.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Don't double-escape link contentsmediawiki/extensions/GlobalBlockingwmf/1.41.0-wmf.30+3 -1
Don't double-escape link contentsmediawiki/extensions/GlobalBlockingREL1_40+3 -1
Don't double-escape link contentsmediawiki/extensions/GlobalBlockingREL1_41+3 -1
Don't double-escape link contentsmediawiki/extensions/GlobalBlockingREL1_39+3 -1
Don't double-escape link contentsmediawiki/extensions/GlobalBlockingmaster+3 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasehasharT347081 1.41.0-wmf.30 deployment blockers
 ResolvedtaaviT348669 GlobalBlocking navigation bar is double-escaped

Event Timeline

taavi created this task.Oct 11 2023, 4:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2023, 4:20 PM
gerritbot added a comment.Oct 11 2023, 4:20 PM

Change 965200 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/GlobalBlocking@master] Don't double-escape link contents

https://gerrit.wikimedia.org/r/965200

gerritbot added a project: Patch-For-Review.Oct 11 2023, 4:20 PM
taavi mentioned this in T347081: 1.41.0-wmf.30 deployment blockers.Oct 11 2023, 4:21 PM
taavi updated the task description. (Show Details)
gerritbot added a comment.Oct 11 2023, 4:30 PM

Change 965200 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Don't double-escape link contents

https://gerrit.wikimedia.org/r/965200

Maintenance_bot removed a project: Patch-For-Review.Oct 11 2023, 4:30 PM
gerritbot added a comment.Oct 11 2023, 4:31 PM

Change 965084 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/GlobalBlocking@REL1_39] Don't double-escape link contents

https://gerrit.wikimedia.org/r/965084

gerritbot added a project: Patch-For-Review.Oct 11 2023, 4:31 PM

Change 965085 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/GlobalBlocking@REL1_40] Don't double-escape link contents

https://gerrit.wikimedia.org/r/965085

gerritbot added a comment.Oct 11 2023, 4:31 PM

Change 965206 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/GlobalBlocking@REL1_41] Don't double-escape link contents

https://gerrit.wikimedia.org/r/965206

gerritbot added a comment.Oct 11 2023, 4:31 PM

Change 965207 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/GlobalBlocking@wmf/1.41.0-wmf.30] Don't double-escape link contents

https://gerrit.wikimedia.org/r/965207

gerritbot added a comment.Oct 11 2023, 4:33 PM

Change 965084 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@REL1_39] Don't double-escape link contents

https://gerrit.wikimedia.org/r/965084

gerritbot added a comment.Oct 11 2023, 4:34 PM

Change 965206 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@REL1_41] Don't double-escape link contents

https://gerrit.wikimedia.org/r/965206

gerritbot added a comment.Oct 11 2023, 4:34 PM

Change 965085 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@REL1_40] Don't double-escape link contents

https://gerrit.wikimedia.org/r/965085

gerritbot added a comment.Oct 11 2023, 4:35 PM

Change 965207 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@wmf/1.41.0-wmf.30] Don't double-escape link contents

https://gerrit.wikimedia.org/r/965207

Stashbot added a comment.Oct 11 2023, 4:36 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-11T16:36:17Z] <taavi@deploy2002> Started scap: Backport for [[gerrit:965207|Don't double-escape link contents (T348669)]]

Stashbot added a comment.Oct 11 2023, 4:37 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-11T16:37:41Z] <taavi@deploy2002> taavi: Backport for [[gerrit:965207|Don't double-escape link contents (T348669)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Oct 11 2023, 4:43 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-11T16:43:53Z] <taavi@deploy2002> Finished scap: Backport for [[gerrit:965207|Don't double-escape link contents (T348669)]] (duration: 07m 35s)

taavi closed this task as Resolved.Oct 11 2023, 4:56 PM
taavi claimed this task.
ReleaseTaggerBot added projects: MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Oct 11 2023, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 11 2023, 5:10 PM
hashar added a parent task: T347081: 1.41.0-wmf.30 deployment blockers.Oct 11 2023, 5:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits