Page MenuHomePhabricator
Create Task
Maniphest T348691

$textarea is undefined
Open, Needs TriagePublicPRODUCTION ERROR
Actions

Description

Seen on https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Polar_bear&action=edit&cm6enable=1
https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-default-1-7.0.0-1-2023.10.10?id=-NQ-G4sBt3kDdlqnJpry

stack_trace
at bindTextareaListener https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022 line 10 > eval:2:845
at disambiguator/ext.disambiguator.js/</< https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022 line 10 > eval:3:538
at fire https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022 line 10 > eval:4:699
at value https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.CodeMirror.v6.WikiEditor%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue%7Cjquery.ui&skin=vector-2022&version=1w73y:282:181
at execute https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.CodeMirror.v6.WikiEditor%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue%7Cjquery.ui&skin=vector-2022&version=1w73y:281:115
at doAction https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.wikiEditor&skin=vector-2022&version=14ys9:28:874
at jquery.wikiEditor.toolbar.js/buildTool/< https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.wikiEditor&skin=vector-2022&version=14ys9:30:882
at OO.EventEmitter.prototype.emit https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022 line 10 > eval:8:344
at OO.ui.mixin.ButtonElement.prototype.onClick https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.CodeMirror.v6.WikiEditor%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue%7Cjquery.ui&skin=vector-2022&version=1w73y:452:758
at dispatch https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.CodeMirror.v6.WikiEditor%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue%7Cjquery.ui&skin=vector-2022&version=1w73y:348:932
at add/elemData.handle https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.CodeMirror.v6.WikiEditor%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue%7Cjquery.ui&skin=vector-2022&version=1w73y:345:565

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Inject $textarea into the handler functionsmediawiki/extensions/Disambiguatormaster+15 -22
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Oct 11 2023, 8:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2023, 8:58 PM
Aklapper changed the subtype of this task from "Bug Report" to "Production Error".Oct 12 2023, 8:07 AM
Umherirrender added a project: JavaScript.Oct 12 2023, 6:49 PM
thcipriani moved this task from Untriaged to October 2023 on the Wikimedia-production-error board.Oct 26 2023, 3:22 PM
Xover subscribed.Jul 17 2024, 6:00 PM

Should this be closed? It's ~9 months old and only reported once on a beta instance (which I guess is "production", but…). It seems odd to clutter up, e.g., the WikiEditor (2010) workboard with this.

Jdlrobson added a comment.EditedJul 17 2024, 6:15 PM

The error is still occurring in production. 46 errors from multiple users on multiple projects https://logstash.wikimedia.org/goto/a48c83f66982017c22b12a88b6c60671
Definitely not beta only :-)

Screenshot 2024-07-17 at 11.15.31 AM.png (1,590×546 px, 59 KB)

Jdlrobson added a comment.Jul 17 2024, 6:16 PM

To fix this I think the textarea check needs to be moved from https://gerrit.wikimedia.org/g/mediawiki/extensions/Disambiguator/+/893c7fec8478da42831a732d55daf159d0f3cea6/modules/disambiguator/ext.disambiguator.js#9 to https://gerrit.wikimedia.org/g/mediawiki/extensions/Disambiguator/+/893c7fec8478da42831a732d55daf159d0f3cea6/modules/disambiguator/ext.disambiguator.js#112

Jdlrobson-WMF added projects: patch-welcome, User-Jdlrobson.May 13 2025, 4:04 PM
Jdlrobson-WMF subscribed.

This issue is still occurring (mostly on de.wikipedia.org) and should be an easy fix. I see Disambiguator doesn't have a maintainer but I could review this one.

gerritbot added a comment.May 14 2025, 2:22 AM

Change #1145381 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/Disambiguator@master] Inject $textarea into the handler functions

https://gerrit.wikimedia.org/r/1145381

gerritbot added a project: Patch-For-Review.May 14 2025, 2:22 AM
Samwilson removed a project: WikiEditor (2010).May 14 2025, 2:24 AM
Samwilson subscribed.

It seems odd to clutter up, e.g., the WikiEditor (2010) workboard with this.

I don't think this even needs to be on that board, it's nothing to do with WikiEditor.

I've had a go at a fix. Probably overly complicated! But it seems best to pass the $textarea object into the functions that need it.

gerritbot added a comment.May 15 2025, 6:23 PM

Change #1145381 merged by jenkins-bot:

[mediawiki/extensions/Disambiguator@master] Inject $textarea into the handler functions

https://gerrit.wikimedia.org/r/1145381

Maintenance_bot removed a project: Patch-For-Review.May 15 2025, 6:30 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 15 2025, 7:00 PM
Jdlrobson-WMF added a comment.May 23 2025, 5:14 PM

This still seems to be occurring.
The error is now InternalError: too much recursion which might provide a hint.

Bugreporter2 moved this task from Backlog to Problems on the MediaWiki-extensions-Disambiguator board.Feb 4 2026, 7:57 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits