Page MenuHomePhabricator

$textarea is undefined
Open, Needs TriagePublicPRODUCTION ERROR

Description

Seen on https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Polar_bear&action=edit&cm6enable=1
https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-default-1-7.0.0-1-2023.10.10?id=-NQ-G4sBt3kDdlqnJpry

stack_trace
at bindTextareaListener https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022 line 10 > eval:2:845
at disambiguator/ext.disambiguator.js/</< https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022 line 10 > eval:3:538
at fire https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022 line 10 > eval:4:699
at value https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.CodeMirror.v6.WikiEditor%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue%7Cjquery.ui&skin=vector-2022&version=1w73y:282:181
at execute https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.CodeMirror.v6.WikiEditor%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue%7Cjquery.ui&skin=vector-2022&version=1w73y:281:115
at doAction https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.wikiEditor&skin=vector-2022&version=14ys9:28:874
at jquery.wikiEditor.toolbar.js/buildTool/< https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.wikiEditor&skin=vector-2022&version=14ys9:30:882
at OO.EventEmitter.prototype.emit https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022 line 10 > eval:8:344
at OO.ui.mixin.ButtonElement.prototype.onClick https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.CodeMirror.v6.WikiEditor%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue%7Cjquery.ui&skin=vector-2022&version=1w73y:452:758
at dispatch https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.CodeMirror.v6.WikiEditor%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue%7Cjquery.ui&skin=vector-2022&version=1w73y:348:932
at add/elemData.handle https://en.wikipedia.beta.wmflabs.org/w/load.php?lang=en&modules=ext.CodeMirror.v6.WikiEditor%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Cvue%7Cjquery.ui&skin=vector-2022&version=1w73y:345:565

Event Timeline

Aklapper changed the subtype of this task from "Bug Report" to "Production Error".Oct 12 2023, 8:07 AM

Should this be closed? It's ~9 months old and only reported once on a beta instance (which I guess is "production", but…). It seems odd to clutter up, e.g., the WikiEditor (2010) workboard with this.

The error is still occurring in production. 46 errors from multiple users on multiple projects https://logstash.wikimedia.org/goto/a48c83f66982017c22b12a88b6c60671
Definitely not beta only :-)

Screenshot 2024-07-17 at 11.15.31 AM.png (1,590×546 px, 59 KB)

Jdlrobson-WMF subscribed.

This issue is still occurring (mostly on de.wikipedia.org) and should be an easy fix. I see Disambiguator doesn't have a maintainer but I could review this one.

Change #1145381 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/Disambiguator@master] Inject $textarea into the handler functions

https://gerrit.wikimedia.org/r/1145381

Samwilson subscribed.

It seems odd to clutter up, e.g., the WikiEditor (2010) workboard with this.

I don't think this even needs to be on that board, it's nothing to do with WikiEditor.


I've had a go at a fix. Probably overly complicated! But it seems best to pass the $textarea object into the functions that need it.

Change #1145381 merged by jenkins-bot:

[mediawiki/extensions/Disambiguator@master] Inject $textarea into the handler functions

https://gerrit.wikimedia.org/r/1145381

This still seems to be occurring.
The error is now InternalError: too much recursion which might provide a hint.