Page MenuHomePhabricator
Create Task
Maniphest T348743

Migrate PageTriage to use a virtual database domain (remove LBFactory class)
Closed, ResolvedPublic
Actions

Description

T348573: All Wikimedia extensions that store their data outside the main database should use a virtual database domain

https://codesearch.wmcloud.org/things/?q=LBFactory&files=&excludeFiles=&repos=Extension%3APageTriage

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove usage of LBFactory classmediawiki/extensions/PageTriagemaster+0 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

Novem_Linguae created this task.Oct 12 2023, 12:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2023, 12:04 PM
Novem_Linguae renamed this task from See if we need to refactor LBFactory to Migrate PageTriage to use a virtual database domain (remove LBFactory class).Oct 12 2023, 12:04 PM
Novem_Linguae added a parent task: T348573: All Wikimedia extensions that store their data outside the main database should use a virtual database domain.
Novem_Linguae updated the task description. (Show Details)
Samwalton9-WMF subscribed.Oct 12 2023, 12:06 PM

We did some work to move away from LBFactory already, worth checking what changed and what's left: T330690, T335749.

Ladsgroup subscribed.Oct 31 2023, 10:20 AM

It calls getExternalLB which shouldn't be called outside of rdbms anymore but it's only in tests (https://codesearch.wmcloud.org/things/?q=getExternalLB&files=&excludeFiles=&repos=Extension%3APageTriage) are you sure it's needed? Can you just remove that?

Novem_Linguae moved this task from Backlog to Priority technical debt on the PageTriage board.Oct 31 2023, 10:23 AM
gerritbot added a comment.Jan 28 2024, 5:14 AM

Change 993243 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] Remove usage of LBFactory class

https://gerrit.wikimedia.org/r/993243

gerritbot added a project: Patch-For-Review.Jan 28 2024, 5:14 AM
MPGuy2824 claimed this task.Jan 28 2024, 5:59 AM
MPGuy2824 moved this task from Priority technical debt to Code Review on the PageTriage board.
MPGuy2824 subscribed.
In T348743#9294287, @Ladsgroup wrote:

It calls getExternalLB which shouldn't be called outside of rdbms anymore but it's only in tests (https://codesearch.wmcloud.org/things/?q=getExternalLB&files=&excludeFiles=&repos=Extension%3APageTriage) are you sure it's needed? Can you just remove that?

The tests are passing with the patch above.

gerritbot added a comment.Jan 29 2024, 3:08 PM

Change 993243 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Remove usage of LBFactory class

https://gerrit.wikimedia.org/r/993243

Ladsgroup closed this task as Resolved.Jan 29 2024, 3:28 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 29 2024, 3:31 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.16; 2024-01-30).Jan 29 2024, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits