Page MenuHomePhabricator
Create Task
Maniphest T348973

Error: Call to a member function getKey() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?: Rarely, a normal diff is shown. Usually, a 'Fatal exception of type "Error"' happens. Sometimes the HTML body is the error message, sometimes a shorter message appears in the #bodyContent element. Once a normal diff is shown, it seems to be cached.

The same happens when trying to preview changes or to save the page.

What should have happened instead?:

Error
normalized_message
[da200b90-f7fa-4f25-958e-d2da5e700be0] /w/index.php?diff=prev&oldid=60282220&title=Sjabloon:B%C3%A8taverval   Error: Call to a member function getKey() on null
exception.trace
from /srv/mediawiki/php-1.41.0-wmf.30/extensions/Math/src/MathRenderer.php(699)
#0 /srv/mediawiki/php-1.41.0-wmf.30/extensions/Math/src/MathRenderer.php(603): MediaWiki\Extension\Math\MathRenderer->doCheck()
#1 /srv/mediawiki/php-1.41.0-wmf.30/extensions/Math/src/HookHandlers/ParserHooksHandler.php(118): MediaWiki\Extension\Math\MathRenderer->checkTeX()
#2 /srv/mediawiki/php-1.41.0-wmf.30/extensions/Math/src/HookHandlers/ParserHooksHandler.php(161): MediaWiki\Extension\Math\HookHandlers\ParserHooksHandler->mathPostTagHook(MediaWiki\Extension\Math\MathMathML, Parser)
#3 /srv/mediawiki/php-1.41.0-wmf.30/includes/HookContainer/HookContainer.php(161): MediaWiki\Extension\Math\HookHandlers\ParserHooksHandler->onParserAfterTidy(Parser, string)
#4 /srv/mediawiki/php-1.41.0-wmf.30/includes/HookContainer/HookRunner.php(2903): MediaWiki\HookContainer\HookContainer->run(string, array)
#5 /srv/mediawiki/php-1.41.0-wmf.30/includes/parser/Parser.php(1690): MediaWiki\HookContainer\HookRunner->onParserAfterTidy(Parser, string)
#6 /srv/mediawiki/php-1.41.0-wmf.30/includes/parser/Parser.php(654): Parser->internalParseHalfParsed(string, boolean, boolean)
#7 /srv/mediawiki/php-1.41.0-wmf.30/includes/content/WikitextContentHandler.php(412): Parser->parse(string, MediaWiki\Title\Title, ParserOptions, boolean, boolean, integer)
#8 /srv/mediawiki/php-1.41.0-wmf.30/includes/content/ContentHandler.php(1760): WikitextContentHandler->fillParserOutput(WikitextContent, MediaWiki\Content\Renderer\ContentParseParams, ParserOutput)
#9 /srv/mediawiki/php-1.41.0-wmf.30/includes/content/Renderer/ContentRenderer.php(47): ContentHandler->getParserOutput(WikitextContent, MediaWiki\Content\Renderer\ContentParseParams)
#10 /srv/mediawiki/php-1.41.0-wmf.30/includes/Revision/RenderedRevision.php(260): MediaWiki\Content\Renderer\ContentRenderer->getParserOutput(WikitextContent, MediaWiki\Title\Title, integer, ParserOptions, boolean)
#11 /srv/mediawiki/php-1.41.0-wmf.30/includes/Revision/RenderedRevision.php(232): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#12 /srv/mediawiki/php-1.41.0-wmf.30/includes/Revision/RevisionRenderer.php(223): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#13 /srv/mediawiki/php-1.41.0-wmf.30/includes/Revision/RevisionRenderer.php(164): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#14 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#15 /srv/mediawiki/php-1.41.0-wmf.30/includes/Revision/RenderedRevision.php(199): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#16 /srv/mediawiki/php-1.41.0-wmf.30/includes/poolcounter/PoolWorkArticleView.php(84): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#17 /srv/mediawiki/php-1.41.0-wmf.30/includes/poolcounter/PoolWorkArticleViewOld.php(66): PoolWorkArticleView->renderRevision()
#18 /srv/mediawiki/php-1.41.0-wmf.30/includes/poolcounter/PoolCounterWork.php(167): PoolWorkArticleViewOld->doWork()
#19 /srv/mediawiki/php-1.41.0-wmf.30/includes/page/ParserOutputAccess.php(325): PoolCounterWork->execute()
#20 /srv/mediawiki/php-1.41.0-wmf.30/includes/diff/DifferenceEngine.php(1137): MediaWiki\Page\ParserOutputAccess->getParserOutput(WikiPage, ParserOptions, MediaWiki\Revision\RevisionStoreRecord, integer)
#21 /srv/mediawiki/php-1.41.0-wmf.30/includes/diff/DifferenceEngine.php(931): DifferenceEngine->renderNewRevision()
#22 /srv/mediawiki/php-1.41.0-wmf.30/includes/page/Article.php(979): DifferenceEngine->showDiffPage(boolean)
#23 /srv/mediawiki/php-1.41.0-wmf.30/includes/page/Article.php(490): Article->showDiffPage()
#24 /srv/mediawiki/php-1.41.0-wmf.30/includes/actions/ViewAction.php(78): Article->view()
#25 /srv/mediawiki/php-1.41.0-wmf.30/includes/MediaWiki.php(583): ViewAction->show()
#26 /srv/mediawiki/php-1.41.0-wmf.30/includes/MediaWiki.php(363): MediaWiki->performAction(Article, MediaWiki\Title\Title)
#27 /srv/mediawiki/php-1.41.0-wmf.30/includes/MediaWiki.php(960): MediaWiki->performRequest()
#28 /srv/mediawiki/php-1.41.0-wmf.30/includes/MediaWiki.php(613): MediaWiki->main()
#29 /srv/mediawiki/php-1.41.0-wmf.30/index.php(50): MediaWiki->run()
#30 /srv/mediawiki/php-1.41.0-wmf.30/index.php(46): wfIndexMain()
#31 /srv/mediawiki/w/index.php(3): require(string)
#32 {main}
Impact
Notes

This is preceded by numerous warnings: PHP Notice: Trying to get property 'checked'/ 'success' of non-object

https://gerrit.wikimedia.org/g/mediawiki/extensions/Math/+/bf028a142f37b1b849a61b9af605e6c61026045a/src/MathRestbaseInterface.php#372

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix: Handle null errorsPhysikerweltmediawiki/extensions/Mathmaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

Bdijkstra created this task.Oct 16 2023, 12:24 PM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptOct 16 2023, 12:24 PM
Bdijkstra renamed this task from Fatal exception of type "Error" with {{#tag:chem}} and Vector to Fatal exception of type "Error" with {{#tag:chem}}.Oct 16 2023, 12:25 PM
Bdijkstra updated the task description. (Show Details)
Mbch331 subscribed.Oct 16 2023, 12:45 PM
TheDJ added a project: Math.Oct 16 2023, 1:00 PM
Ammarpad renamed this task from Fatal exception of type "Error" with {{#tag:chem}} to Error: Call to a member function getKey() on null.Oct 16 2023, 4:09 PM
Ammarpad updated the task description. (Show Details)
Ammarpad updated the task description. (Show Details)Oct 16 2023, 4:14 PM
• Aklapper changed the subtype of this task from "Bug Report" to "Production Error".Oct 16 2023, 5:40 PM
Restricted Application added a project: Wikimedia-production-error. · View Herald TranscriptOct 16 2023, 5:40 PM
Physikerwelt subscribed.Oct 16 2023, 7:42 PM

There are two ways to move forward: either understanding what input formula causes the problem or emitting a generic error in case the error handler crashes.
I will quickly implement the error handler solution for now.

Physikerwelt claimed this task.Oct 16 2023, 7:43 PM
Physikerwelt added a project: RESTBase.
gerritbot added a comment.Oct 16 2023, 7:54 PM

Change 966291 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Fix: Handle null errors

https://gerrit.wikimedia.org/r/966291

gerritbot added a project: Patch-For-Review.Oct 16 2023, 7:54 PM
Physikerwelt added a comment.Oct 16 2023, 7:57 PM
In T348973#9255350, @Physikerwelt wrote:

understanding what input formula causes the problem

Is hard to guess from that particular context. Thus I suggest ignoring it for now and investigating that later if it still is a problem. However, it might be hard, as Restbase should normally return json, as long it runs as expected.

• hashar moved this task from Untriaged to October 2023 on the Wikimedia-production-error board.Oct 17 2023, 8:15 AM
gerritbot added a comment.Oct 17 2023, 6:52 PM

Change 966291 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Fix: Handle null errors

https://gerrit.wikimedia.org/r/966291

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 17 2023, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 17 2023, 7:10 PM
Physikerwelt added a project: User-Physikerwelt.Oct 21 2023, 9:10 PM
Physikerwelt moved this task from Inbox to Code Review on the Math board.Oct 21 2023, 9:26 PM
Physikerwelt mentioned this in T343648: "Math extension cannot connect to Restbase." error in Wikimedia projects.Oct 24 2023, 4:45 AM
Physikerwelt closed this task as Resolved.Oct 28 2023, 6:33 AM
Bdijkstra added a comment.EditedOct 29 2023, 8:10 PM

I'm not sure if the current situation is an improvement. The diff from the description used to fail most of the time, now it seems to fail all of the time. Should I make a new task for this?

Physikerwelt added a comment.Oct 29 2023, 9:38 PM
In T348973#9289824, @Bdijkstra wrote:

I'm not sure if the current situation is an improvement. The diff from the description used to fail most of the time, now it seems to fail all of the time. Should I make a new task for this?

Yes, please make a new one. The error message and the context will be interesting. In the best case, it will tell what's wrong.

Bdijkstra added a comment.Oct 30 2023, 10:20 AM

I created T350004.

Physikerwelt added a comment.Oct 30 2023, 10:27 AM

@Bdijkstra thank you. To make progress someone needs to find the related logs in logstash and understand what the response from restbase is. Can you do it yourself, or do you need help?

Mbch331 added a comment.Oct 30 2023, 10:52 AM
In T348973#9290518, @Physikerwelt wrote:

@Bdijkstra thank you. To make progress someone needs to find the related logs in logstash and understand what the response from restbase is. Can you do it yourself, or do you need help?

Bdijkstra isn't part of the nda group, so he doesn't have access to logstash. (Neither do I, so I can't find the relevant entries either)

Physikerwelt added a subscriber: daniel.Oct 30 2023, 1:26 PM
In T348973#9290612, @Mbch331 wrote:

Bdijkstra isn't part of the nda group, so he doesn't have access to logstash. (Neither do I, so I can't find the relevant entries either)

Me neither, maybe @daniel can help.

Physikerwelt mentioned this in T350004: Unknown error with #tag:chem.Oct 31 2023, 10:48 AM
In T348973#9291151, @Physikerwelt wrote:

Me neither, maybe @daniel can help.

Ah sorry, this error is completely unrelated. I can look into T350004 any help.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits